It's a requirement of installing the MFA module, which we might make a part of our default recipe eventually. But until then, the restyled login forms themselves provide great value as part of the default recipe: https://github.com/silverstripe/silverstripe-login-forms

Ideally we find a way to only install them in new 4.x installs, and add upgrade instructions for how to opt-in to them for upgrading projects.

Pull Requests

• silverstripe/silverstripe-framework#9112
• silverstripe/silverstripe-installer#257

Description

The following improvements need to be made:

• Replace 4 space indent with a 2 space. ESlint doesn't help.
• Introduce a new library @storybook/addon-docs to present documentation to the components.
• Fix / investigate the reasons for some small warnings that happens time to time in browser console when storybook is running.

AC's

• Component stories have 2 space indent everywhere in the code.
• @storybook/addon-docs is implemented and all stories that have pre-existing readme doc are using it.
• If possible there are not any warnings in the console when storybook is running.

PR's

• silverstripe/silverstripe-admin#1520
• silverstripe/silverstripe-asset-admin#1365
• silverstripe/silverstripe-session-manager#146
• silverstripe/silverstripe-tagfield#245

When using an IDE's "find class" feature, Page and PageController will often match two different files (the one in the project and the one in recipe-cms).

Please can we rename the files to have an extension like .tmpl or whatnot so that IDEs don't recognise them as PHP classes.

When we copy the files into projects we can copy and rename them instead to just copying them.

Related PRs

• silverstripe/recipe-plugin#5
• #10

Cow has incorrectly left out the v3 dependencies for graphql in the 4 and 4.12 branches during merge up.
The actual 4.12.0 stable tag has the correct dependencies.
We already have a card to resolve cow's issues with dual dependencies: silverstripe/cow#207

Acceptance criteria:

• The development branches allow installing the appropriate branch for graphql v3

PRs

• #66
• #67

Example: After editing a related model from a Root.Objects.OneType the user is sent back to Root (or Root.Objects if lucky)

The builds for this modules are currently failing for branches 4, 4.5, 4.4, and probably master. See: https://travis-ci.org/silverstripe/recipe-cms/branches

@maxime-rainville raised a PR which should resolve this: silverstripe/silverstripe-errorpage#47

• Review and merge the PR
• Investigate any still-failing builds, report as issues

The optional SilverStripe recipes (form building, collaboration etc) have all got Travis builds which run the test suites of the modules contained within the recipes. This helps us (A) to know that integration test suites are passing, and (B) to know that any config or project files we add work in context.

We should add Travis builds to this repository and the core recipe

Matching issue: silverstripe/recipe-core#29

The companion to silverstripe/recipe-core#24 for this recipe.

It's probably more important that we get this sorted for the CMS recipe as that's the one that people are being instructed to use as part of upgrades.

Recipe 1.x is deprecated. The current tags should be retained to avoid breaking people's sites, but no new releases should be made. As such I think we should delete the 1, 1.0, and 1.1 branches.

We should do the same to recipe-core as well.

Affected Version
4.13

Description
Create page button is disabled after silverstripe upgrade 4.12 to 4.13.

Steps to Reproduce

1. login into admin
2. go to pages
3. click on add new button
4. step 1 select page level
5. step 2 select page template
6. noticed create button is disabled.

On enhancing the session-manager module, it's something that's likely to provide broad benefit and is almost a baseline feature for any CMS or tool where software users manage their profile.

When considering the path of least resistance on making this module available to projects, this recipe was considered the best place to add it.

Other options that were considered were, from widest distribution to least distribution:
a) require as part of silverstripe/admin (aka "add it to core")
b) require as part of silverstripe/recipe-cms (not recipe-core, that does not include admin)
c) require as part of silverstripe/installer
d) require as part of silverstripe/silverstripe-security-extensions (not even sure what uses this?)
e) manually add to project (this is always an option)

Questions of stability

The silverstripe/session-manager module has been out in the wild for some time with a 0.x tag while early testing and feedback is sought.

We've been managing a bit of testing and user feedback internally, which will help us confirm confidence in tagging the module as stable and including it in this recipe.

Implementation tasks

Tasks required as part of this issue could be:

• Tag the module as stable
• Add the module to recipe-cms
• Tag session-manager version 1.1.0 when all PR's merged and create 1.1 branch
• After PR adding module to recipe-cms has been merged, ensure that session-manager pre-stable is removed from project skeleton
• Ensure the next changelog reflects this change
• Move userhelp docs into core (and out of the 'optional modules' section). See: silverstripe/silverstripe-session-manager#85

PRs - update unit tests to use logInAs()

• silverstripe/silverstripe-admin#1245
• silverstripe/silverstripe-asset-admin#1230
• silverstripe/silverstripe-cms#2679
• silverstripe/silverstripe-framework#10052
• silverstripe/silverstripe-versioned#340

PRs - follow up

• silverstripe/silverstripe-cms#2682
• silverstripe/silverstripe-framework#10073
• silverstripe/silverstripe-framework#10066
• silverstripe/silverstripe-framework#10061

PR - update recipe-cms

• #48 (merge after PRs above)

PRs - Docs

• silverstripe/silverstripe-framework#10042
• silverstripe/silverstripe-session-manager#86
• silverstripe/silverstripe-userhelp-content#164

PRs - Sink (remember to merge-up)

• silverstripe/silverstripe-gridfieldqueuedexport#50

SwiftMailer v6 not allowing spaces at start or end of email addresses

• (not session-manager though still breaking sink)
• silverstripe/silverstripe-framework#10065

TODO

• Probably skip some framework tests related to RememberLoginHash if session-manager is present and rely on the session-manager unit tests instead - see comment below

The problem
I had failing tests in Travis because I was pulling down Recipe-CMS 1.2.
https://github.com/silbinarywolf/silverstripe-phpstan/blob/dev-ss4/.travis.yml#L25

I had to update my PHPStan tests to allow for two different types, SiteTree / SiteTreeLink:
https://github.com/silbinarywolf/silverstripe-phpstan/blob/dev-ss4/tests/Reflection/SiteTreeMethodClassReflectionExtensionTest.php#L79

This was caused by this:
silverstripe/silverstripe-versioned#75 (comment)

The solution
Since the public return types of a function have been changed, I think Recipe-CMS should be bumped to the next MAJOR version so it adheres to semantic versioning. (And anything else that uses the future version of silverstripe-versioned will need a MAJOR bump)

Hi Team,

We have just updated recipe-cms 4.11 to 4.12 after that when we build project we star getting errors on CLI as well on WEB Page.

Errors:

PHP Deprecated: SilverStripe\Core\BaseKernel->getEnvironment is deprecated. Use Director::get_environm
ent_type() instead. Called from SilverStripe\Control\Director::get_environment_type. in /var/www/vendor
/silverstripe/framework/src/Dev/Deprecation.php on line 253

PHP Deprecated: SilverStripe\Core\BaseKernel->sessionEnvironment is deprecated. Use Director::get_sess
ion_environment_type() instead. Called from SilverStripe\Core\BaseKernel->getEnvironment. in /var/www/v
endor/silverstripe/framework/src/Dev/Deprecation.php on line 253

PHP Deprecated: SilverStripe\Core\BaseKernel->getEnvironment is deprecated. Use Director::get_environm
ent_type() instead. Called from SilverStripe\Control\HTTPApplication->getEnvironmentType. in /var/www/v
endor/silverstripe/framework/src/Dev/Deprecation.php on line 253

PHP Deprecated: SilverStripe\Core\BaseKernel->sessionEnvironment is deprecated. Use Director::get_sess
ion_environment_type() instead. Called from SilverStripe\Core\BaseKernel->getEnvironment. in /var/www/v
endor/silverstripe/framework/src/Dev/Deprecation.php on line 253

PHP Deprecated: SilverStripe\Core\BaseKernel->getEnvironment is deprecated. Use Director::get_environm
ent_type() instead. Called from SilverStripe\Core\BaseKernel->bootPHP. in /var/www/vendor/silverstripe/
framework/src/Dev/Deprecation.php on line 253

PHP Deprecated: SilverStripe\Core\BaseKernel->sessionEnvironment is deprecated. Use Director::get_sess
ion_environment_type() instead. Called from SilverStripe\Core\BaseKernel->getEnvironment. in /var/www/v
endor/silverstripe/framework/src/Dev/Deprecation.php on line 253

ERROR [User Deprecated]: SilverStripe\Versioned\Versioned->allVersions is deprecated. Use Versions() in
stead. Called from SilverStripe\Versioned\Versioned->Versions.
IN GET dev/build
Line 253 in /var/www/vendor/silverstripe/framework/src/Dev/Deprecation.php

ERROR [User Deprecated]: SilverStripe\Control\HTTP::augmentState is deprecated. Use HTTPCacheControlMid
dleware instead. Called from SilverStripe\Control\Middleware\HTTPCacheControlMiddleware->process.
IN GET dev/build
Line 253 in /var/www/vendor/silverstripe/framework/src/Dev/Deprecation.php

ERROR [User Deprecated]: Config SilverStripe\Control\HTTP.cache_ajax_requests is deprecated. 'HTTP.cach
e_ajax_requests config is deprecated.
IN GET dev/build
Line 221 in /var/www/vendor/silverstripe/framework/src/Dev/Deprecation.php

Help us here please.

BUG: History Records are not showing the page version state correctly #255

The Records in History tab of a page are not showing the page version state correctly.

• It shows 'Published' when the page is actually only saved but not published
• All version records turn to 'Saved' except for the first 'Created' record when the page is 'unpublished'

I notice that Page.php and PageController.php use the array() notation. However, the installer specifies that at least php 5.6 is required, so the shorter [] notation is always available. Should we not encourage this new syntax by starting the default Page class with it?

PSR does not really make a point about it, but it seems a de facto standard since they do use it in their examples. I do notice that the Framework and CMS packages have a mix of both, but using the new syntax in the Page.php and PageController.php classes could be a first step towards encouraging both old and new developers to use it everywhere.

Also see this StackOverflow issue. I would agree with the statement "Only use array() if you want your script to run on PHP <5.4."

Trying to create project via composer using this repo as a base (as suggested in the readme) fails to fully install necessary files.

composer create-project silverstripe/recipe-cms --prefer-dist .

Go to localhost/websitename (in this case project folder was callled contracts)

( ! ) Fatal error: Uncaught UnexpectedValueException: RecursiveDirectoryIterator::__construct(C:\wamp64\www\contracts\public\assets,C:\wamp64\www\contracts\public\assets): The system cannot find the file specified. (code: 2) in C:\wamp64\www\contracts\vendor\silverstripe\framework\src\Dev\Install\InstallRequirements.php on line 288
--

1 | 0.0022 | 407152 | {main}( ) | ...\install.php:0
2 | 0.0057 | 408040 | include( 'C:\wamp64\www\contracts\vendor\silverstripe\framework\src\Dev\Install\install.php' ) | ...\install.php:15
3 | 0.0083 | 409080 | include( 'C:\wamp64\www\contracts\vendor\silverstripe\framework\src\Dev\Install\install5.php' ) | ...\install.php:25
4 | 0.2722 | 682280 | SilverStripe\Dev\Install\InstallRequirements->check( ) | ...\install5.php:69
5 | 0.2841 | 691544 | __construct ( ) | ...\InstallRequirements.php:288

Either the assets folder needs to be included as in the installer repo, or the readme should be updated to indicate this can't be used as a project base.

Workaround
just copying and pasting in the assets folder and its files from the installer repo mitigates this issue.