silexlabs / cloudexplorer2 Goto Github PK

Right now when you try to login to ftp and give the wrong login or pass, the error is displayed as JSON
There should be a page to display auth errors for FTP
Then we should use this page also for SFTP and maybe other services too
CC @JbIPS

When I run CE2 demo, I double click on "fs" and it opens a blank window
The fs service do not need a popup so the URL returned by /fs/authorize is empty and a window should not open at all

On the demo page, when I set filters, it still displays all the files
It used to work properly, do you have an idea of what could have changed @JbIPS ?

I tried to download a ZIP file from my FTP (BTW, awesome to have an online FTP explorer!) by clicking on the download button, but it opened a new tab with some garbage data in it.

Why isn't it downloading normally?

When the user "save as" a file, he/she is asked a name, and when the chosen name is already in the file list, a "are you sure?" dialog should ask to confirm

When I login with FTP on an unreachable server, it crashes the nodejs app

For example, on an instance which is online, host set as localhost

Then

When the user has to select a folder: if there is no selection then enter should select the current folder (otherwise, if there is a selection it enters the selected folder as it already does it)

npm version : 6.5.0
node version : 11.8.0

Maybe it's a personal opinion but I think when you click on a breadcrumb you should cd in this directory, not in its parent as it is today.

Many clickable zone do not have a cursor: pointer; style

Probably many other UI/UX mistakes in CE2 (every time the user click, something should happen immediately...)

When the user logs in to FTP or SFTP, the auth page sends the password in get to cloud explorer's router

We should avoid that and use POST data

This is an assynchronous request which should be synchronous
https://github.com/silexlabs/CloudExplorer2/blob/master/src/js/UnifileService.js#L168

At runtime I have this warning message:

"Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs"

Bug report from @tariqbenezza in Silex project:
silexlabs/Silex#668

It looks like we build CE with the development version of react
https://reactjs.org/docs/optimizing-performance.html#use-the-production-build

At least this is the case on the demo page
http://cloud-explorer.org/

The API link is broken

When I activate the webdav service on my Silex instance, webdav bug
Error: Unknown connector: webdav

Must be something in CE2 router... or unifile

When i clicked "local" and tried deleting some files. It's actually deleting the files that are used to run the example. So now it's dead xD

Comment pourrais je faire pour ajouter un forum (sans iframe)

Since recently (I think)
When I try to upload an image, it contains errors
I tried with fs on chrome and with dropbox on firefox

the build fails on heroku, it says

       > [email protected] build:sass /tmp/build_ebcfe0756f037b5b6357e660e375b000/lexoyo-CloudExplorer2-7046414
       > node-sass --include-path src/sass --include-path node_modules/font-awesome/scss src/sass/style.scss dist/style.css
       sh: 1: node-sass: not found   

I just received a message warning me of exposed credentials:

Hi Folks!
I just wanted to give you a heads up that my team detected some exposed credentials within the CloudExplorer source repository on GitHub. (I got your e-mail addresses from the npm ownership data for CloudExplorer.)
I don't know if the creds are still active or carry any risk, but wanted to let you know anyway. The creds are for Dropbox, GitHub, and Unsplash.
https://github.com/silexlabs/CloudExplorer2/blob/main/lib/index.js#L35C5-L48C95
https://github.com/silexlabs/CloudExplorer2/blob/main/README.md
https://github.com/silexlabs/CloudExplorer2/blob/main/lib/index.js#L63
Thanks!!
Mike

When I upload more than 1 image at once, the images are corrupted
I tried

• on firefox
• 2 and 3 images
• with the OS file explorer and with drop files in the browser
• github and dropbox

In the last commit there two changes that produces errors: static render in KeynavsBoard adn sttic getService in App.jsx. They are static but they are called as non static methods in React modules.

Hi, silly question: how do I get webdav enabled?

In some cases we need to have only 1 service and skip the list of services. For example the downloadable/offline version of Silex needs only the FS service. Another use case is a hosting company willing to host files only on their servers.

So there are a few things to do

• when the list of services is displayed, if there is only one service, open this service
• when the user is trying to list a folder and he is not authenticated, display a popin with the links
  • log in => call the authenticate route and open a popup for oauth
  • register => open an external link
  • back to "/" => cd /
• hide the service from the bread crumbs
• optional idea: even if there is multiple services, allow the calling app to specify a "root path" and skip the services list, and sandbox the user to this folder, e.g. /github/myrepo/gh-pages/ or /ftp/htdocs/

For now the image banks show a fixed number of results
It would be nice to load more photos when the user scrolls down

• add a page number in the routes of image banks
• make API call when the user scrolls and reach the bottom of the list (in thumbnail view only)

In order to display image thumbnails, I will create a different view specific to images

This mode will be used when the API is called like this:

ce.openFile(['.jpg', '.jpeg', '.png', '.gif'])
.then(fileInfo => {
    ...
})

This means these tasks

• new "mode" for images, with thumbnails list
• new design
• resize images on the fly

If anyone has ideas (design or code) please comment :)
cc @clemos @ceubri @suddenheroes

When a file (or even a folder?) is selected, it should be possible to display details about the file, such as weight, dates and type... And most important a preview.

Probably something like gdrive "file details":

When I try to "save copy" or "save as", the selected file is not saved and I get the next error message:
App.jsx:95 Uncaught (in promise) Error: Invalid data. You must provide a String or a File at App.jsx:95 at Array.map (<anonymous>) at App.write (App.jsx:90) at ce.read.then (demo-page.js:82)

All permisions are right, and I can create folders and so, but I can't save.

Connectors that use a login form use an old URL callback (as in silexlabs/Silex#710). This should be updated.

While we're playing with those URL, we should create an POST endpoint to retrieve the form value without putting them in the URL, hence closing #35

When trying to rename a folder I hit Enter key and this cd into the folder, not renaming it. The behavior of Enter should be the same as when creating a folder.

We should cleanup the code to remove linter warnings, i.e. do npm run lint and fix the warnings

When the user uses the keyboard arrows to move the selection, if the selection is on a file or folder which is not visible, the view should scroll so that the selection is visible.

When installing the lib via npm, I get an error with the postinstall script:

cp: cannot stat 'node_modules/font-awesome/fonts/*': No such file or directory
cp: cannot stat 'node_modules/npm-font-open-sans/fonts/*': No such file or directory

When I have already authorized access to a service, and I enter this service again, CE2 opens a popup for me to authorize again. This should not be the case

What I do

• open CE2
• double click on github
• authorize access to my github
• click the little "house" to go back to "/"
• [optional] close CE2 window and come back later
• double click on github again

What happens: a popup opens and goes to github, then github redirects to the callback page which closes the popup

What I expect: do not open a popup, enter github folder immediately

Also when the service is FS, the user is always logged in so we should not open a popup and close it when "/authorize" returns an empty URL

To do that, I am supposed to

• use the code of this PR so that "/services" route will return a list of services with the "isLoggedIn" field
• when CE2 is initialized, I need to always load "/services", not just when we have an initial route set to "/"
• store the services in UnifileService class, do not cache it
• when the user wants to access a service, check UnifileService::services and see if isLoggedIn is true, in which case it will not open a popup
• when the user authorizes us to access a service, update UnifileService::services with isLoggedIn set to true
• when the an access error occures, update UnifileService::services with isLoggedIn set to false

It would be very helpful to let the user mark some folders as favorite or to memorize the "recent places" i.e. the folders in which the user has opened files from recently

One or the other would add the folders to a menu so that the user can select them to "cd" into one of them directly

😨