sii / siptrackd Goto Github PK

Hi,
It seems that both storage engines are imported unconditionally here. Should they be?

I'm using sqlite only
Commenting out stmysql import made it work

New node type called CI, Item or Configuration Item. To make the whole tool into a more general asset management tool not so fixated on "devices".

Have a user with three previously connected sub keys but trying to connect any other key to that user now results in no errors and no connected keys.

Have also tried through the API so I believe this is a siptrackd issue.

Will assign to myself since I have access to the DB.

Need a new attribute type added that is a large encrypted textfield.

Either a new password type or a new attribute type, whatever it is the field must be a large textfield with encryption.

It appears that when merging master into eventlog-2, after basing eventlog-2 on eventlog branch, I made some mistakes with the merge conflicts.

One example of this is in siptrackd_twisted/attribute.py in Attribute.xmlrpc_set_value. Compare the file from eventlog-2, with the file from master.

You'll see that the code in master is simpler, cleaner and more modern I assume.

So the eventlog branch was so old that it did not incorporate all these modernizations @sii hade made. And when I merged master into eventlog-2 to update it I missed this.

So I'm writing this issue as a warning for myself and others when it's time to merge eventlog-2 into master we need to be very careful about resolving merge conflicts correctly.

I would recommend doing the merge locally, not through github. And going through every merged file, comparing them to the current remote master branch on github. So we don't overwrite anything with old code.

Considering the database structure today I think it's more than possible to implement version control of certain objects.

The theory would be to have a new table and whenever an object is updated copy the old object to this table with some version info and a reference back to the original node. And then rotate the objects in this new table to conserve space.

This would be a neat frature when people screw up and accidentally delete devices.

Triggered by the new reconnect feature for password keys in the user profile page.

The reconnect feature uses isValidPassword to check the password before disconnecting the old key. Apparently very long passwords cause this error.

  File "/home/siptrack/siptrack/siptrackd/siptrackd_twisted/helpers.py", line 86, in wrapped_f
    ret = func(*args, **kwargs)
  File "/home/siptrack/siptrack/siptrackd/siptrackd_twisted/password.py", line 98, in xmlrpc_is_valid_password
    ret_value = pk.isValidPassword(test_password)
  File "/home/siptrack/siptrack/siptrackd/siptrackdlib/password.py", line 263, in isValidPassword
    verify_crypt = self._encrypt(password.padded, self._verify_clear.get())
  File "/home/siptrack/siptrack/siptrackd/siptrackdlib/password.py", line 223, in _encrypt
    aesobj = AES.new(password, AES.MODE_ECB)
  ValueError: AES key must be either 16, 24, or 32 bytes long

If default user manager is AD or LDAP then users should be synced each time siptrackd starts up.

After enabling permissions I've discovered that everytime siptrackd starts up some users lose their read permissions in Siptrack until a sync has been performed.

So I suggest this is done at startup.

In default install with local password manager I am unable to change the admin user password.

Traceback:

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/django/core/handlers/exception.py" in inner
  41.             response = get_response(request)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/django/core/handlers/base.py" in _legacy_get_response
  249.             response = self._get_response(request)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/siptrackweb/views/helpers.py" in authwrapper
  54.                     return func(request, *args, **kwargs)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/siptrackweb/views/user.py" in reset_password_post
  321.     user.resetPassword(new_password)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/siptracklib/user.py" in resetPassword
  219.         self.transport.resetPassword(self.oid, password)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/siptracklib/transport/xmlrpc/user.py" in resetPassword
  21.         return self.send('reset_password', oid, password)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/siptracklib/transport/xmlrpc/baserpc.py" in send
  9.                 *args)

File "/var/opt/siptrack/venv/lib/python2.7/site-packages/siptracklib/transport/xmlrpc/transport.py" in _sendCommand
  197.                 raise SiptrackError(faultstring)

Exception Type: SiptrackError at /user/password/reset/post/3/
Exception Value: 'tuple' object has no attribute 'isValidPassword'

The issue seems to be in siptrackd but this is the exception returned by siptrackweb.

When we reset password of a user, we are getting following error.
"'tuple' object has no attribute 'isValidPassword'"