signnow / signnownodesdk Goto Github PK

We were integrating the API into our site we are launching in 3 weeks and during development/testing we are not able to upload two documents using the node package with different tokens. The first one uploads fine, then when we go to upload the second document we try to generate a second token and get a timeout error.

I have uploaded a sample script that demonstrates the second token hanging and then timing out with no response back from the endpoint.

https://github.com/tmcpro/signnow-issue

cc: @diego-pacheco

I'm testing this tutorial 'Creates a link for the embedded invite.' and one of the example.

It returns this error:
"error": "Error 500: TypeError: Cannot read properties of undefined (reading 'unique_id')"

My code is below:

``const email_address = 'mygmail.com';
const templateDocId= 'docIdStringhere'  //SignNow templateId;
const fieldInvite = {
            unique_id: templateDocId,
            from: "mygmail.com",
            to: [
                {
                    email: email_address,
                    role: "Signer 1",
                    order: 1,
                    reassign: "0",
                    decline_by_signature: "0",
                    reminder: 4,
                    expiration_days: 27,
                    subject: "Field invite Signer1",
                    message: "Message",
                },
            ],
        };
const sign_invite = await new Promise((resolve, reject) => {
            signNowAPI.template.invite(
                {
                    data: {
                        ...fieldInvite,
                    },
                    id: templateDocId,
                    token: signNowToken,
                },
                (error, response) => {
                    if (error) {
                        reject(error);
                    } else {
                        resolve(response);
                    }
                }
            );
        });
        ``
        ```

Currently, it appears that the only way to request an authorization token using this SDK is by using grant_type: 'password' and passing the appropriate credentials.

When using 3-legged OAuth2 and SignNow's login portal, external to a 3rd party application, an authorization code is returned as a query parameter in the redirect, and cannot be used with this SDK's OAuth2 requestToken method to fetch the proper authorization token response. In its place, a basic HTTPS call must be used, nullifying the point of using this SDK for auth purposes.

Just as the title says. I tried adding the content-type header, but issue persisted. I am now making the request with the "request" library and everything works as it should.

api.document.move not exists

https://docs.signnow.com/reference/oas/document/postdocumentdocumentidmove

The request causes a server side failure because the Content-Length header is not set.

Related to #1

When trying to upload a pdf (right now it seems like any pdf with more than one page will fail), I receive this error message in the response body: { errors: [ { code: 65536, message: 'Must upload one file' } ] }

I have uploaded an example providing 2 pdf files, one that fails, and one that succeeds.

See reproducible error here: https://github.com/diego-pacheco/signnow-issue

cc: @tmcpro

Hi
if any possible to implement in angular for signnow.
If you can provide module for angular frameWork? or any other tutorial

As a SignNow API client user I need an ability to download signed document with its attachments. Add an option to Document.download feature to make it possible.

Publishing edits from the SignNow dashboard does not seem to trigger webhooks that were created using this library.

Is this because currently the dashboard utilizes Webhook 2.0 while this library does not?

If so, any plans to bring the webhook part of the module up-to-date with the current REST API?

Hi there,

I'm currently trying to incorporate the SignNowSDK into a project that is using esbuild.

Unfortunately, it seems that setEnvConfig() uses dynamic require() statements that are causing our build to fail.

const setEnvConfig = env => {
  if (env) {
    currentEnvironment = env;
    return Object.assign(currentConfig, require(`./${env}/`));
  }

  return Object.assign(currentConfig, require(`./${currentEnvironment}`));
};

A quick and easy solution to this is to not use the dynamic requires statements, even if it means adding a small amount of code duplication.

const setEnvConfig = env => {

  if (env) {
    currentEnvironment = env;
    if (env === 'eval') {
      return Object.assign(currentConfig, require('./eval'));
    }
    if (env === 'prod') {
      return Object.assign(currentConfig, require('./prod'));
    }
  }

  return Object.assign(currentConfig, require(`./${currentEnvironment}`));
};

There may be a nicer way of writing this to remove the additional level of indentation from the added ifs of course but the point is we aren't using variables in the require().

Would it be possible to add this (or a better) fix to avoid dynamic require() statements? It would be a shame to fork and maintain a repo for such a small fix 👍

Thanks in advance for the feedback and/or help!

If you can provide a module for NestJS framework? or any tutorial?

Hi,

I'm experiencing a serious issue using

document.remove(MYID, { cancelInvites: true})

This cause a non catchable error because there is a error on line
https://github.com/signnow/SignNowNodeSDK/blob/master/lib/document/index.js#L962
with error saying Document not found because document was previously deleted on this line
https://github.com/signnow/SignNowNodeSDK/blob/master/lib/document/index.js#L1019

The big issue is that this error is not catch by a .catch method and throw without any option to be catched by code calling document.remove

Hi
if any possible to implement in angular for signnow.
If you can provide module for angular frameWork? or any other tutorial