signnow / signnow.netsdk Goto Github PK

Method and property names should be PascalCase and not contain underscores. See Capitalization Conventions. It is very odd API to use from a .NET perspective otherwise.

Relevant sections:

When an identifier consists of multiple words, do not use separators, such as underscores ("_") or hyphens ("-"), between words. Instead, use casing to indicate the beginning of each word.

and:

Do use Pascal casing for all public member, type, and namespace names consisting of multiple words.

When an exception is thrown, the details of the exception are not available. For example, here.

The catch block should set the inner exception of the new exception, or remove the try/catch block.

Also, SystemException should not be used here. See the important notes on this msdn page. It states:

Because SystemException serves as the base class of a variety of exception types, your code should not throw a SystemException exception, nor should it attempt to handle a SystemException exception unless you intend to re-throw the original exception.

CudaSign's nuget package includes its own versions of Newtonsoft.Json.dll and RestSharp.dll, which is an incorrect use of Nuget.

Instead, the CudaSign nuget package should have dependencies on the Json.NET and RestSharp packages.

Do you have any sample code for signnow webhook integration with .Net web api application

The Smart Field integration requires the API call to use a POST, not PUT.

https://github.com/signnow/SignNow.NETSDK/blob/master/CSLibrary/Document.cs#L74

I'm happy to submit a Pull Request adding an optional overload in the Document.Update() method if the team is open to that.