Invalid base64 when viewing dead job about sidekiq HOT 5 CLOSED

I’ve never seen this. I suspect we’ll need to see the actual job payload to diagnose.

from sidekiq.

These are the job args.

108949587, 43342709, 521298525, 2778

from sidekiq.

Tracked it down. This is due to this change.

8506d94

This is the backtrace that was created before the change and can no longer be read by the new code.

"eJwdy00OwiAQBtCrGDZujERjXPQqxoxQPmV0WugM2Ov78/bv4kKt/lmi+Qe3\n3KNX1B6FLVPtIqRYOqzRmjGTtdBAEWOZYDRKMST65r3G4XgeeN7cKvRedNq6\
nnROO3jjhxQtNnJJgDQpv0DfUr7mkPs/cfvlw+ucxiGzd9QPLSDft\n"

from sidekiq.

Looks like we should have used m rather than m0 as the unpack directive?

https://github.com/ruby/base64/blob/9669a7d3b0e3b9a739969404daf58f912c58c6b3/lib/base64.rb#L242

from sidekiq.

It was using lax encoding/decoding previously, I changed it to strict on request.

It may be safe to simply switch back to that: while a lax encoded string raises on strict decoding, the opposite direction works just fine:

Base64.decode64(Base64.strict_encode64("abc"))
# => "abc"

Base64.strict_decode64(Base64.encode64("abc"))
# => <internal:pack>:29:in `unpack1': invalid base64 (ArgumentError)

I however haven't tested this further than the above example.

from sidekiq.