The plugin's shortcode currently looks like this: [slick_carousel id="85" width="400" height="200" slidetoshow="3" slidetoscroll="1" infinite="true" arrows="true" adaptiveheight="true" lazyload="ondemand"].

But we actually parameters passed to JS Object actually do NOT come from the shortcode attributes. They come directly from the options attached to a post.

Do we really need all shortcode attributes then?

It could just be [slick_carousel id="85"], since the user can modify the shortcode using the options. And every slider should be tailored for a specific use, so that images are re-sized, etc.

Warning: unlink(D:\www\wordpress/wp-content/uploads/): Permission denied in D:\www\wordpress\wp-content\plugins\slick-carousel-reloaded\includes\functions-resize.php on line 64

@julien731

HTML needs to be updated accordingly... http://kenwheeler.github.io/slick/

// To use lazy loading, set a data-lazy attribute
// on your img tags and leave off the src

<img data-lazy="img/lazyfonz1.png"/>

$('.lazy').slick({
  lazyLoad: 'ondemand',
  slidesToShow: 3,
  slidesToScroll: 1
});

Replace it with https://github.com/johnbillion/extended-cpts

• John Blackbourn is a WordPress Core contributor, working for Human Made
• The class seems to be much more maintained

Do you approve @julien731 ?

It seems complex to load a script only if the shortcode is used. I see a few options:

• Create an inline script tag manually for each slider (the shortcode will then output HTML + script tag at the same level)
• Get all sliders parameters and pass them using wp_localize_script. Is this possible?
• Pass the parameters as data attribute of the slider markup. With a declarative markup, we can then read those using jQuery and initialize each slider individually.

For now, our plugin is compatible with https://wordpress.org/plugins/wp-gallery-custom-links/faq/.

It would be better to stop relying on a third-party plugin and do it myself. Add a field "Slider Link" as we don't need those options:

• Gallery Link Target [?]
• Gallery Link OnClick Effect [?]
• Gallery Link Additional CSS Classes [?]

https://github.com/desandro/imagesloaded

It could be helpful to add the following columns:

• Slider Size
• No. of images
• Size of uploaded images?

Add basic default style, but turn it off by default?

The Titan Framework is currently loaded twice. First by the autoloader in the plugin, second with the Titan Framework plugin that is required to run Slick Carousel Reloaded.

This actually triggers an error (in my environment at least).

Solutions

Obviously, one version of TF must be removed. Best practices would suggest keeping the version that's autoloaded but any one version can be removed.

Removing the Autoloaded Version

Because this version seems to be used solely for checking if TF is present, what's really useful is the TitanFrameworkChecker class. This class could simply be extracted and added in the plugin. It doesn't really need to be updated anyways.

Removing the Plugin Version

In this case, the only thing needed is to remove the call to titan-framework-checker.php.

Localhost is not being detected...

Adding custom parameters generates the following:

var wpscr = {"sliders":{"220":{"width":480,"height":300,"slidetoshow":1,"slidetoscroll":1,"infinite":true,"dots":false,"arrows":true,"adaptiveheight":false,"lazyload":"false","customparameters":""},"213":{"width":1500,"height":400,"slidetoshow":1,"slidetoscroll":1,"infinite":true,"dots":false,"arrows":true,"adaptiveheight":false,"lazyload":"false","customparameters":"nextArrow: '<div class=\"glyph-icon flaticon-next\"><\/div>',\r\nprevArrow: '<div class=\"glyph-icon flaticon-prev\"><\/div>'"}}};

Need to remove the 'customparameters' and append value like index: value to the existing parameters. Also remove the line breaks and sanitization.

We need to hide the editor and add a notice "You need to specify the slider size before uploading pictures.".

The size needs to be defined first, so that the images are correctly re-sized.

If gallery has captions, display them: vertically centered, horizontally centered to the left.

Add slider option: Enable/Disable captions

It currently resizes proportionally, which leads to inconsistency between the slider size in the Dashboard, and the actual slider size on the front-end.

Dashboard Slider Settings

Chrome Dev Tools (Front-End)

@julien731

At the moment, once a slider is created and images are uploaded, the size can be changed.

However, if the size is changed after images were uploaded, those images won't be resized. Using a plugin the regenerate image sizes won't work. That's the drawback of using conditional image sizes.

I think it would make sense the lock the slider size after it's created so that the user can't change it. For changing the size, the user would have to create a different slider.

The function wp_get_attachment_image creates responsive images, which don't play well with Slick atm.

There is one option in the general settings of the plugin, but it's not used yet...

Is there a need for "on-the-fly image manipulation" settings?

This feature is not yet implemented. The add_image_size is great, but I want the size to only apply to sliders, not the whole media library...

Is this possible? Or should it be resized using something else?

• https://developer.wordpress.org/reference/functions/add_image_size/
• https://github.com/eventviva/php-image-resize
• http://php.net/manual/en/book.imagick.php

The problem

• To embed TF properly, we need to use titan-framework-embedder.php instead of titan-framework.php which is loaded by Composer (See this).
• Extended CPTs currently does not support Composer autoload. See this pull request

In the end, I don't think it's useful to show all parameters of the slider. It's actually counter productive.

The amount of images, size and the shortcode should be enough.

In my opinion, slider images should be uploaded in its own folder. Maybe using something like this:

<?php

/**
 * Change Upload Directory for Custom Post-Type
 *
 * This will change the upload directory for a custom post-type. Attachments will
 * now be uploaded to an 'uploads' directory within the folder of your plugin. Make
 * sure you swap out 'post-type' in the if-statement with the appropriate value...
 */
function custom_upload_directory($args) {

    $id     = $_REQUEST['post_id'];
    $parent = get_post($id)->post_parent;

    // Check the post-type of the current post
    if ('slider' == get_post_type($id) || 'slider' == get_post_type($parent)) {
        $args['path']    = plugin_dir_path(__FILE__) . 'slider_uploads';
        $args['url']     = plugin_dir_url(__FILE__) . 'slider_uploads';
        $args['basedir'] = plugin_dir_path(__FILE__) . 'slider_uploads';
        $args['baseurl'] = plugin_dir_url(__FILE__) . 'slider_uploads';
    }
    return $args;
}
add_filter('upload_dir', 'custom_upload_directory');

If the [slick_carousel id="213"] is not used in a page/post, then the JS object is not created and therefore, the slider isn't initialized.

Detect is the plugin is already loaded (from theme or plugin). If it is, then use it, otherwise load it.

if ($.fn.slick) { ... }

Will this be accepted on WordPress.org?