shubham1710 / mern-e-commerce Goto Github PK

I would like to report some errors that I have found in your add_cart_item controller. These issues have gone unnoticed and I believe they need to be addressed. Here are the details:

When an item is added to the cart and there are existing items in the cart (if(itemIndex > -1){...}), the price of the new item(s) is not being updated. This could lead to incorrect billing and confusion for the user.

Similarly, when there are existing items in the cart (if(itemIndex > -1){...}), the old total price of the item is not being subtracted from the bill. This could cause issues if the admin changes the price of a product item and the user ends up buying it at the old price.

To resolve these issues, I suggest the following new code:

if (itemIndex > -1) {
let productItem = cart.items[itemIndex];
cart.bill -= productItem.quantity * productItem.price; // Subtract the old total price of the item from the bill
productItem.quantity += quantity;
productItem.price = price * productItem.quantity; // Update the price of the item in the cart
cart.items[itemIndex] = productItem;
} else {
cart.items.push({ productId, name, quantity, price: price * quantity });
}

I tried to clone the repository and tried running it but couldn't as i was getting an error saying stripe api key isn't defined in config, could you tell a fix for that.

while running client using npm run start I am facing following error