sholybonoly / covid19_edi_app Goto Github PK

The postcode finder picks up EH16 as a postcode - is this what we want it to do.
Similarly it fails to pick up EH93HJ as a postcode when it is the only one
However, when there was a list it did pick up EH93HJ as a postcode, but failed on EH13 9DH, when the latter was split over 2 lines.

These are all tests in tests/PostcodeFinderTest.py

This function returns a dictionary of a dictionary, so
PostcodeProcessor.getLatLongFromPostcode()['result']['latitude'] gives you the latitude, and similarly for longitude.

We should do a separate function that processes to get this dictionary if it is used elsewhere and then a function that returns latitude and longitude as a tuple, or namedtuple

After updating the relay to forward messages on to the nearest group, I was able to successfully test only once

Thereafter, no forwarded message was received.

No errors were thrown by the code, the emails were labelled processed, but nothing appeared in the test group email account.

I tried this with multiple email addresses, I would receive the first message, then nothing after.

Use KML file to check that validity of postcodes

Use KML file to find nearest postcode if no volunteer in that postcode

Need list of nearest volunteers for area as individual volunteer may be busy or inactive for a time.

What?

Implement caching of location and distance data to minimising the number of external API calls and calculations required.

We could cache:

• the latitude and longitude of postcodes
• the distance between two postcodes

Why?

If we receive a lot of emails, there's the potential for us to make a lot of external API calls and maybe even get throttled. That wouldn't be great! By caching the location data, we'll be able to minimise the risk of throttling/blocking and get a performance boost.