shinesolar / emailsignature Goto Github PK

Describe the solution you would like: We need to have the peak PWA experience for iOS

Does other service/app have this feature? This link is THE resource for Apple PWA stuff:
https://medium.com/appscope/designing-native-like-progressive-web-apps-for-ios-1b3cdda1d0e8

Additional Context: Most of everybody in the company has an iPhone. This will be pretty important especially once we have a mobile version working.

Is your feature request related to a problem? Please Describe: You can't use the signature creator on mobile because of the way things copy over into the email signature creator, so on mobile there's just a splash screen that says it doesn't work on mobile.

Describe the solution you would like: Ideally we would hook into an API that would do this automatically. But, it doesn't look like that is a possibility, so we need more of an "out-of-the-box" thinking.

Does other service/app have this feature? Yeah G-Suite has a pretty dang good API for this kind of stuff.

Describe the bug - Because we were trying to create the freshest content for the index file, we aren't caching it or returning it from the cache at all, so when someone navigates to it with a poor (or no) internet connection, the page just crashes and says 'something went wrong'. We need to be caching all necessary files and returning them in this way: network, falling back to cache: https://developers.google.com/web/fundamentals/instant-and-offline/offline-cookbook/#network-falling-back-to-cache

To Reproduce Steps to reproduce the behavior:

Make sure you've navigated to signatures.shinesolar.com before, then turn your wifi off. Now navigate there again. You should see the issues

Version:

OS w/ version: macOS Mojave version 10.14.1
Browser w/ version: Chrome 71

Is your feature request related to a problem? Please Describe: The model file is bloated and we have the ShinePHP library built specifically for this

Describe the solution you would like: We need to get the ShinePHP library introduced to clean up the model file and allow more modularity into the data that can be accepted

Does other service/app have this feature? N/A

Additional Context: We need to bring all code written by the company into compliance with ShinePHP

Describe the solution you would like: Instead of the cobbled together SCSS, we need the brand stylesheet and then build this specific app's styles on top of it.

Additional Context: We need to bring everything inline with our development and style process. This is a major step.

The bugs I'm filing don't really follow the bug reporting template, I should probably change it up.

The add to homescreen button is a disgusting blight on an otherwise pretty good application. I want to change it. That probably means changing up the whole flow or not even including an add to homescreen button at all because it should only be used once by anyone. ie, just because we can, doesn't mean we should.

Is your feature request related to a problem? Please Describe: The problem is the no-js and js version of the app are served in the same place, and it's getting in the way of UX tricks that we could do.

Describe the solution you would like: The application needs to be usable and accessible AT A DIFFERENT URL then what it's at currently. At the current URL I want to improve the JavaScript a lot, but I want to make sure that doesn't inhibit the current usability.

Additional Context: The experience could be improved (in subtle ways, but definitely any experience improvement is a major one), but we still want this application to be accessible in any browser, by anybody (within reason, we're not shooting for Netscape support here!!!)

Is your feature request related to a problem? Please Describe: We don't want anybody to just be able to put any job title for themselves. It decreases the look and feel of the brand when for one specific job title there are, like, 20 different job titles floating around, all with little variations on top of one another.

Describe the solution you would like: An API that you query that returns the allowed job titles, then on the backend, a simple admin platform that allows you to edit the job titles that can be returned.

Additional Context: It's not a super important feature, but definitely one to implement in the future.

Describe the solution you would like: It would be a completely different feel and a completely different app flow. it would be a three step process:

1. Land on app page, choose whether you're going for Shine Home or Shine Solar

• Build for customizability, so that when more branches of the company are added, it would be easy to add more selections.

2. After the company branch choice, give a choice of like 4-6 different email signature templates. Choose one.
3. This third step will be most similar to how the page is now. Based on the signature templates, it will build a form for you to fill out the data. Then when you press submit, it will spit out the built signature.

Additional Context: This will be something we'll want to work with the head UX designer on, because he'll be the one making the templates most likely.

This one doesn't match the usual bug report format:

When you run lighthouse, it throws accessibility errors (indiscernible text) on the orange color for the h1 and the button for the mobile landing page. We need to fix those errors!