sheshbabu / react-frappe-charts Goto Github PK

I think typing don't support Heatmap chart.
Following frappe documentation we have to pass data using dataPoints instead of labels and values.

let data = {
    dataPoints: {
        "1426744959": 20,
        "1463673055": 113,
        "1476892421": 57,
        // ...
    },
    start: startDate, // a JS date object
    end: endDate
}

There are 2 issues for using heatmap:

1. In current types version dataset and values properties are required, but for heatmap chart they are not. Issue would be solved by making both attributes optional.
2. We get a compilation error trying to pass upper example data.

Current library declares dataPoints type as follows:

dataPoints?: {
      ["string"]: number; 
};

This compilation error will be fixed using following syntax:

dataPoints?: {
      [x: string]: number; 
};

Hi. I imported react-frappe-charts in my app created with Create React App. It works fine but when I try to run any unit tests I get an error

  ● Test suite failed to run

    /node_modules/react-frappe-charts/build/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import React from "react";
                                                                                             ^^^^^^

    SyntaxError: Cannot use import statement outside a module

I believe this is because the library is using ES6 modules in production. Would you consider transpiling the code before publishing to npm?

Meanwhile, Can anyone think of a workaround so that I can run my tests?

As a library which strongly depends on Frappe, I would suggest specifying frappe-charts as a peer dependency to let developers have finer control over its version.

I don't find export function in react-frappe-charts.

When I tried to embed the sample pie chart code provided in the project page into my React page component, the page would render for a split second, then crash with the following error stack (note that when using the other chart type like 'line', 'bar', it works fine, it only crashes when I switched to pie type), any idea what could cause this error?

Uncaught TypeError: Cannot read property 'replaceChild' of null

Frappe charts supports disabling the chart animation via the animate option.

Can we get support for this as a parameter?

frappe/charts#241

Steps to reproduce

• Give a long name to an X axis label

I can see that the y-axis changes depending on the values inserted. If the values started with 10, then, the y-axis starts in 10 and not for example in 0.

Would it be possible to add an option to always use a min and a max that would be on display?

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Please fix this issue!, or help me fix it!

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. Related #20

diff --git a/node_modules/react-frappe-charts/build/index.js b/node_modules/react-frappe-charts/build/index.js
index 6b82382..0df800e 100644
--- a/node_modules/react-frappe-charts/build/index.js
+++ b/node_modules/react-frappe-charts/build/index.js
@@ -20,6 +20,7 @@ const ReactFrappeChart = forwardRef((props, parentRef) => {
                 onDataSelect(e);
             });
         }
+        return () => chart.current.destroy();
     }, []);
     React.useEffect(() => {
         if (initialRender.current) {