test failure results in orphaned chrome.exe processes about mocha-chrome HOT 7 CLOSED

It does account for that by emitting another event called exit after the process actually exits here. You should wait for that event before exiting your grunt task.

from mocha-chrome.

Hm, I don't have that issue on my end. If you can create a failing test case and a fix, please submit a PR for both.

from mocha-chrome.

i just based my code off the test code here: https://github.com/shellscape/mocha-chrome/blob/master/test/api.js. is there another, more complete sample i can use that works correctly in this case?

from mocha-chrome.

also, if the close() promise isn't ever getting resolved, when does the this.instance.kill(); line run?

maybe i'm missing something, but i don't see how this can ever work in the test failure case.

from mocha-chrome.

that should also wait for exit. It's just a race condition if you're listening on just ended. Mocha doesn't exit anymore explicity, so without --exit it should actually eventually wait for all the chrome processes to exit. I bet there are multiple at a time, and maybe the CI test run does have a process hanging around.

from mocha-chrome.

It does account for that by emitting another event called exit after the process actually exits here

i think you're missing my point: that code never gets called.

the first await (L158) results in a Promise being returned from that function, but (in the test failure case) that Promise is promptly dropped on the floor (by Nanobus). it is never resolved and neither L159 nor L161 are executed. there's no race condition. the exit bus event is never fired.

from mocha-chrome.

@Spongman a better way to handle your frustration (that's what I'm sensing) would have been to create a failing test case and submit a fix for it. of course, there are always alternatives you can also use, including mocha-headless-chrome which works in a similar manner. this is a community-run, open-source project that people donate their time to when they can. it's free, and we're not always going to be able to predict, nor understand what someone else is reporting, so community contributions are key to improving the project. please bear that in mind in the future for any project you use.

from mocha-chrome.