Incorrect `mocha.run()` called with no tests about mocha-chrome HOT 11 CLOSED

Got a repo or gist that reproduces?

from mocha-chrome.

Not right now. I can look into that. It's a bit cumbersome since it's requirejs. Anyway I think the above doesn't make sense in that case since it's async. I'm calling mocha.delay() that adds a global run function that I later can call when all test files are required

from mocha-chrome.

Depends on the version of Require.js being used, but we add the following to our test runner template:

  <script>
  require([], function () {
    mocha.run();
  });
  </script>

That queues mocha.run until Require is done doing it's thing, all modules are defined, and all requires are ready. mocha.delay is another option.

from mocha-chrome.

I just tried a minimal sample with a gist

00:28 $ npx mocha-chrome https://rawgit.com/stoffeastrom/ecee627fdfd06bf9f29eabf7bb76873e/raw/c25c501676bbeb8a0c982340ab92807be0549264/index.html
function


  Test
    ✓ should work


  1 passing (19ms)

and it worked. I suspect it might have to do with the mocha.delay but needs more investigation. Anyway, a cool way to run a gist :)

from mocha-chrome.

So heres the repro

mocha-chrome https://rawgit.com/stoffeastrom/ecee627fdfd06bf9f29eabf7bb76873e/raw/84ca1c2c98a0fd870a7a9464be505916bcaba6f3/index.html

yields

Mocha-Chrome Failed: mocha.run() was called with no tests

If you get load timeout just run it again

from mocha-chrome.

I ran this locally and this seems to fix it for me

from mocha-chrome.

@stoffeastrom I'm having a really hard time following you. It's a best practice when reporting and discussing an issue to be clear and linear in your thoughts, as issue discussions are linear like a discussion forum. It's also a good practice not to post multiple successive posts, but rather edit your last post if there are no replies.

Your "repo" isn't a test repo; it's not even a suite of tests. It's an html file with no tests and just a mocha.delay call. So your issue seems to be claiming now that mocha saying there aren't any tests is incorrect, even though your test file contains no tests.

At this point I honestly have no idea what you're trying to report.

from mocha-chrome.

@shellscape Sorry for the confusion! As i linked before. This gist indeed has a test file. Just clone it and you will see. Problem occurs when using mocha.delay. When the browser shim is emitting started there isn't any tests loaded yet and mocha-chrome errors out. If I change it to instead emit on runner start it works.

from mocha-chrome.

Did you try what I posted in #13 (comment) ? And if so, did it work?

from mocha-chrome.

Yes I tried only using the mocha.run and that works.

from mocha-chrome.

OK so that's the route you'll want to go for testing with RequireJS.

Using the m.runner start event presents other concurrency issues that are problematic, which is why we didn't use that originally. That's based off of the same procedure that mocha-phantomjs-core uses, and that project dealt with the same concurrency issues in the past.

I'll also add a test using RequireJS to the test suite as a proof-of-concept for others on RequireJS moving forward.

from mocha-chrome.