Item notes about shelf.nu HOT 10 CLOSED

@jurrejansen would be nice to add some default styling for tables as they look like this atm:

My suggestions:

• Add borders(maybe some light gray)
• Add some more spacing to the cells?
• Add a background color to the head row
• Add alternating bg colors of the table body rows

Could you do a quick design so I can implement it? Thanks.

from shelf.nu.

@carlosvirreira @jurrejansen this needs review.

from shelf.nu.

Hi @DonKoko

Seems to be working nicely for the most part. What I noticed:

• Can we underline links and change font color to primary orange on hover?
• Looks like clicking on links currently causes Application error

Currently there's no styling for Block Quote and Code Block markdown syntaxes. But I don't think it's really necessary at the moment. Let me know if I should provide design or we skip.

• Maybe we can give the headings and paragraphs default top and bottom margins, or at least the headings. This way when a user uses this it looks better

Something like this maybe

Paragraphs (margin-bottom: 16px;)
Heading 1 (margin-bottom: 16px;)
Heading 2 (margin-bottom: 16px;) (margin-top: 24px;)
Heading 3 (margin-bottom: 16px;) (margin-top: 24px;)

from shelf.nu.

@jurrejansen man, amazing testing. I will check everything.

from shelf.nu.

This guy @jurrejansen is the master tester

from shelf.nu.

Seems to be working nicely for the most part. What I noticed:

Can we underline links and change font color to primary orange on hover?
Looks like clicking on links currently causes Application error

Done

Currently there's no styling for Block Quote and Code Block markdown syntaxes. But I don't think it's really necessary at the moment. Let me know if I should provide design or we skip.

Maybe we can give the headings and paragraphs default top and bottom margins, or at least the headings. This way when a user uses this it looks better

Both are done. I did it a bit different with the spacings but it works better now.

from shelf.nu.

@DonKoko noice one, a couple of other things I notice

• Clicking a link still ends with application error

• By adding the spacing we introduced whitespace that makes the text content in the note container to not be in the center. Not a big deal and kinda nitpicky but maybe there's an easy way to disable the spacing when it's the last line of a note post.

Not sure what was decided on images in notes for MVP but this is what I found

• Dragging in an image currently only places the 'path' to an image and does not apply the proper syntax for adding an image

• When adding an image with the proper markdown syntax the image does not show

from shelf.nu.

Clicking a link still ends with application error

Link was not formatted properly. Still it should give a 404 not application error. This will be handled in #37

Dragging in an image currently only places the 'path' to an image and does not apply the proper syntax for adding an image

Not doing this in MVP

When adding an image with the proper markdown syntax the image does not show

Should be like this:
![Image alt text](http://streamertactics.com/wp-content/uploads/2022/07/widepeepophappy-emote-300x200.png)

from shelf.nu.

@DonKoko made a design based on the item index table, but a bit compacter. It's on the "View Item" page in Figma

from shelf.nu.

Deployed the table. CLosing this issue for now.

from shelf.nu.