sheepandshepherd / cdt-gd Goto Github PK

The current API has redundancy in get_vertex/get_all_vertices and get_triangle/get_all_triangles. Godot's limited type system can't have the arrays of Vertex/Triangle structs CDT outputs, so some kind of conversion is necessary, but it should be cleaner than this and still mirror the original CDT output.

My main issue with outputting PoolArrays was that converting from std::vector is expensive, but this could be solved by saving them in ConstrainedTriangulation, instead of saving the CDT::Triangulation.

// new ConstrainedTriangulation properties:
PoolVector2Array vertices;
Array vertex_triangles; // the ugly one: jagged array of PoolIntArrays
PoolIntArray triangles; // 3 vertex indices each
PoolIntArray triangle_neighbors; // 3 triangle indices each

// possibly useful additions (not all in CDT output, but would be expensive to calculate in GDScript):
PoolIntArray edges; // 2 vertex indices each
PoolIntArray constrained_edges; // indices into `edges` or also 2 vertex indices?
Array vertex_neighbors;

CDT seems to require inputting all vertices before any edges are added. Since this adds both, it messes up the triangulation by removing existing constraints.

One solution would be to put edges in a queue that's only inserted once at the end, when the user manually calls a triangulate function.