shariajoe / osmdroid Goto Github PK

Zoom in to an area that is not cached, using Android 2.1 (HTC Legend).
There's a smooth zoom to the new level first but then the screen is grey
until replaced with the new tiles. I think this worked better on my G1,
i.e. the scaled tiles were replaced by the new tiles, without any grey
"tiles" in between.

The new GPX capture tool does not yet upload the traces to the OSM website.

When OpenStreetMapTileFilesystemProvider finds that a file exists, it could 
also check the timestamp, and if it's older than a certain amount of time 
then request a download.

It will continue using the existing one until the download completes.

If the download request gets dropped off the end of the queue then it won't 
get downloaded, but that's okay.

30 days seems like a nice expiry time.

Minimap doen't work in all Samples (shows only "loading")

when zoom or pan, minimap changes but keeps on showing loading the whole
time. Loading of normal maptiles works proper.

interaction with minimap works proper

DDMS log view doesn't show any error

If there's an error downloading a map tile then it should be a bit cleverer 
about retrying.  In some cases the error may go away when retrying, and in 
others it may be permanent. In the case of permanent errors there's not much 
point immediately and repeatedly requesting the same tile again. However 
since it's difficult to know whether the error is permanent we shouldn't stop 
attempting altogether.

See also issue 7 and issue 28.

The database is supposed to keep a track of the tiles that are on the file 
system, and delete old 
ones when the cache exceeds a certain size.

This isn't fully implemented because 
OpenStreetMapTileProviderDataBase.deleteOldest is commented 
out.

But it is never going to work properly because you can never be sure that the 
database corresponds 
to the reality of the file system, especially if you use an external tool to 
download tiles, such 
as OSMMapTilePackager.

The database adds quite an overhead to the CPU usage.

So it would be better to just get rid of the database altogether.

I think I found a copy-paste error in the OpenStreetMapView:

public double getLatitudeSpan() {
  return this.getDrawnBoundingBoxE6().getLongitudeSpanE6() / 1E6;
}
public int getLatitudeSpanE6() {
  return this.getDrawnBoundingBoxE6().getLatitudeSpanE6();
}
public double getLongitudeSpan() {
  return this.getDrawnBoundingBoxE6().getLatitudeSpanE6() / 1E6;
}
public int getLongitudeSpanE6() {
  return this.getDrawnBoundingBoxE6().getLatitudeSpanE6();
}

Workaround: Get the Span directly from the BoundinBoxE6

Kind regards
Maxim

Enable network location updates and use the network location if there's no
gps location.

What steps will reproduce the problem?
1. Calling the method with a valid ArrayList of GeoPoints

What is the expected output? What do you see instead?
Expected output is a BoundingBoxE6 instance with LatNorth, LatSouth,
LatEast and LatWest attributes correctly set.
Instead: LatNorth and LatSouth values are swapped.
This is due to incorrect order of minLat and maxLat parameters passed to
the BoundingBoxE6 constructor - appears to be swapped

What version of the product are you using? On what operating system?
Latest from trunk, as of time of issue submission

Please provide any additional information below.

There is an error in the transformation of a list of Geopoints to a Path in 
OpenStreetMapView.java. Basically it will always draw a line from the point 
of origin (0,0) to the first point because the first point is not entered 
correctly. Fixing it is trivial and involves only moving the increment 
operation further down the loop so that the first point will be entered 
with moveTo rather than drawLine. Patch is attached.

HTH

Ludwig

is it possible to redraw the person icon (in  
OpenStreetMapViewSimpleLocationOverlay)  when I 
change the location without reloading the map?

Thanks

Add a menu option to invoke the samples menu. Otherwise the only way to view 
the samples is by the launch command from Eclipse.

Could use a black&white version of the marker icon, unless someone has a 
better idea ;-)

After a while playing really nice, there are stakkatos of out of memory
errors and the map (currently the Bicycle Map) does not update any more.

A few seconds later the app crashes, f.e. if turning from portrait into
landscape mode.

This renders the whole app unusable. Tested both on an emulator and Nexus
One, bot SDK 7

With a little hint where I could try to fix it myself...


Logcat Output.

04-05 11:35:23.686: DEBUG/OSM_FS_PROVIDER(1333): Loaded tile: 2/11/1008/679
04-05 11:35:23.686: ERROR/dalvikvm-heap(1491): 262144-byte external
allocation too large for this process.
04-05 11:35:23.686: ERROR/(1491): VM won't let us allocate 262144 bytes
04-05 11:35:23.686: DEBUG/skia(1491): --- decoder->decode returned false
04-05 11:35:23.686: ERROR/OPENSTREETMAP(1491): OutOfMemoryError putting
tile in cache: 2/11/1008/679
04-05 11:35:23.686: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1008/679
04-05 11:35:23.696: DEBUG/OSM_FS_PROVIDER(1333): Next tile: 2/11/1008/680
04-05 11:35:24.846: DEBUG/OSM_FS_PROVIDER(1333): Loaded tile: 2/11/1007/680
04-05 11:35:24.856: ERROR/dalvikvm-heap(1491): 262144-byte external
allocation too large for this process.
04-05 11:35:24.856: ERROR/(1491): VM won't let us allocate 262144 bytes
04-05 11:35:24.856: DEBUG/skia(1491): --- decoder->decode returned false
04-05 11:35:24.856: ERROR/OPENSTREETMAP(1491): OutOfMemoryError putting
tile in cache: 2/11/1007/680
04-05 11:35:24.856: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1007/680
04-05 11:35:24.856: DEBUG/OSM_FS_PROVIDER(1333): Next tile: 2/11/1009/680
04-05 11:35:26.006: DEBUG/OSM_FS_PROVIDER(1333): Loaded tile: 2/11/1008/680
04-05 11:35:26.006: ERROR/dalvikvm-heap(1491): 262144-byte external
allocation too large for this process.
04-05 11:35:26.006: ERROR/(1491): VM won't let us allocate 262144 bytes
04-05 11:35:26.006: DEBUG/skia(1491): --- decoder->decode returned false
04-05 11:35:26.006: ERROR/OPENSTREETMAP(1491): OutOfMemoryError putting
tile in cache: 2/11/1008/680
04-05 11:35:26.006: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1008/680
04-05 11:35:26.006: DEBUG/OSM_FS_PROVIDER(1333): Next tile: 2/11/1008/681
04-05 11:35:27.166: DEBUG/OSM_FS_PROVIDER(1333): Loaded tile: 2/11/1009/680
04-05 11:35:27.166: ERROR/dalvikvm-heap(1491): 262144-byte external
allocation too large for this process.
04-05 11:35:27.166: ERROR/(1491): VM won't let us allocate 262144 bytes
04-05 11:35:27.166: DEBUG/skia(1491): --- decoder->decode returned false
04-05 11:35:27.166: ERROR/OPENSTREETMAP(1491): OutOfMemoryError putting
tile in cache: 2/11/1009/680
04-05 11:35:27.166: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1009/680
04-05 11:35:27.166: DEBUG/OSM_FS_PROVIDER(1333): Next tile: 2/11/1009/681
04-05 11:35:28.666: DEBUG/OSM_FS_PROVIDER(1333): Loaded tile: 2/11/1008/681
04-05 11:35:28.676: ERROR/dalvikvm-heap(1491): 262144-byte external
allocation too large for this process.
04-05 11:35:28.676: ERROR/(1491): VM won't let us allocate 262144 bytes
04-05 11:35:28.676: DEBUG/skia(1491): --- decoder->decode returned false
04-05 11:35:28.686: ERROR/OPENSTREETMAP(1491): OutOfMemoryError putting
tile in cache: 2/11/1008/681
04-05 11:35:28.686: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1008/681
04-05 11:35:28.686: DEBUG/OSM_FS_PROVIDER(1333): No more tiles
04-05 11:35:29.796: DEBUG/OSM_FS_PROVIDER(1333): Loaded tile: 2/11/1009/681
04-05 11:35:29.806: ERROR/dalvikvm-heap(1491): 262144-byte external
allocation too large for this process.
04-05 11:35:29.806: ERROR/(1491): VM won't let us allocate 262144 bytes
04-05 11:35:29.806: DEBUG/skia(1491): --- decoder->decode returned false
04-05 11:35:29.806: ERROR/OPENSTREETMAP(1491): OutOfMemoryError putting
tile in cache: 2/11/1009/681
04-05 11:35:29.806: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1009/681
04-05 11:35:29.806: DEBUG/OSM_FS_PROVIDER(1333): No more tiles
04-05 11:35:33.686: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:36:37.846: DEBUG/OSM_FS_PROVIDER(1333): FSCache Size is now:
121036030 Bytes
04-05 11:36:37.846: DEBUG/OSM_FS_PROVIDER(1333): Freeing FS cache...
04-05 11:36:37.846: DEBUG/OSM_DOWNLOADER(1333): Maptile saved 97574 bytes :
2/11/1009/677
04-05 11:36:37.846: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1009/677
04-05 11:36:37.846: DEBUG/OSM_DOWNLOADER(1333): No more tiles
04-05 11:36:41.256: DEBUG/dalvikvm(1333): GC freed 2534 objects / 413112
bytes in 187ms
04-05 11:36:41.686: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049318]
04-05 11:36:41.896: DEBUG/dalvikvm(1333): GC freed 102 objects / 184984
bytes in 157ms
04-05 11:36:42.836: DEBUG/OSM_FS_PROVIDER(1333): Tile existed
04-05 11:36:42.836: DEBUG/OSM_FS_PROVIDER(1333): FSCache Size is now:
121036030 Bytes
04-05 11:36:42.836: DEBUG/OSM_FS_PROVIDER(1333): Freeing FS cache...
04-05 11:36:42.836: DEBUG/OSM_DOWNLOADER(1333): Maptile saved 97574 bytes :
2/11/1009/677
04-05 11:36:42.836: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1009/677
04-05 11:36:42.836: DEBUG/OSM_DOWNLOADER(1333): No more tiles
04-05 11:36:44.006: DEBUG/OSM_FS_PROVIDER(1333): Tile existed
04-05 11:36:44.006: DEBUG/OSM_FS_PROVIDER(1333): FSCache Size is now:
121036030 Bytes
04-05 11:36:44.006: DEBUG/OSM_FS_PROVIDER(1333): Freeing FS cache...
04-05 11:36:44.026: DEBUG/OSM_DOWNLOADER(1333): Maptile saved 97574 bytes :
2/11/1009/677
04-05 11:36:44.036: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1009/677
04-05 11:36:44.036: DEBUG/OSM_DOWNLOADER(1333): No more tiles
04-05 11:36:44.436: DEBUG/OSM_FS_PROVIDER(1333): Tile existed
04-05 11:36:44.446: DEBUG/OSM_FS_PROVIDER(1333): FSCache Size is now:
121036030 Bytes
04-05 11:36:44.446: DEBUG/OSM_FS_PROVIDER(1333): Freeing FS cache...
04-05 11:36:44.446: DEBUG/OSM_DOWNLOADER(1333): Maptile saved 97574 bytes :
2/11/1009/677
04-05 11:36:44.446: DEBUG/OPENSTREETMAP(1491): MapTile request complete:
2/11/1009/677
04-05 11:36:44.446: DEBUG/OSM_DOWNLOADER(1333): No more tiles
04-05 11:36:46.646: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7048653]
04-05 11:36:53.296: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:37:11.106: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7048653]
04-05 11:37:20.186: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:37:32.786: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7048653]
04-05 11:37:59.866: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:39:25.506: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7048653]
04-05 11:39:32.156: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:40:03.516: DEBUG/WifiService(78): acquireWifiLockLocked:
WifiLock{NetworkLocationProvider type=2 binder=android.os.Binder@44c12260}
04-05 11:40:03.516: DEBUG/NetworkLocationProvider(78): getLocation():
triggering a wifi scan
04-05 11:40:03.546: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:40:06.326: INFO/wpa_supplicant(121): CTRL-EVENT-SCAN-RESULTS  Ready
04-05 11:40:06.336: DEBUG/NetworkLocationProvider(78):
updateWifIScanResults(): 3 APs
04-05 11:40:06.376: DEBUG/LocationMasfClient(78): getNetworkLocation():
Returning cache location with accuracy 75.0
04-05 11:40:06.376: VERBOSE/tml.GeoLocationService(429): moved less than
MIN_DISTANCE and uploadPeriod not expired
04-05 11:40:08.516: DEBUG/WifiService(78): releaseWifiLockLocked:
WifiLock{NetworkLocationProvider type=2 binder=android.os.Binder@44c12260}
04-05 11:42:46.116: WARN/ActivityManager(78): Unable to start service
Intent { cmp=com.aws.android/.widget.radar.RadarWidget$RadarWidgetService
}: not found
04-05 11:42:46.716: DEBUG/dalvikvm(398): GC freed 6031 objects / 492640
bytes in 189ms
04-05 11:42:46.906: DEBUG/dalvikvm(398): GC freed 82 objects / 3384 bytes
in 182ms
04-05 11:42:47.096: INFO/global(398): Default buffer size used in
BufferedReader constructor. It would be better to be explicit if an 8k-char
buffer is required.
04-05 11:42:47.106: INFO/global(398): Default buffer size used in
BufferedReader constructor. It would be better to be explicit if an 8k-char
buffer is required.
04-05 11:42:47.136: INFO/global(398): Default buffer size used in
BufferedReader constructor. It would be better to be explicit if an 8k-char
buffer is required.
04-05 11:42:50.266: DEBUG/dalvikvm(429): GC freed 6205 objects / 500032
bytes in 145ms
04-05 11:42:50.296: DEBUG/NetworkLocationProvider(78): setMinTime: 0
04-05 11:42:50.296: DEBUG/WifiService(78): acquireWifiLockLocked:
WifiLock{NetworkLocationProvider type=2 binder=android.os.Binder@44c12260}
04-05 11:42:50.296: DEBUG/NetworkLocationProvider(78): getLocation():
triggering a wifi scan
04-05 11:42:50.336: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:42:53.126: INFO/wpa_supplicant(121): CTRL-EVENT-SCAN-RESULTS  Ready
04-05 11:42:53.136: DEBUG/NetworkLocationProvider(78):
updateWifIScanResults(): 4 APs
04-05 11:42:53.186: DEBUG/LocationMasfClient(78): getNetworkLocation():
Returning cache location with accuracy 75.0
04-05 11:42:53.196: VERBOSE/tml.GeoLocationService(429): Storing current
location
04-05 11:42:53.366: DEBUG/NetworkLocationProvider(78): setMinTime: 300000
04-05 11:42:53.406: VERBOSE/TracksProvider(429): notifyChange:
content://sgwdl.provider.GPSTracking/track
04-05 11:42:53.486: VERBOSE/TrackUploadThread(429): run
04-05 11:42:53.736: VERBOSE/TrackUploadThread(429): uploaded records: 1
04-05 11:42:55.296: DEBUG/WifiService(78): releaseWifiLockLocked:
WifiLock{NetworkLocationProvider type=2 binder=android.os.Binder@44c12260}
04-05 11:43:05.186: DEBUG/dalvikvm(398): GC freed 2520 objects / 785064
bytes in 159ms
04-05 11:43:12.066: VERBOSE/BackupManagerService(78): clearing pending backups
04-05 11:43:12.126: DEBUG/PerformBackupThread(78): starting agent for
backup of BackupRequest{app=ApplicationInfo{44a09168
com.android.providers.settings} full=false}
04-05 11:43:12.146: DEBUG/BackupManagerService(78): awaiting agent for
ApplicationInfo{44a09168 com.android.providers.settings}
04-05 11:43:12.146: DEBUG/BackupManagerService(78): agentConnected
pkg=com.android.providers.settings
agent=android.app.BackupAgent$BackupServiceBinder@44baaae0
04-05 11:43:12.306: INFO/global(78): Default buffer size used in
BufferedReader constructor. It would be better to be explicit if an 8k-char
buffer is required.
04-05 11:45:05.906: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7048653]
04-05 11:45:09.996: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:45:50.806: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7048653]
04-05 11:46:15.226: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:47:50.316: DEBUG/WifiService(78): acquireWifiLockLocked:
WifiLock{NetworkLocationProvider type=2 binder=android.os.Binder@44c12260}
04-05 11:47:50.316: DEBUG/NetworkLocationProvider(78): getLocation():
triggering a wifi scan
04-05 11:47:50.346: DEBUG/NetworkLocationProvider(78):
onCellLocationChanged [21,7049314]
04-05 11:47:53.166: INFO/wpa_supplicant(121): CTRL-EVENT-SCAN-RESULTS  Ready
04-05 11:47:53.166: DEBUG/NetworkLocationProvider(78):
updateWifIScanResults(): 3 APs
04-05 11:47:53.206: DEBUG/LocationMasfClient(78): getNetworkLocation():
Returning cache location with accuracy 75.0
04-05 11:47:53.206: VERBOSE/tml.GeoLocationService(429): moved less than
MIN_DISTANCE and uploadPeriod not expired
04-05 11:47:55.326: DEBUG/WifiService(78): releaseWifiLockLocked:
WifiLock{NetworkLocationProvider type=2 binder=android.os.Binder@44c12260}

Current map tiles are quite large, 256x256 I guess.
Let's make them smaller - 128x128.

That would have two benefits:
- faster responses when loading new regions.
- smaller lag on loading the image in memory. 256x256 image loading
produces noticable UI lag.

It'd be nice if osmdroid didn't use the internal memory by default for
storing cache images, there is a lack of space to begin with and the SD
card is usually 1G compared to the paltry 64M of internal memory.

People already run out of space on the internal memory just by installing
apps, which is why Apps2SD is popular.

Also wouldn't it be advantageous for all osmdroid clients, including
AndNav2, to share the same cache location/database on the sdcard, that way
they all get the benefit of previously downloaded tiles without needing to
reload them.

What steps will reproduce the problem?
View the map in bicycle mode 

01-24 15:44:03.063: ERROR/Database(1602): Error updating
timestamp=2010-01-24T15:44:01.877 countused=countused + 1 using UPDATE
t_fscache SET timestamp=?, countused=? WHERE rendererID=? AND zoomLevel=?
AND tileX=? AND tileY=?
01-24 15:44:03.094: WARN/dalvikvm(1602): threadid=97: thread exiting with
uncaught exception (group=0x4001b170)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602): Uncaught handler: thread
pool-10-thread-4 exiting due to uncaught exception
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):
android.database.sqlite.SQLiteException: error code 5: database is locked
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
android.database.sqlite.SQLiteStatement.native_execute(Native Method)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
android.database.sqlite.SQLiteStatement.execute(SQLiteStatement.java:66)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
android.database.sqlite.SQLiteDatabase.updateWithOnConflict(SQLiteDatabase.java:
1576)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
android.database.sqlite.SQLiteDatabase.update(SQLiteDatabase.java:1499)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
org.andnav.osm.services.util.OpenStreetMapTileProviderDataBase.incrementUse(Open
StreetMapTileProviderDataBase.java:110)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
org.andnav.osm.services.util.OpenStreetMapTileProviderDataBase.addTileOrIncremen
t(OpenStreetMapTileProviderDataBase.java:114)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
org.andnav.osm.services.util.OpenStreetMapTileFilesystemProvider.saveFile(OpenSt
reetMapTileFilesystemProvider.java:89)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
org.andnav.osm.services.util.OpenStreetMapTileDownloader$TileLoader.run(OpenStre
etMapTileDownloader.java:104)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
01-24 15:44:03.094: ERROR/AndroidRuntime(1602):     at
java.lang.Thread.run(Thread.java:1096)
01-24 15:44:03.102: INFO/Process(1170): Sending signal. PID: 1602 SIG: 3
01-24 15:44:03.102: WARN/ActivityManager(1170): Process org.andnav.osm has
crashed too many times: killing!

(on Milestone)

Just to provide a view of outstanding tasks

What steps will reproduce the problem?
1. Start OSMapView with ItemizedOverlay or OSMapView with 
ItemizedOverlayWithFocus
2. Tap on item
3. Toast does not appear.

What is the expected output? What do you see instead?
Expected output: Toast message about item.
Current state: Nothing happens

What version of the product are you using? On what operating system?
r119 (March 19 2010)

Please provide any additional information below.

OpenStreetMapViewItemizedOverlay.java contains error in onSingleTapUp. Take 
a look at: pj.toMapPixels(mItem.mGeoPoint, mCurScreenCoords).

    @Override
    public boolean onSingleTapUp(final MotionEvent event, final 
OpenStreetMapView mapView) {
        final OpenStreetMapViewProjection pj = 
mapView.getProjection();
        final int eventX = (int)event.getX();
        final int eventY = (int)event.getY();

        final int markerWidth = this.mMarker.getIntrinsicWidth();
        final int markerHeight = this.mMarker.getIntrinsicHeight();

        final Rect curMarkerBounds = new Rect();
        final Point mCurScreenCoords = new Point();

        for(int i = 0; i < this.mItemList.size(); i++){
            final T mItem = this.mItemList.get(i);
            pj.toMapPixels(mItem.mGeoPoint, mCurScreenCoords); 
// <<<< Error: Coordinates relative to map center in pixel get returned 
(very high values) 

            final int left = mCurScreenCoords.x - 
this.mMarkerHotSpot.x;
            final int right = left + markerWidth;
            final int top = mCurScreenCoords.y - 
this.mMarkerHotSpot.y;
            final int bottom = top + markerHeight;

            curMarkerBounds.set(left, top, right, bottom);
            if(curMarkerBounds.contains(eventX, eventY)) // 
<<<< Error: Cannot compare physical screen coordinates with relative map 
coordinates
                if(onTap(i))
                    return true;
        }
        return super.onSingleTapUp(event, mapView);
    }

When using an OpenStreetMapView in an application, an image is displayed
during the download of the new tiles.
Osm uses R.drawable.maptile_loading, which id is 0x7f020003 in the original
project.

The problem is that the view loads the image with the same ID from the
current apk!

- the user (programmer) has no way to specify another resource as the
"loading" background. Or has he?
- To choose a particular image, he has to get it to be the fourth file in
his drawable folder.

What steps will reproduce the problem?
1. Select the Cloudmade (small tiles) map mode
2.
3.

What is the expected output? What do you see instead?
Once the tiles are loaded they should continue to be displayed.
Instead a few tiles flash on and off.

This is because the number of tiles needed is more than the cache size.

This is the code of org.andnav.osm.views.util.Mercator

    public static double tile2lon(final int x, final int aZoom) {
        return x / (1 << aZoom) * 360.0 - 180;
    }

x should be cast to a double, ie

        return (double)x / (1 << aZoom) * 360.0 - 180;

otherwise it always returns -180 because a relatively small number divided
by a much bigger number is always zero when rounded to an int.

When the map view is paused and then resumed, it stops following my location.

When i press an icon in ItemizedOverlayWithFocus, it should show the 
description immediately. 
However, it doesn't until i do zoom in/out into the map. 

So.. is it possible to redraw the icon when it's pressed?

All the samples use a minimap that uses the Cloudmade render.
The Cloudmade renderer doesn't work - see issue 28.
The samples should use the default renderer for the minimap (or the same 
renderer as the main map).

An an option that allows to download the currently visible area at certain
zoom levels.

I'm having the same issue with andnav2 and using osmdroid code in my own
app, tiles fail to load, or re-load from OSM servers.

The other side effect is the code seems to get into an endless loop trying
to load the tiles from the FS into memcache. Enabling debug mode spits out
the following output. Even with nothing changing on screen or no user input
the system will keep trying to load/display tiles but always fails and I've
no idea why.

I/OPENSTREETMAP( 2780): MapTileCache succeded for:
http://tile.openstreetmap.org/6/40/39.png
I/OPENSTREETMAP( 2780): Cache failed, trying from FS.
I/OPENSTREETMAP( 2780): MapTileCache succeded for:
http://tile.openstreetmap.org/6/40/40.png
D/OPENSTREETMAP( 2780): Loaded: http://tile.openstreetmap.org/6/41/39.png
to MemCache.
I/OPENSTREETMAP( 2780): Cache failed, trying from FS.
D/OPENSTREETMAP( 2780): Loaded: http://tile.openstreetmap.org/6/41/40.png
to MemCache.
I/OPENSTREETMAP( 2780): MapTileCache succeded for:
http://tile.openstreetmap.org/6/40/41.png
I/OPENSTREETMAP( 2780): MapTileCache succeded for:
http://tile.openstreetmap.org/6/41/41.png
I/OPENSTREETMAP( 2780): Rendering overall: 64ms
I/OPENSTREETMAP( 2780): MapTile fs->cache success.
I/OPENSTREETMAP( 2780): MapTile fs->cache success.
I/OPENSTREETMAP( 2780): MapTileCache succeded for:
http://tile.openstreetmap.org/6/40/39.png
I/OPENSTREETMAP( 2780): Cache failed, trying from FS.
D/OPENSTREETMAP( 2780): Loaded: http://tile.openstreetmap.org/6/41/39.png
to MemCache.
I/OPENSTREETMAP( 2780): MapTileCache succeded for:
http://tile.openstreetmap.org/6/40/40.png
I/OPENSTREETMAP( 2780): Cache failed, trying from FS.

A double tap should zoom into the place where the double tap occurs. This
is useful because the "+" button will always only zoom into the center of
the map.

The "about" dialog should probably contain the following information:

-License of the data used (CC-BY-SA 2.0)
-License of the software
-version number (and maybe date)
-URL of osmdroid homepage (i.e. http://code.google.com/p/osmdroid)

What steps will reproduce the problem?
1. Use one of the samples with a minimap, eg SampleWithMinimapItemizedoverlay
2. Drag the main map
3. Drag the minimap

What is the expected output? What do you see instead?
When you drag the main map, the minimap should move, and vice versa

It is difficult to add support for other tiling engines as the
OpenStreetMapRendererInfo is an enum could it be an interface perhaps?

Here is how to add support for Bing Maps by hacking the
OpenStreetMapRendererInfo directly

package org.andnav.osm.views.util;

import org.andnav.osm.views.util.constants.OpenStreetMapViewConstants;

/**
 *
 * @author Nicolas Gramlich
 *
 */
public enum OpenStreetMapRendererInfo {
    OSMARENDER("http://tah.openstreetmap.org/Tiles/tile/", "OsmaRender",
            ".png", 17, 8), MAPNIK("http://tile.openstreetmap.org/", "Mapnik",
            ".png", 18, 8), CYCLEMAP(
            "http://b.andy.sandbox.cloudmade.com/tiles/cycle/", "Cycle Map",
            ".png", 17, 8), OPENARIELMAP(
            "http://tile.openaerialmap.org/tiles/1.0.0/openaerialmap-900913/",
            "OpenArialMap (Satellite)", ".jpg", 13, 8), CLOUDMADESMALLTILES(
            "http://tile.cloudmade.com/BC9A493B41014CAABB98F0471D759707/2/64/",
            "Cloudmade (Small tiles)", ".jpg", 13, 6), CLOUDMADESTANDARDTILES(

"http://tile.cloudmade.com/BC9A493B41014CAABB98F0471D759707/2/256/",
            "Cloudmade (Standard tiles)", ".jpg", 18, 8), VIRTUALEARTHROADS(
            "http://r2.ortho.tiles.virtualearth.net/tiles/r", "VE ROADS",
            ".png?g=2", 18, 8, true), VIRTUALEARTHHYBRID(
            "http://r2.ortho.tiles.virtualearth.net/tiles/h", "VE ARIAL+ROADS",
            ".png?g=2", 18, 8, true), VIRTUALEARTHARIAL(
            "http://r2.ortho.tiles.virtualearth.net/tiles/a", "VE ARIAL",
            ".png?g=2", 18, 8, true);

    // ===========================================================
    // Fields
    // ===========================================================

    public final String BASEURL, NAME, IMAGE_FILENAMEENDING;
    public final int ZOOM_MAXLEVEL, MAPTILE_ZOOM, MAPTILE_SIZEPX;
    private boolean quadKeyBased = false;

    // ===========================================================
    // Constructors
    // ===========================================================

    private OpenStreetMapRendererInfo(final String aBaseUrl,
            final String aName, final String aImageFilenameEnding,
            final int aZoomMax, final int aTileZoom) {
        this.BASEURL = aBaseUrl;
        this.NAME = aName;
        this.ZOOM_MAXLEVEL = aZoomMax;
        this.IMAGE_FILENAMEENDING = aImageFilenameEnding;
        this.MAPTILE_ZOOM = aTileZoom;
        this.MAPTILE_SIZEPX = 1 << aTileZoom;
    }

    public static OpenStreetMapRendererInfo getDefault() {
        return MAPNIK;
    }

    // ===========================================================
    // Methods
    // ===========================================================

    public String getTileURLString(final int[] tileID, final int zoomLevel) {
        if (!quadKeyBased)
            return new StringBuilder()
                    .append(this.BASEURL)
                    .append(zoomLevel)
                    .append("/")
                    .append(

tileID[OpenStreetMapViewConstants.MAPTILE_LONGITUDE_INDEX])
                    .append("/")
                    .append(

tileID[OpenStreetMapViewConstants.MAPTILE_LATITUDE_INDEX])
                    .append(this.IMAGE_FILENAMEENDING).toString();
        else
            return new StringBuilder()
                    .append(BASEURL)
                    .append(
                            quadTree(

tileID[OpenStreetMapViewConstants.MAPTILE_LONGITUDE_INDEX],

tileID[OpenStreetMapViewConstants.MAPTILE_LATITUDE_INDEX],

                                    zoomLevel)).append(IMAGE_FILENAMEENDING)
                    .toString();
    }

    private OpenStreetMapRendererInfo(final String aBaseUrl,
            final String aName, final String aImageFilenameEnding,
            final int aZoomMax, final int aTileZoom, boolean qkeyBased) {
        this.BASEURL = aBaseUrl;
        this.NAME = aName;
        this.ZOOM_MAXLEVEL = aZoomMax;
        this.IMAGE_FILENAMEENDING = aImageFilenameEnding;
        this.MAPTILE_ZOOM = aTileZoom;
        this.MAPTILE_SIZEPX = 1 << aTileZoom;
        quadKeyBased = qkeyBased;
    }

    private String quadTree(int tx, int ty, int zoom) {
        // "Converts TMS tile coordinates to Microsoft QuadTree"
        StringBuilder quadKey = new StringBuilder();
        // ty = (((int) Math.pow(2, zoom) - 1)) - ty;
        // for (int i = 1; i < zoom; i++) {// in range(zoom, 0, -1):
        for (int i = zoom; i > 0; i--) {
            int digit = 0;
            int mask = 1 << (i - 1);
            if ((tx & mask) != 0)
                digit += 1;
            if ((ty & mask) != 0)
                digit += 2;
            quadKey.append("" + digit);
        }

        return quadKey.toString();
    }
}

What steps will reproduce the problem?
1. Zoom in
2. Loading new tiles
3. Exception Ocurred

What is the expected output? What do you see instead?

The new tiles in the new zoom view, but an exception ocurrus. In logcat i 
see this:

D/OPENSTREETMAP( 1209): MapTileCache succeeded for: 7/0/0/0
D/OPENSTREETMAP( 1209): MapTileCache succeeded for: 7/0/0/0
E/dalvikvm-heap( 1209): 262144-byte external allocation too large for this 
process.
E/        ( 1209): VM won't let us allocate 262144 bytes
D/skia    ( 1209): --- decoder->decode returned false
E/OPENSTREETMAP( 1209): OutOfMemoryError putting tile in cache: 
7/4/9/5
D/OPENSTREETMAP( 1209): MapTile request complete: 7/4/9/5
D/OSM_FS_PROVIDER( 1215): Next tile: 7/4/6/4
D/OPENSTREETMAP( 1209): MapTileCache succeeded for: 7/0/0/0
D/OPENSTREETMAP( 1209): MapTileCache succeeded for: 7/0/0/0
D/OPENSTREETMAP( 1209): Rendering overall: 66ms
V/OPENSTREETMAP( 1209): onDraw
D/OSM_FS_PROVIDER( 1215): Loaded tile: 7/4/9/3
E/dalvikvm-heap( 1209): 262144-byte external allocation too large for this 
process.
E/        ( 1209): VM won't let us allocate 262144 bytes
D/skia    ( 1209): --- decoder->decode returned false
E/OPENSTREETMAP( 1209): OutOfMemoryError putting tile in cache: 
7/4/9/3


What version of the product are you using? On what operating system?

I'm using a emulator tool with Android 2.0.1

Please provide any additional information below.

Hi, I've had some time to burn, so I did some refactoring to the tile
provider / tile caching layer. I've attached a diff against the current svn
head and a plain java test project I've used to test my classes. I hope you
can make use of it.

Non-exhaustive list of changes:
* add slf4j for logging (needed this to cut android-runtime dependencies -
please install http://www.slf4j.org/android/slf4j-android-1.5.8.jar into lib)
* tile loading is not a service anymore, runs in main process
* database dropped
* fixed OpenStreetMapTile's hashCode()/equals()
* some fixes to OpenStreetMapTilesOverlay

Some tiles (eg. water) are completely equal for different coordinates.
These should be stored only once in the cache.

Tasks:
- find tiles that are probably used more than once
- create link in tile db instead of storing a new tile

What steps will reproduce the problem?
1. Open OSM.
2. Scroll around in place where the tiles have been loaded - all nice and
smooth.
3. Scroll around in place with no tiles loaded - very laggy, up to 1 sec.
Even without debug mode on actual device.

Note that there are two things - a small freeze when a cached tile is
loaded from disk - this one is quite tolerable. But there is a general lag
when just scrolling around empty area, waiting for tiles to load.

Checking out the source I succeeded to add a useful multitouch mode on a
very rainy sunday afternoon in Berlin, Germany.

Tested on Nexus One.

Single file changed:
  OpenStreetMapViewer/src/org/andnav/osm/views/OpenStreetMapView.java

Attached.

Have fun,
Thomas

Hi,
i completed the italian translation of the app.

Hope this can be useful.

Bye,
Diego Pierotto

Hallo,
after zoom into the map (quickly) following exception killed the app:

07-14 18:13:29.101: INFO/OPENSTREETMAP(733): Rendering overall: 15ms
07-14 18:13:29.241: DEBUG/dalvikvm(733): GC freed 1931 objects / 1444312
bytes in 110ms
07-14 18:13:29.281: INFO/OPENSTREETMAP(733): Rendering overall: 4ms
07-14 18:13:29.321: ERROR/dalvikvm-heap(733): 262144-byte external
allocation too large for this process.
07-14 18:13:29.321: ERROR/(733): VM won't let us allocate 262144 bytes
07-14 18:13:29.331: WARN/dalvikvm(733): threadid=93: thread exiting with
uncaught exception (group=0x4000fe70)
07-14 18:13:29.331: ERROR/AndroidRuntime(733): Uncaught handler: thread
pool-13-thread-2 exiting due to uncaught exception
07-14 18:13:29.361: INFO/OPENSTREETMAP(733): Rendering overall: 4ms
07-14 18:13:29.381: ERROR/AndroidRuntime(733): java.lang.OutOfMemoryError:
bitmap size exceeds VM budget
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
android.graphics.BitmapFactory.nativeDecodeByteArray(Native Method)
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:308)
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
android.graphics.BitmapFactory.decodeByteArray(BitmapFactory.java:321)
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
org.andnav.osm.views.util.OpenStreetMapTileFilesystemProvider$1.run(OpenStreetMa
pTileFilesystemProvider.java:117)
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:6
48)
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:673)
07-14 18:13:29.381: ERROR/AndroidRuntime(733):     at
java.lang.Thread.run(Thread.java:1058)

What steps will reproduce the problem?
1. View map
2. Scroll wide into uncached region

What is the expected output? What do you see instead?
The viewed map region should be loaded first.
It seems that the map tiles are loaded in the order they are first viewed.
This means that te currently viewed map tile is shown last and needs the
maximum time to show up

What version of the product are you using? On what operating system?
Version 1.1 on Motorola Milestone

View map

01-24 15:47:32.789: ERROR/ActivityThread(1706): Activity
org.andnav.osm.OpenStreetMap has leaked ServiceConnection
org.andnav.osm.views.util.OpenStreetMapTileProvider@44ca7818 that was
originally bound here
01-24 15:47:32.789: ERROR/ActivityThread(1706):
android.app.ServiceConnectionLeaked: Activity org.andnav.osm.OpenStreetMap
has leaked ServiceConnection
org.andnav.osm.views.util.OpenStreetMapTileProvider@44ca7818 that was
originally bound here
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread$PackageInfo$ServiceDispatcher.<init>(ActivityThread.j
ava:935)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread$PackageInfo.getServiceDispatcher(ActivityThread.java:
830)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ApplicationContext.bindService(ApplicationContext.java:799)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.content.ContextWrapper.bindService(ContextWrapper.java:337)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
org.andnav.osm.views.util.OpenStreetMapTileProvider.<init>(OpenStreetMapTileProv
ider.java:57)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
org.andnav.osm.views.overlay.OpenStreetMapTilesOverlay.<init>(OpenStreetMapTiles
Overlay.java:35)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
org.andnav.osm.views.OpenStreetMapView.<init>(OpenStreetMapView.java:93)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
org.andnav.osm.views.OpenStreetMapView.<init>(OpenStreetMapView.java:114)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
org.andnav.osm.OpenStreetMap.onCreate(OpenStreetMap.java:60)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2417)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2470)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread.access$2200(ActivityThread.java:119)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread$H.handleMessage(ActivityThread.java:1821)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.os.Handler.dispatchMessage(Handler.java:99)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.os.Looper.loop(Looper.java:123)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
android.app.ActivityThread.main(ActivityThread.java:4310)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
java.lang.reflect.Method.invokeNative(Native Method)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
java.lang.reflect.Method.invoke(Method.java:521)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
01-24 15:47:32.789: ERROR/ActivityThread(1706):     at
dalvik.system.NativeStart.main(Native Method)
01-24 15:47:32.797: WARN/ActivityManager(1170): Unbind failed: could not
find connection for android.os.BinderProxy@44fb30b8

[deleted issue]

What steps will reproduce the problem?
1. Run one of the samples with an overlay
2. Zoom in x12 (whatever)
3. Tapping on the overlay items stops working

What is the expected output? What do you see instead?

Tabbing should work ;> the x,y screen coords are very weird x > 1000 and y
becomes negative. It confuses me even more that the overlay items are
rendered correctly even though the x,y coords are off-screen?  

I have attached a screen shot where the x&y coords are rendered.

What version of the product are you using? On what operating system?

Using the latest code from SVN


Please provide any additional information below.

Hi,

I implemented a path overlay, for drawing GPS traces.

Made some modifications in OpenStreetMapViewProjection, to get better
performance on large traces.

When you select My Location from the menu in the OpenStreetMap activity, 
there is no way to then disable it.

This is not necessarily a bug - just an oversight in the design.

OpenStreetMap is just a demo application - anyone implementing their own 
application is free to do as they like.

If you use the Cloudmade renderer it gives an error downloading the tiles, 
for example
IOException downloading MapTile: 7/0/0/0 : java.io.FileNotFoundException: 
http://tile.cloudmade.com/BC9A493B41014CAABB98F0471D759707/2/256/0/0/0.jpg

Presumably because this url contains an out-of-date API key.

It would be handy if other applications using osmdroid could just include it 
as a library instead of copying the source code.

I think this only requires that the resources are retrieved from the jar 
instead of from R.

Perhaps it means we make a new project for the jar and then change 
OpenStreetMapViewer to use the jar instead of including the code.

See also: http://code.google.com/p/osmtracker-android/issues/detail?id=19#c16

In OpenStreetMapRendererInfo.java:

CLOUDMADESMALLTILES("http://tile.cloudmade.com/BC9A493B41014CAABB98F0471D759707/
2/64/",
"Cloudmade (Small tiles)", ".jpg", 13, 6),

CLOUDMADESTANDARDTILES("http://tile.cloudmade.com/BC9A493B41014CAABB98F0471D7597
07/2/256/",
"Cloudmade (Standard tiles)", ".jpg", 18, 8);

It is not allowed to use this apikey (BC9A493B41014CAABB98F0471D759707)
outside of CloudMade website.
You should go to http://cloudmade.com and generate your own API key.

Note: if you'll chose "Mobile" API key type - you should use new
Authorization schema: http://developers.cloudmade.com/projects/show/auth
I suggest to use "Web" apikey for now.

What steps will reproduce the problem?
1. open the itemizedoverlay sample
2. click on any overlay
3.

What is the expected output? What do you see instead?
I should see the Toast, instead nothing happens

What version of the product are you using? On what operating system?
Linux - ubuntu

Please provide any additional information below.

Fix:
MyLocationOverlay.disableMyLocation() should set mMyLocationEnabled to false.

Description copied from issue 27 comment 3:

Download from several servers in parallel, generally possible for all,
implemented for the CYCLEMAP

    CYCLEMAP(R.string.cyclemap, ".png", 0, 17, 8, CodeScheme.X_Y,
            "http://a.andy.sandbox.cloudmade.com/tiles/cycle/",
            "http://b.andy.sandbox.cloudmade.com/tiles/cycle/",
            "http://c.andy.sandbox.cloudmade.com/tiles/cycle/"),

You can use the OpenStreetMapRendererInfo with several servers now, and the 
implementation picks randomly one of the servers. This seems to improve the 
download 
speed enormously. Checking the URLs in parallel with a Firefox sometimes shows 
a 404 
on some tiles, indicating a server problem which is harmless, if you can try 
lots of 
servers.

Room for improvement, choose the servers according to their response time... 

The cyclemap now feels better than the Google maps!

What steps will reproduce the problem?
1. Enable My Location
2. Drag the screen
3. The My Location icon will stay at the point where it was last

What is the expected output? What do you see instead?

Either:
1. The My Location icon should be removed.
2. The My Location icon should continue moving, but the map shouldn't 
follow it.

Probably 1 is the correct fix.

Please use labels and text to provide additional information.