Create demo starter with sharec as potential replace for create-react-app.
No with a full functionality, only working example.

The most of tests now using snapshots, it is not good – because testing with fixtures more predictable and visual.

1. I added a new dependency to my config
2. git clone https://github.com/ai/nanoid.git
3. yarn
4. yarn upgrade-interactive --latest, select @logux/sharec-config
5. eslint-plugin-unicorn was not added to devDependencies

Double quotes automatically changes to single quotes after strategy applying.

Guess, need to determine quotes style at the beginning and format file after strategy applying.

Relates to #75

In @logux/sharec-config 0.3.1 I removed eslint-plugin-import-helpers logux/sharec-config@914085b

When I update the config in Nano ID, Sharec doesn’t remove eslint-plugin-import-helpers from dependencies.

In ESLint documentation it's said that comments are allowed.

JSON - use .eslintrc.json to define the configuration structure. ESLint's JSON files also allow JavaScript-style comments.

However sharec fails to apply them

sharec: × Configuration was not fully applyed due unexpected error
SyntaxError: Unexpected token / in JSON at position 868

It should force rewrite all configuration. More info here #58.

I have share config with:

configs/
  .travis.yml
  .npmignore

configs/.npmignore contains .travis.yml. As a result, I can’t put .travis.yml to sharec config package.

Let’s add alias for .npmignore (for instance npmignore) and sharec will rename config during postinstall.

Looks like your PR #146 broken some of your links that were using relative paths.

<!-- https://sharec.js.org -->
<p>If you want read more detailed manual – look at 
<a href="packages/sharec-demo-config">official demo config</a>
and check <a href="packages/sharec">sharec</a> 
package if you looking for API reference.</p>

Add prompt mode for allowing partial configuration applying.
Should works with --prompt option.

This is a very big and important feature. We should allow users to add codemods for their files in sharec configuration packages.
May be, it should looks like inject in hygen. I don't know at this moment, how to do it better, but I guess - this is a really useful stuff.

And do not supported by github

name: Node Library Config (Branch CI)

on:
  pull_request:
  push:
    branches:
      - main
      - master
      - develop

jobs:
  build:
    name: Build Project
    runs-on: ubuntu-20.04
    strategy:
      matrix:
        node-version: [12.x]
    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v1
        with:
          node-version: ${{ matrix.node-version }}

      - run: rm -rf .npmrc
      - run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc
      - run: npm install
      - run: npm run test
      - run: npm run build
      - run: npm publish

name: Node Library Config (Branch CI)
"on":
	pull_request: null
	push:
		branches:
			- main
			- master
			- develop
jobs:
	build:
		name: Build Project
		runs-on: ubuntu-20.04
		strategy:
			matrix:
				node-version:
					- 12.x
		steps:
			- name: Checkout code
				uses: actions/checkout@v2
			- name: "Use Node.js ${{ matrix.node-version }}"
				uses: actions/setup-node@v1
				with:
					node-version: "${{ matrix.node-version }}"
			- run: rm -rf .npmrc
			- run: >-
					echo "//npm.pkg.github.com/:_authToken=${{ secrets.NPM_TOKEN }}" >
					~/.npmrc
			- run: npm install
			- run: npm run test
			- run: npm run build
			- run: npm publish

Prettier

I have in config

  "scripts": {
    "api": "documentation build *.js -f md -o api.md",
    "spell": "yarn api && yaspeller-ci *.md",
    "clean": "rimraf api.md coverage/",
    "test": "jest --coverage && eslint-ci . && size-limit && yarn spell"
  },

and in project:

  "scripts": {
    "api": "documentation build *.js -f md -o api.md",
    "spell": "yarn api && yaspeller-ci *.md",
    "clean": "rimraf api.md coverage/",
    "test": "jest --coverage && eslint-ci . && size-limit && yarn spell",
    "start": "parcel serve test/demo/index.html -d test/demo/build --open"
  },

When I updated the config, my start script was removed

git clone [email protected]:ai/nanoevents.git
yarn upgrade-interactive --latest
# Select @logux/sharec-config
git diff

Sharec will change package.json

   "yaspeller": {
     "lang": "en",
     "ignoreCapitalization": true,
-    "ignoreText": [
-      " \\(by [^)]+\\)."
-    ],
     "dictionary": [
       "EventEmitter",
       "gzipped",
@@ -92,9 +89,12 @@
       "npm",
       "unbindAll",
       "Versioning"
+    ],
+    "ignoreText": [
+      " \\(by [^)]+\\)."
     ]
   },

version: v2.x

If user has removed any field and upcoming config contains it – do not apply it to the target project.

I have idea of "composable" strategies.
It should make simple package.json merging or split all strategies for small units.
In the case of package.json:

const packageJsonStrategy = compose({
  scripts: hashStrategy,
  dependencies: hashStrategy,
  eslint: eslintStrategy,
  ...
})

Or for mixed structures, like yaspeller:

const yaspellerStrategy = compose({
  dictionary: listStrategy,
  ...
})

Describe the bug

Sharec rewrite script, if command have equal subcommand

Steps to reproduce the behavior

1. Add to scripts:

"build:local": "next build && next export",

2. reinstall sharec in project

Expected behavior

"build:local": "next build && next export",

Code snippets

node_modules/sharec/src/strategies/helpers/params/commandsToMap.js

      parsedCommand.set(subcommand, parsedSubcommand) //subcommand = "next"

System

[email protected]

Some tests very large and difficult for supporting, for example – strategies or commands.
If split them to small units – it would be more convenient in the future.

When a file is an executable in the config repository, the file isn't executable in the target project.

1. git clone https://github.com/ai/nanoevents.git
2. cd nanoevents
3. yarn
4. yarn upgrade-interactive --latest and select @logux/sharec-config
5. Sharec removed .travis,yml and .gitignore
6. Sharec doesn’t add dependencies from config like eslint-plugin-unicorn

[email protected] depend on [email protected]. But [email protected] is not published.

At this moment sharec has a huge code base. I think, it is a good moment to use typescript here.
Because there is no any big feature in plans, I will start migration as soon as it possible. If someone wants to participate in migration process – welcome there ✨
New version will be released as v2.x.x, because I want to save all the original functionality.

I have .eslintrc.js both in the config and in my project. sharec replaces local .eslintrc.js with file from the config. Is this expected behaviour?

lodash is huge npm package. If you need only few functions, it is better to add like lodash.merge to package.json.

Hi @lamartire, first of all bravo for this package. I also had the idea to simplify the build/setup process, but I couldn't have done it simpler than this. You had a very good idea, congrats 👏 !

I have a few more questions, before I set this up on my projects:

• Is there a way to override the configuration files that will be installed?
• Are all the configuration files supported, is it generic?

Once again, this is really cool. It replaces the need (for me) to setup lerna for my projects, it's minimalistic, waaay simpler and lightweight.

Nano ID has eslintIgnore keys in package.json:

  "eslintIgnore": [
    "node_modules",
    "test/demo/build"
  ]

My sharec config has:

  "eslintIgnore": [
    "node_modules",
    "test/demo/build"
  ]

Every time when I update the config, sharec remove test/demo/build from package.json.

When I update my sharec config, it removed all my local changes for .gitignore.

Seems like we need to work with them as a list and merge differences.

version: [email protected]

Hi

thanks for your great tool.

I found the merge strategy problem in package.json.

I just give an example for eslintconfig config.

the same problem appear in others,like postcss,babel and so on.

// package.json in share-config package
{
...
"eslintConfig": {
  "root": true
}
...
}

// package.json in business project
{
...
"eslintConfig": {}
}

when update share-config package in business project, the root field dosen't merge into package.json in business project.

but if i use other custom prop like this:

// package.json in share-config package
{
...
"eslintConfig": {
  "customProp": true
}
...
}

// package.json in business project
{
...
"eslintConfig": {}
}

it's ok.

i am not sure it is right or wrong for sharec?

I have monorepo with sharec in the root. When I call npm install on the root (it triggers npm install in each package) I got unnecessary sharec changes in packages.

I've tried to disable formatting using this config in /package.json
"sharec": { "configs": { "package.json": { "format": false } } }
and this in /.sharecrc.json
{ "configs": { "package.json": { "format": false } } }
Formatting was applied in both cases.
The issue seems to be caused by an unused file: https://github.com/lamartire/sharec/blob/9e24d08424938bdbde1bb2c9bc11b74ec3a9e869/packages/sharec/src/steps/readSharecConfig.js

Hi,

I'm having an issue with the command npx fixpack || true in package.json/scripts.

I'm getting the error:

✖ Initializing sharec
TypeError: Cannot read property 'split' of undefined
    at /test/node_modules/sharec-schema/lib/helpers/commandsToMap.js:36:58
    at Array.reduce (<anonymous>)
    at commandsToMap (/test/node_modules/sharec-schema/lib/helpers/commandsToMap.js:22:30)
    at commandAtom (/test/node_modules/sharec-schema/lib/atoms/command.js:61:41)
    at /test/node_modules/sharec-schema/lib/actions/compose.js:46:9
    at /test/node_modules/sharec-schema/lib/actions/compose.js:83:65
    at /test/node_modules/sharec-schema/lib/actions/compose.js:46:9
    at Object.<anonymous> (/test/node_modules/sharec-schema/lib/actions/compose.js:82:69)
    at Object.processor (/test/node_modules/lodash/_createFlow.js:71:31)
    at /test/node_modules/sharec/src/steps/mergeConfigs.js:78:39

I've look at commandsToMap, it's splitting the command into subcommands and arguments. But why?

PS: I have to add || true because fixpack in return 1 even when it has successfully fixed the package.json

picocolors is better and I closed nanocolors

Hi, I have some problem
When I run npx sharec gitignore does not convert to .gitignore(version sharec 3.2.1)
Could you please help me?

In new flow previous aliases were broken. Need to restore this functionality.
npmignore should be applied to .npmignore or just be written by this name.

At this moment, the most of fixture tests uses toWraplessEqual which unifies all line-wraps symbols to current OS EOL.
In this case, we can't correctly check EOF in formatting specs and other ones.
Need to remove toWraplessEqual matcher and find better solution for matching tests.

It should install configuration without footprints – without cache and sharec meta-data in target project package.json.

Link on https://github.com/lamartire/sharec/tree/master/packages/sharec go to https://sharec.js.org/overview/

Document not found (404)
This URL is invalid, sorry. Please use the navigation bar or search to continue.

I have a config with these scripts in package.json.

  "scripts": {
    "api": "documentation build *.js -f md -o api.md",
    "spell": "yarn api && yaspeller-ci *.md",
    "clean": "rimraf api.md coverage/",
    "test": "jest --coverage && eslint-ci . && size-limit && yarn spell"
  },

I added this config to my project and changed api script:

  "scripts": {
-   "api": "documentation build *.js -f md -o api.md",
+   "api": "documentation build *.js async/*.js -f md -o api.md",
    "spell": "yarn api && yaspeller-ci *.md",
    "clean": "rimraf api.md coverage/",
    "test": "jest --coverage && eslint-ci . && size-limit && yarn spell"
  },

When I updated the script, sharec clean my api script changes

It is not obvious after configuration install, when we do not have any messages from sharec

It is very popular pattern to have && list of commands in package.json scripts:

  "test": "jest --coverage && eslint . && size-limit && yarn spell"

We can tread these scripts as lists: if locally one element changed we can ignore this element, but update others.

Of course, we should not hurry with this issue and do #47 first