Comments (4)
Not a bug. See #109 followed by https://github.com/shama/webpack-stream#usage-with-gulp-watch
from webpack-stream.
Reopening. Per #18 (comment) the approach in #109 is 10x slower than webpack.watch()
.
We need to resolve the deprecation warning mentioned above.
from webpack-stream.
@shama I think I figured it out. If you invoke:
const compiler = webpack(config);
compiler.watch({}, callback);
where config
does not contain watch: true
then webpack does watch the files because you invoked the watch()
method explicitly. If I leave watch: true
in config
then webpack issues the aforementioned warning.
One way you could fix this bug is to simply strip watch: true
from config
before passing it on to webpack. Users will still need to pass watch: true
to this plugin so it knows to invoke compiler.watch()
but you will need to strip it out before passing the config to webpack. Makes sense?
from webpack-stream.
@shama I tested #231 locally. It fixes the deprecation warning for me. Please review and merge if you agree.
from webpack-stream.
Related Issues (20)
- DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead HOT 5
- DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead HOT 1
- Support webpack version 5 HOT 2
- Webpack 5 HOT 3
- Using webpack 5 as described in README produces empty output files HOT 1
- Error: Rule can only have one resource source when using webpack-stream HOT 4
- webpack.config entry import syntax support HOT 1
- Slowdown after upgrade to 6.x.x. HOT 4
- Using webpack-5 results in no output files HOT 4
- Question about multiple entry points
- DEP_WEBPACK_TEMPLATE_PATH_PLUGIN_REPLACE_PATH_VARIABLES_HASH HOT 2
- MODULE_NOT_FOUND error while using version 7.0.0 HOT 2
- [Error] Invalid left-hand side expression in prefix operation HOT 4
- webpack-stream 7.0.0 throws an error: Cannot find module webpack/lib/ProgressPlugin HOT 6
- Did you forget to signal async completion... HOT 5
- Remove the need to manually filter out source map files HOT 4
- Callback in being ignored in the multicompication case
- Webpack 5 Stream won't compile HOT 1
- Webpack stream w/ Gulp — errors when using aliases in webpack config HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpack-stream.