Git Product home page Git Product logo

shalinshah1993 / temporaldnabarcodes Goto Github PK

View Code? Open in Web Editor NEW
0.0 3.0 2.0 83.47 MB

A MATLAB suite implementing computer vision pipeline to extract information from the noisy TIRF microscopy data (image stack)

License: GNU General Public License v3.0

MATLAB 86.63% HTML 12.24% TeX 1.13%
matlab-functions single-molecule-imaging temporal-dna-barcodes dna-barcode fluorescence-microscopy-imaging tirf

temporaldnabarcodes's People

Contributors

csoneson avatar shalinshah1993 avatar

Watchers

 avatar  avatar  avatar

Forkers

csoneson luyugu

temporaldnabarcodes's Issues

JOSS Reviewer comments:

Ref: ExTemp Review

General comments

  • Some minor grammar errors in the paper.pdf, e.g. "In particular, since the fluorescent signal comes from dye-labeled DNA, hence temporal DNA barcodes". To me this doesn't read-well
  • The text itself seems a little light and hard to understand. I looked at the cited paper in Nano letters and it is explained much better. I raise this as a point in order to make any potential user more aware of what it is this software package does/works with.
  • There are no acknowledgements, I see from your previous work that you are funded by National Science Foundation Grants (though, it is mentioned in the readme.MD).
  • I don't find author contributions in the paper (though they are in the readme.MD).
  • As you are using MATLAB, can you confirm what packages/toolboxes that a user will need, additionally, it would be useful to highlight which MATLAB versions the software should work on.
  • I note you used on a HPC equiment to run your experiments, can you comment on if a 'standard' desktop PC is enough for this, or if HPC access is required to perform analysis in regular time?
  • Your readme.MD mentions they can be used for any arbitrary microscopy project that requires data extraction from fluorescence microscopy data - perhaps expanding on this and showing some general usecases would be good to make this software useful for a wider audience?
  • Have you tested in Octave, it would be useful to know if FOSS software is capable of running these modules rather than closed platforms.
  • Do you provide estimations for expected errors from running your software, is there an alternative form of analysis? When similar experiments were ran prior to 2019, how were their data analysed?

Review guidelines to be met:

  • If there are any performance claims of the software, have they been confirmed I cannot easily test this, are you able to provide any automated testing with example data
  • The above comment also would address the requirements for: example usage, functionality and automated tests.

High threshold raises insertShape issue

If findalllocalizations has toDisplay set and a very high threshold value is given for example, 6, then insertFrame raises an error.

For example, findalllocalizations(<file_name>, 6, 1, 1) raised:

Error using insertShape
Expected POSITION to be finite.

Error in insertShape>checkPosition (line 280)
   validateattributes(position, {'numeric'}, ...

Error in insertShape>validateAndParseInputs (line 237)
checkPosition(position);

Error in insertShape (line 106)
    validateAndParseInputs(I, shape, position, varargin{:});

Error in findalllocalizations (line 50)
                localized_frame = insertShape(cur_frame,'circle', [points(:, 1) ...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.