shahroq / whale_manual_nav Goto Github PK

Existing blocks display OK when a site is updated to v9.
But the edit dialog breaks with $(...).concreteFileSelector is not a function.

New blocks appear to open the add dialogue, but fail at the same error once editing.

I suspect its the v9 rework of core JavaScript that is responsible.

(also posted in support https://marketplace.concretecms.com/marketplace/addons/nestable-manual-nav/support/edit-mode-fails-in-v9-....concretefileselector-is-not-a-function/)

If you have a long list of items, clicking the "Add Item" button makes the dialog scroll way up the list instead of to the item you just added.

This line:

Should be using position() instead of offset() because we need the offset relative to the parent, not the offset on the screen.
thisModal.animate({scrollTop: newItem.position().top},'slow');