Git Product home page Git Product logo

deathrun-classic's People

Contributors

shadow93 avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

wormatty dedimark

deathrun-classic's Issues

Players joining during pre-round freeze time (preparation time) are prevented from joining a team

Hi, there.

If you join the server and select a team round during pre-round freeze time (preparation time), the jointeam command is blocked. This leaves the player unable to join a team without using a console command.

The problem seems to be that the plugin tries to retrieve any command the player uses during prep time from its command blocking team trie, but if the command doesn't exist, the team comparison integer remains at its initialised value of 0, so any commands used by someone with no team will be blocked because they are on team 0.

I've implemented a fix but am not sure if it will have any negative effects on other commands used by players with no team during prep time, without thorough testing. I doubt it will but that's up to you to decide as you may be more familiar with its workings. I don't know what I'm doing with GitHub or the best practice so I created a fork and have a link to the affected section of code: https://github.com/worMatty/Deathrun-Classic/blob/45bace9bb4fee1e3a17f775aa9637be3dbd18905/addons/sourcemod/scripting/deathrun_redux.sp#L1389

I also commented BUG on a couple of other things you may want to look at. If you need me to create a pull request or something let me know and I'll try to work it out.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.