sfmohassel / libc.translation Goto Github PK

Hi, I stumbled across your project while looking for a json based translation solution.
It does work well, so kudos for that.

However, I think it is not a good idea to keep the whole JSON structure in memory and look for the translation keys with iterations.

I'd propose to load all keys in a flat structure into dictionaries and just access those dictionary keys.
Based on the PropertyCaseSensitivity the keys could be converted to lower-case, as well as the key that is being searched.

Moreover, I'd also propose to allow a directory-based solution where each file represents a single language instead of having everything in one humongous file.

I did a proof-of-concept implementation already locally and wanted to hear your opinion.

Thanks in advance

Does this library really need to be tied to .NET 5+? Or could it support .NET Standard?

Hi,

I use your library with English and french string. All English strings are properly retrieved but some french word containing accent are skipped. For example Activité projet will be display in PDF like Activit projet.

Do you have an idea about that?
Thanks

Great repo!

Have you considered using System.Text.Json instead of Newtonsoft JSON?

Would be great if you did.

currently the 'JsonLocalizationSource' class needs to be case sensitive. sample:

ILocalizationSource source = new JsonLocalizationSource(stream, PropertyCaseSensitivity.CaseInsensitive);

in case you want to modify it in your usage examples.