Building book examples against SFML latest (2.4.2) results in a few deprecation warnings. These warnings can be broken down into two cases:

• sf::Text::setColour() sf::Text API
• sf::Shader::setParameter() sf::Shader API

Diff at pastebin updates code base to remove warnings during compile.

get this warning when configuring cmake:

CMake Deprecation Warning at CMakeLists.txt:2 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

Editing CMakeLists.txt:2 to "cmake_minimum_required(VERSION 2.8...3.5)" prevents the error message,
but the compatibility issues are not solves.

At the SFML-Game-Development-Book-master\CMake directory there is a FindSFML.cmake file,
which is said to no longer be supported anymore, but rather SFMLConfig.cmake is now used instead.

As ${SFML_LIBRARIES}, ${SFML_DEPENDENCIES} and ${SFML_INCLUDE_DIR} were removed from SFML after v2.5,
you can't build the example as-is, on the latest stable version.

I had to do some workaround on my fork (copyrat90@928f347), in order to build it properly.

It would be nice if you can build the example without messing around the CMake script.

sample code compiled with visual studio 2017 fails to load shader, to fix change Brightness.frag line 12
from:
sourceFragment *= clamp(luminance - Threshold, 0.0, 1.0) * Factor;
to:
sourceFragment *= clamp(luminance - Threshold, 0.f, 1.f) * Factor;

This problem is persisting even after writing the code by myself, and compiling it from your provided source. How can I solve it? Please help.

Not an issue, just a question.
SFML don't support high dpi and the only solution right now is to set NSHighResolutionCapable to false, that way we get low resolution but the actual window size.
I'm not really interested in making my own games, but I'm very interested in reading this book!
Is there a way that you can edit CMakeList to support creating an app bundle for OSX?

Right now I'm on a MacBook Pro and it is imposible to work through the book, sadly I don't have the knowledge to edit the CMake files myself and share it with other people.

Thanks!

No SceneNode class contains a virtual destructor declaration, while it is a base class with many other virtual functions. I suppose it is a bug, causing memory leaks.

template <typename GameObject, typename Function>
Command::Action derivedAction(Function fn)
{
    return [=] (SceneNode& node, sf::Time dt)
    {
        // Check if cast is safe
        assert(dynamic_cast<GameObject*>(&node) != nullptr);

        // Downcast node and invoke function on it
        fn(static_cast<GameObject&>(node), dt);
    };
}

This function produces a compiler error C3848 in VS2013 Express on Windows 7.
It's line 33

fn(static_cast<GameObject&>(node), dt);

a non-const function is invoked by const function

The CMake script provides the SFML_ROOT variable to provide the location of SFML when installed outside of the system's default locations. However, find_path() is implemented to look in system default location first, and looks in the custom paths provided in PATHS only if no match is found in the system default. This means that if the system contains a version of SFML but the user has a (supposedly newer) version manually installed somewhere else that they want to use instead, the (older) system version will always be picked first.

To fix this, I would suggest specifying SFML_ROOT in HINTS instead of PATHS. Indeed, contrary to PATHS, HINTS are looked up before the system locations.

# find the SFML include directory
find_path(SFML_INCLUDE_DIR SFML/Config.hpp
          PATH_SUFFIXES include
          HINTS ${SFML_ROOT} $ENV{SFML_ROOT}
          PATHS ${FIND_SFML_PATHS})

The same should then be done for the find_library() calls, and SFML_ROOT should be removed from FIND_SFML_PATHS.

Line 10 of SoundNode.cpp