severedsolo / alarmenhancements Goto Github PK

Mun encounter with flyby and escape, also Kerbin escape.
Two alarms are created, for each escape.
As soon as the Mun orbit is secure, the Mun escape alarm is automatically deleted, but the Kerbin escape alarm persists.

https://forum.kerbalspaceprogram.com/index.php?/topic/204404-112x-alarm-enhancements-102-26082021-automatic-alarms-and-better-naming-of-alarms/&do=findComment&comment=4026014

AFAICT, you've got over 50 unused references. The dependencies needed are (fairly typical for a KSP mod):

• Assembly-CSharp
• System
• System.Core
• UnityEngine
• UnityEngine.CoreModule

You can save time on the build, storage space, and simplify setup for any other developer contributing by eliminating the unused ones.

https://forum.kerbalspaceprogram.com/index.php?/topic/204404-112x-alarm-enhancements-102-26082021-automatic-alarms-and-better-naming-of-alarms/&do=findComment&comment=4025191

Harmony is a library that lets the user pre-fix, post-fix, and transpile .net methods. A few prominent KSP mods use it, including KSP Community Fixes, Kerbalism, and Luna Multiplayer.

With Harmony, you can override the "GetDefaultTItle" method of the alarm classes and get the behavior many users have asked for (allowing them to change the alarm names) plus better performance (don't have to respond to added alarms, which includes edited alarms), plus because you're overriding the default title, the user can actually use your improved default title to make whatever edits they want from the template. For example, I might want to edit my maneuver alarm from "My Vessel Maneuver" to "My Vessel Circularization".

The code is very simple to do this, I might turn this into a PR to contribute, by proof of concept:

using HarmonyLib;
using UnityEngine;

namespace AlarmEnhancements
{
    [KSPAddon(KSPAddon.Startup.Instantly, true)]
    public class AlarmEnhancements : MonoBehaviour
    {
        private void Start() {
            var harmony = new Harmony("com.marr75.alarmEnhancements");
            harmony.PatchAll();
        }
    }

    [HarmonyPatch(typeof(AlarmTypeManeuver))]
    class ManeuverAlarmPatch {
        
        [HarmonyPrefix]
        static bool GetDefaultTitle(AlarmTypeManeuver __instance, ref string __result) {
            __result = $"{__instance.vesselName} Maneuver"; // Overwrite the old result
            return false;  // don't bother running the old method, it was a simple localization call of the word, "Maneuver", anyway
        }
    }
}

You'll also catch the alarms created from the map view shortcut with this approach, obviously.

when auto add atmosphere alarm enabled, game lag for every few seconds.

using bisection method can improve performance.

https://forum.kerbalspaceprogram.com/index.php?/topic/204404-112x-alarm-enhancements-101-18082021-automatic-alarms-and-better-naming-of-alarms/&do=findComment&comment=4022152

https://forum.kerbalspaceprogram.com/index.php?/topic/204404-112x-alarm-enhancements-101-18082021-automatic-alarms-and-better-naming-of-alarms/&do=findComment&comment=4021632