sesalab / adoctor Goto Github PK

• Wrap everything it.unisa.plugin packages
• Change some interfaces, e.g., there are some ArrayList to be changes in List
• Make AnalysisDriver and ProposalDriver without state and their core method receive all parameters
• Rename startAnalysis() into analyze()
• Rename computeProposal() into propose()
• Package filtering should be done by CoreDriver, not by AnalysisDriver (so that it won't need targetPackage anymore)
• Similarly to ProposalDriver, AnalysisDriver should be constructed on the list of analyzers and launch the analysis on the list of files.
• LT allow static Thread constructor
• MIM and IDS propagate changes
• Improve Smell Dialog UI with Filtering option
• Return more than one smell instance per class
• Add progress bar during analysis (while showing the analyzed files)
• Use better multithreading during analysis
• Improve exception and errors handling
• Implement Fix all feature button

Backend with Firebase?

Maybe "promote" them to ProjectSmell? ProjectSmell does not exist yet, but this might be the chance. It would be good to let aDoctor show multiple diff for a single smell!

• Change indent style to Spaces
• Do not remove line comments (https://stackoverflow.com/questions/3019729/how-to-access-comments-from-the-java-compiler-tree-api-generated-ast/9884987#9884987)
• Do not reformat Javadoc
• MIM check internal proprieties of direct superclasses
• MIM check internal proprieties of indirect superclasses
• IS check better for internal
• LT should propose interrupt() and not stop()
• LT should check if the subject thread object is an instance variable
• Keep found indent style (how to determine it?)
• MIM check should not check inner classes (they cannot have static members)
• IS must check only for a single assignement body (already done?)
• IS allow different argument names

ERB identification and refactoring still follows old assumptions. Align ERBAnalizer, ERBProposer and ERBSmell to other "brother" classes

• Add select/unselect all smells
• Keep memory of selected smell when Back is used
• New package selection

Run aDoctor on aDoctor!

The architectural pattern might actually be a MVP Supervising Controller, where views do not have any data binding and do not call model logic.
Model is the application, View is the set of Swing dialogs (along with their event handlers) + StartAction and Presenter might be CoreDriver.

Proposal:

• Rename application --> model
• Rename presentation --> gui (this allow future User Interfaces)
• Rename CoreDriver --> CorePresenter
• CoreDriver(Presenter) should observe on each dialogs instead of using callback interfaces
  • Dialogs should implement a View/Observable interface
  • CoreDriver(Presenter) should implement an Observer interface
• Split CoreDriver(Presenter) into some Presenters

Another alternative is with Mediator pattern

When the analyzer is searching for smell instances, the "analyze" method returns on the first smell instance found, ignoring the remaining smells present in the class.