Hi,
It seems that the change token handling isn't implemented in this extension. At least I couldn't find it in code and I found it while playing with it and changing configuration but nothing happend ;)

Is this something you are going to add?
thanks
M

Hi,
I'm trying the extension, and it's working great, but I can't get Debug Levels logged.
I've settled up the app.settings like this:

"Logging": {
    "PathFormat": "Logs/log-{Date}.txt",
    "LogLevel": {
      "Default": "Debug",
      "Microsoft": "Information"
    }
  },

And the Startup.cs like this:
loggerFactory.AddFile(Configuration.GetSection("Logging"));

I'm trying really simple from a controller:
_logger.LogDebug("TestController");

But the log is not in the file. If I change
_logger.LogDebug("TestController") to _logger.LogInformation("TestController"); the log shows in the log file as expected.

What I'm doing wrong?

Thanks for your help.

i am registering serilog file logger via Microsoft.Extensions.Logging in my Xamarin.Forms AppContainer like this:

builder
	.Register(handler => LoggerFactory.Create(log =>
	{
		log.AddFile("log.txt");
	}))
	.As<ILoggerFactory>()
	.SingleInstance()
	.AutoActivate();

builder
	.RegisterGeneric(typeof(Logger<>))
	.As(typeof(ILogger<>))
	.SingleInstance();

and try to write some log data later on like this:

var logger = AppContainer.Resolve<ILogger<App>>();
logger.LogCritical("test");

but for some reason i neither get any error nor a log file which begs the question: how can i troubleshoot this to find out what's wrong?

The current log string format doesn't output the category of the entry - at least not by default, but maybe I'm overlooking a configuration option somewhere?

If output of log item category is not supported today, are there any plans for it in the future?

I'm using Serilog.Extensions.Logging.File nuget package Version=2.0.0 in my AspNet Core 3.1 app.
This is what I have in my Program.cs file:

public static IHostBuilder CreateHostBuilder(string[] args) =>
            Host.CreateDefaultBuilder(args)
               .ConfigureLogging((hostingContext, builder) =>
                {
                    builder.AddFile(hostingContext.Configuration.GetSection("Serilog"));
                    builder.AddSerilog(dispose: true);
                })

This is what I have in my appsettings.json

"Serilog": {
    "Using": [ "Serilog.Sinks.RollingFile" ],
    "Enrich": [
      "FromLogContext"
    ],
    "PathFormat": "Logs/myapp-{Date}.txt",
    "LogLevel": {
      "Default": "Information",
      "Microsoft": "Warning",
      "Microsoft.Hosting.Lifetime": "Information"
    },
    "Json": false,
    "FileSizeLimitBytes": 1000000,
    "RetainedFileCountLimit": 3,
    "outputTemplate": "{Timestamp:yyyy-MM-dd HH:mm:ss} [{Level}] {Message}{NewLine}Properties: {Properties}{NewLine}MachineName: {MachineName}{NewLine}Application: {Application}{NewLine}{Exception}-------------------------------------------------------------------{NewLine}",
    "Properties": {
      "Application": "XWRA",
      "MachineName": "%COMPUTERNAME%"
    }
  }

It generates the txt file but not metadata of Application and Machine name.
I'm using Windows machine.
Am I missing something?

There doesn't seem to be a way to flush the logger's contents to file at the end of the lifetime of a console app.

To reproduce, create a dotnet core console app and log a few lines. Then let the program run to its end. More often than not, it won't log anything.

Add a Console.ReadKey() to the end of your program, and you'll see this will make the logger flush itself, because it's granted some time to do so.

The Log.CloseAndFlush() method is not available when you are only using the file logging extension method.

Even if it were, it would need to have a logger assigned to Log.Logger. But its type is not compatible with dotnet core's logger type as used in this snippet:

serviceCollection
	.AddLogging()
	.AddSingleton(
		new LoggerFactory()
			.AddFile(@"Logs/myapp-{Date}.txt")
			.AddConsole()
			.AddDebug()
);

It would be nice if the Serilog logger could flush itself on finalize.

I believe this is how log4net does it, since I never had any problems with that.

Repro: https://github.com/aleksey-s902/SerilogProviderNotDisposedRepro

        static void Main(string[] args)
        {
            var serviceProvider = new ServiceCollection()
                .AddLogging(builder =>
                {
                    builder.AddFile("test.log");
                })
                .BuildServiceProvider();

            var logger = serviceProvider.GetService<ILogger<Program>>();
            logger.LogError("test");
            
            serviceProvider.Dispose();
            // Thread.Sleep(5000);
        }

Problem with this code: the log file isn't written. There is obviously a race condition because if I uncomment Thread.Sleep, the log file appears correctly. My understanding of what happening there is:

• AddFile adds an async file writer which runs in a background thread
• Application shuts down before the background thread has a chance to write the log file
• Normally, this is prevented by disposing logger before shutdown. I would expect that in this case ServiceProvider would dispose the logger. However, that isn't happening.

As to why it isn't happening: I suppose that's caused by the same reason as aspnet/Hosting#1466. AddSerilog register an instance of SerilogLoggerProvider, and ServiceProvider won't dispose anything added as an instance.

Workaround: dispose the logger provider manually:

serviceProvider.GetService<ILoggerProvider>().Dispose();

What's the o, what's the u3???

• Issue is not seen on windows
• Issue is only seen on my server (Linux Unbuntu running DNC 3.1)
• Removing Serilog fixes the issue
• Stack trace below

root:~/SimpleOffice# dotnet SimpleOffice.dll
Application startup exception: System.MissingMethodException: Method not found: 'Microsoft.Extensions.Logging.ILoggerFactory Microsoft.Extensions.Logging.FileLoggerExtensions.AddFile(Microsoft.Extensions.Logging.ILoggerFactory, System.String, Microsoft.Extensions.Logging.LogLevel, System.Collections.Generic.IDictionary2<System.String,Microsoft.Extensions.Logging.LogLevel>, Boolean, System.Nullable1, System.Nullable1<Int32>)'. at SimpleOffice.Startup.ConfigureLogger(ILoggerFactory loggerFactory, IHttpContextAccessor http) at SimpleOffice.Startup.Configure(IApplicationBuilder app, IServiceScopeFactory factory, IWebHostEnvironment env, IHttpContextAccessor http, ILoggerFactory loggerFactory) in D:\Projects\SimpleSys\SimpleOffice\SimpleOffice\SimpleOffice\Startup.cs:line 138 at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions) at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder) at Microsoft.AspNetCore.Hosting.ConfigureBuilder.<>c__DisplayClass4_0.<Build>b__0(IApplicationBuilder builder) at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app) at Microsoft.AspNetCore.Mvc.Filters.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.<Configure>g__MiddlewareFilterBuilder|0(IApplicationBuilder builder) at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder app) at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication() crit: Microsoft.AspNetCore.Hosting.WebHost[6] Application startup exception System.MissingMethodException: Method not found: 'Microsoft.Extensions.Logging.ILoggerFactory Microsoft.Extensions.Logging.FileLoggerExtensions.AddFile(Microsoft.Extensions.Logging.ILoggerFactory, System.String, Microsoft.Extensions.Logging.LogLevel, System.Collections.Generic.IDictionary2<System.String,Microsoft.Extensions.Logging.LogLevel>, Boolean, System.Nullable1<Int64>, System.Nullable1)'.
at SimpleOffice.Startup.ConfigureLogger(ILoggerFactory loggerFactory, IHttpContextAccessor http)
at SimpleOffice.Startup.Configure(IApplicationBuilder app, IServiceScopeFactory factory, IWebHostEnvironment env, IHttpContextAccessor http, ILoggerFactory loggerFactory) in D:\Projects\SimpleSys\SimpleOffice\SimpleOffice\SimpleOffice\Startup.cs:line 138
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.ConfigureBuilder.<>c__DisplayClass4_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Mvc.Filters.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.g__MiddlewareFilterBuilder|0(IApplicationBuilder builder)
at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication()
Unhandled exception. System.MissingMethodException: Method not found: 'Microsoft.Extensions.Logging.ILoggerFactory Microsoft.Extensions.Logging.FileLoggerExtensions.AddFile(Microsoft.Extensions.Logging.ILoggerFactory, System.String, Microsoft.Extensions.Logging.LogLevel, System.Collections.Generic.IDictionary2<System.String,Microsoft.Extensions.Logging.LogLevel>, Boolean, System.Nullable1, System.Nullable`1)'.
at SimpleOffice.Startup.ConfigureLogger(ILoggerFactory loggerFactory, IHttpContextAccessor http)
at SimpleOffice.Startup.Configure(IApplicationBuilder app, IServiceScopeFactory factory, IWebHostEnvironment env, IHttpContextAccessor http, ILoggerFactory loggerFactory) in D:\Projects\SimpleSys\SimpleOffice\SimpleOffice\SimpleOffice\Startup.cs:line 138
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.ConfigureBuilder.<>c__DisplayClass4_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.Mvc.Filters.MiddlewareFilterBuilderStartupFilter.<>c__DisplayClass0_0.g__MiddlewareFilterBuilder|0(IApplicationBuilder builder)
at Microsoft.AspNetCore.HostFilteringStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication()
at Microsoft.AspNetCore.Hosting.WebHost.StartAsync(CancellationToken cancellationToken)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token, String startupMessage)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token, String startupMessage)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.RunAsync(IWebHost host, CancellationToken token)
at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host)
at SimpleOffice.Program.Main(String[] args) in D:\Projects\SimpleSys\SimpleOffice\SimpleOffice\SimpleOffice\Program.cs:line 30

Hi,

I downloaded your repository and launched the example project and saw a lot of noisy logs were generated by the aspnetcore itself.
I tried to set the Microsoft entry of the appsettings.json to None but it didn't change anything.
Must I use your UseSerilogRequestLogging even if I just don't want this kind of logs?

{
  "Logging": {
    "PathFormat": "Logs/log-{Date}.txt",
    "OutputTemplate": "{Timestamp:o} {RequestId,13} [{Level:u3}] {Message} ({EventId:x8}) {Properties:j}{NewLine}{Exception}",
    "IncludeScopes": true,
    "LogLevel": {
      "Default": "Warning",
      "Microsoft.*": "None"
    }
  }
}

What happen is I need erase log file? I need stop running service? I don't understand idea.

It would be super nice if we were able to configure the message template instead of it being hard coded here.

I know that this library is opinionated and that the full serilog is recommended for more complex use cases, but this one is very easy to do with great benefits. I don't see myself ever needing the full serilog, but changing the message template would be very nice to have.

We have a project that we upgraded to aspnetcore 2.0. We have 2 logging providers, a console and a serilog file. After the upgrade (we didn't change anything related to logging at all), logging to a file stopped completely, the console logging is still working.

I updated this package to 2.0 preview, but the same still happened.

The config code is very simple:

loggerFactory.AddConsole(Configuration.GetSection("Logging"));
loggerFactory.AddFile(Configuration.GetSection("Serilog"));

Is there a way of getting the log files to roll on max size exceeded?

Cheers!

It seems OutputFormat doesn't work in Logging in appsettings.json doesn't work. Can someone check this out at Stackoverflow ?

The ReadMe says to add the following package reference:

<PackageReference Include="Serilog.Extensions.Logging.File" Version="2.0.0" />

But only version 1.1.0 is out.

Hi, I was success output log file
But I want add some line to log file
I try add in code
Log.Logger.Information("Hello"); //global Log
but in log file still don't have it

Or I need declare at every class this line
static readonly ILogger Log = Serilog.Log.ForContext<>();

Didnt even get past the first line of instructions after installing from NuGet.
Can someone help please???

I have an issue where ILoggingBuilder does not contain a definition for AddFile.

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Logging;

namespace SH.Pathology.Pttc.API
{
    public class Program
    {
        public static void Main(string[] args)
        {
            CreateWebHostBuilder(args).Build().Run();
        }

        public static IWebHostBuilder CreateWebHostBuilder(string[] args)
        {
            var webHost = WebHost.CreateDefaultBuilder(args)
                .ConfigureLogging((context, loggingBuilder) =>
                {
                    loggingBuilder.AddFile("");
                })
                .UseStartup<Startup>();

            webHost.ConfigureAppConfiguration((hostingContext, configurationBuilder) =>
            {
                if (hostingContext.HostingEnvironment.IsDevelopment())
                {
                    configurationBuilder.AddJsonFile("appsettings.Development.json", true);
                }
                else if(hostingContext.HostingEnvironment.IsStaging())
                {
                    configurationBuilder.AddJsonFile("appsettings.Staging.json", true);
                }
                else
                {
                    configurationBuilder.AddJsonFile("appsettings.Production.json", true);
                }
            });

            return webHost;
        }
    }
}

I tried to use this in a console application but found that if I logged and exited immediately then the log file was not flushed, there was no opportunity to specify the dispose.
I ended up doing the below in the end.

// Set up Serilog
Log.Logger = new LoggerConfiguration()
	.WriteTo.RollingFile(logFilename)
        .CreateLogger();

// Add logging
services.AddSingleton(
	new LoggerFactory()
		.AddSerilog(dispose:true)
		.AddConsole(loggingConfiguration)
		.AddDebug(LogLevel.Trace)
);

Within the Asp.Net Core logging infrastructure, the default rendering of format arguments should be the same. Example:

LogInformation("This is {0}", "an error") is expected to render as: This is an error

However, with Serilog it renders as: This is "an error"

Although this can be fixed supposedly by adding the :l specifier, I do not want to add Serilog specific modifiers, as I have other loggers that are used with the same messages concurrently.

We seem to be able to configure all rollingfile settings except for file sharing. The code for some reason has a preprocessor directive to set it to true or false if SHARED is defined, but it is not and there is no way to set that via code (obviously). We should be able to set this property.

Description

Per https://nvd.nist.gov/vuln/detail/CVE-2019-0820, there's a ReDoS vulnerability in System.Text.RegularExpressions 4.3.0, which is being referenced by Serilog 2.5.0 under .NET Standard. The vulnerability is also present in version 4.1.0 even though the advisory does not state that.

Explanation from Sonatype:

The System.Text.RegularExpressions package contains a Regular Expression Denial of Service (ReDoS) vulnerability. The System.Text.RegularExpressions.dll file does not properly implement a timeout when handling regular expressions. An attacker can exploit this with a maliciously crafted regular expression string, which when processed could use excessive resources and cause an application crash, resulting in a Denial of Service (DoS).

Advisory Deviation Notice: The Sonatype security research team discovered that the vulnerability is present in version 4.0.12-rc2-24027 until 4.1.0, not just version 4.3.0 as the advisory states.

System.Text.RegularExpressions 4.3.1 does not have this vulnerability.

I examined the Serilog.nuspec file to confirm that 4.1.0 is being referenced. Assuming the .nuspec is being autogenerated by dotnet pack, I'm guessing the reason 4.1.0 is being referenced rather than 4.3.1 is because of the "lowest applicable version" behavior¹.

Reproduction
Create a .NET Standard 2.0 project, reference Serilog 2.5.0, and build the project. Confirm that System.Text.RegularExpressions 4.1.0 is the version that is referenced.

Expected behavior
N/A

Relevant package, tooling and runtime versions
Serilog 2.5.0 on Windows with .NET Framework 4.8 but referenced via a .NET Standard 2.0 project.

Additional context
N/A

With this configuration...

"File": { "PathFormat": "Logs/MyLog_{Date}.txt", "LogLevel": { "Default": "Debug", "System": "None", "Microsoft": "None" } }

...Information level messages from Microsoft assemblies are still getting through. A temp workaround we are using is to set Microsoft and System to Critical.

Hi everyone, first of all thank you very much for your contribution with this package.

I just wanted to remind you to update the readme for .NET 6 users.

In program.cs, it is still very easy to configure logging:

var builder = WebApplication.CreateBuilder(args);
builder.Logging.AddFile("Logs/webapp.txt");

Thank you again

I use loggerFactory.AddFile(AppSettings.Configuration.GetSection("Logging:Serilog")); in Startup.Configure, when appsettings.json file changed, i want update the settings of serilog.
I use ChangeToken.OnChange for response the changing:

ChangeToken.OnChange(() => AppSettings.Configuration.GetReloadToken(), env_ =>
{
    //how to reconfigure serilog?
}, env);

My ASP.NET Core web API uses Serilog.Extensions.Logging.File version 1.1.0 and here is the sample of a log file generated from it
myLog-20180703.log
I had "The operation timed out" exception recorded under Request id = 0HLF0SCB4K08A. I know that web request to my web API makes only one call to https://_ _ /products/(...)? _ _ URL. However, I see call to this URL in line 1, 4, 9 and 16. What does a code after : means? Is it a part of Request id? Please explain.

My expectation is that a new file should be written if the size limit reaches the maximum.
Instead log-messages are lost.

I use the component in a asp core 2 project. Configuration is in appsettings.json.

Hi, I noticed that placing the {Date} placeholder in the pathFormat argument of the AddFile() extension method will make the lib put the current date in the format "yyyyMMdd" into the name.

Is there an option to specify a customized format. Other log files in my system use underlines between the poritions, i.e. "yyyy_MM_dd" and I'd like serilog to do the same.

Thanks

Could you clarify what the breaking change is that made the version go from 2.x to 3.x so we can see if we're impacted?

I'm logging the current user once per request. Thus, I'm able to find a single request of a specific user, but it would be nice to just filter log entries by the current user.

It already seems to be possible using some kind of middleware ceremony, but having a "one line" solution here would be really nice.

On short-lived applications such as command line interfaces, using async is not optional and logs are not written.

Can we add an option to the AddFile to use synchronous log?

I don't understand how serlog gets the value of requestid,How does it work?