Git Product home page Git Product logo

Comments (3)

iafan avatar iafan commented on August 16, 2024

So, in other words, 'approved' attribute should be set to 'no' regardless of the fuzzy status if the translation ($unit->{target}) is empty. I think it makes sense. Feel free to provide a PR.

from serge.

carusology avatar carusology commented on August 16, 2024

Well, not quite. The approved attribute is optional (Source):

<trans-unit>
Translation unit - The <trans-unit> elements contains a <source>, <target> and associated elements.

The required id attribute is used to uniquely identify the <trans-unit> within all <trans-unit> and <bin-unit> elements within the same <file>. The optional approved attribute indicates whether the translation has been approved by a reviewer. ... others ...

Required attributes: id.
Optional attributes: approved, ... others ...

I was suggesting omitting it entirely when no translation exists because it's irrelevant. However, since the default for approved is "no" (Source), it's logically the same thing.

from serge.

carusology avatar carusology commented on August 16, 2024

Thanks @iafan! Closed via #137.

from serge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.