senseyeio / spaniel Goto Github PK

The examples reference timespan and the package name is spaniel

The methods on Spans are inconsistent - all return spaniel.Spans except the IntersectionWith method:

func (s Spans) Intersection() Spans
func (s Spans) IntersectionWith(b Span) []*TimeSpan
func (s Spans) IntersectionWithHandler(...) Spans
func (s Spans) Union() Spans
func (s Spans) UnionWithHandler(unionHandlerFunc UnionHandlerFunc) Spans

Furthermore, since IntersectionWith returns a slice of pointers, its result is not a slice of Span implementations - since the TimeSpan struct methods do not have pointer receivers:

func (ts TimeSpan) End() time.Time
func (ts TimeSpan) EndType() EndPointType
func (ts TimeSpan) Start() time.Time
func (ts TimeSpan) StartType() EndPointType
func (ts TimeSpan) String() string

The inconsistency makes it difficult to use IntersectionWith in conjunction with the other Spaniel methods.