senorpez / project-cars-replay-enhancer-ui Goto Github PK

Car Name column in the classes section is way too narrow by default.

The validation for telemetry sync value can't be negative. It should allow for negative values for when you want to start the telemetry feed before the video feed... it's a rare thing, usually, but is supported.

Pressing the Add Additional Driver is doing nothing.

I tried two races with different config files and images. All having the same error message :(

michel@SRV-VM-UBUNTU:~/AOR/LMP2/round1$ replayenhancer -s config.json
Detecting Race End: 100%|████████| 284128/284128 [01:33<00:00, 3041.81packets/s]
Analyzing Telemetry Data: 100%|████████████████████████████████████████████▉| 283421/284128 [01:23<00:00, 3381.04packets/s]
Detecting Video Start: 8748it [00:07, 1115.56it/s]
Detecting Video End: 154it [00:00, 891.28it/s]
Traceback (most recent call last):
  File "/usr/local/bin/replayenhancer", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/replayenhancer.py", line 448, in main
    sync=args.sync)
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/replayenhancer.py", line 155, in make_video
    result_data.get_data()
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/RaceData.py", line 235, in get_data
    self._add_sector_times(self._next_packet)
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/RaceData.py", line 280, in _add_sector_times
    self.drivers[driver_name].add_sector_time(sector_time)
KeyError: None
michel@SRV-VM-UBUNTU:~/AOR/LMP2/round1$

Just saw that I posted this in the UI project...wrong place?

Needs to have an option in the UI for toggling between "video" and "custom" FPS.

See: SenorPez/project-cars-replay-enhancer#110

From #12:

Add option to cancel video creation.

Rearchitect participant configuration to allow for full customization. The "Defaults" should be things like "Car" and "Team," but what if we allowed the user to add, remove, rename columns to their heart's content?

When selecting the source video the program crashes.

D:\PC>java -jar configurationeditor-0.2-all.jar
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
mrt 04, 2017 10:12:53 AM com.senorpez.replayenhancer.configurationeditor.ConfigurationEditor lambda$main$0
SEVERE: Exception in thread: Thread[JavaFX Application Thread,5,main]

Add a parameter to show or hide the lap counter (timer).

See SenorPez/project-cars-replay-enhancer#117 for backend work.

Trying to run it from Windows and Ubuntu Desktop

Windows (will it even work under Windows?):
Applet starts but after saving the configuration the file cant be found on the system.

Ubuntu Desktop:
Starting from the command line with "java -jar ConfigurationEditor.jar" returns "Error: Could not find or load main class configurationeditor.ReplayEnhancerUI"

Add validation to video start time field such that video start time is required to:

• Be greater than 0.00.
• Be less than video end time.
• Be less than the video duration.

See SenorPez/project-cars-replay-enhancer#103 for errors.

Cars are currently sorted in the way they appear in the JSON; they should default to an alphabetical sort.

Remove the resize constraints on the Configuration Editor window.

If there are invalid entries (such as a negative Start Time), disable video creation.

If you save the configuration then it saves the end time as minutes, but ReplayEnhancer needs it in seconds.
Think this could be related to the error message in #5

Needs to be:
"video_skipend" : 5160.0 seconds
"video_skipstart" : 19.38 minutes

Steps:

1. Open editor from configurationeditor.bat
2. Create config
3. Save config
4. Close editor
5. Open editor from configurationeditor.bat
6. Load config

The two buttons under "Video creation" are greyed out.

edit: After selecting, loading source telemetry and select the output video the buttons are working.

Add validation to video start time field such that video start time is required to:

• Be greater than 0.00.
• Be greater than video start time.
• Be less than the video duration.

See SenorPez/project-cars-replay-enhancer#103 for errors.

Reading the telemetry file gives me a driver named "Archie619no"
Saving the configuration it writes "Archie619\u0000no" in the configuration file.

Running replayenhancer I get the error:

michel@SRV-VM-UBUNTU:~/replayenhancer$ replayenhancer -s race1-Spa_ok.json
Traceback (most recent call last):
  File "/usr/local/bin/replayenhancer", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/__init__.py", line 240, in main
    sync=args.sync)
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/__init__.py", line 207, in make_video
    Image.fromarray(pcre_series_champion.to_frame()).save(
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/StaticBase.py", line 60, in to_frame
    return PIL_to_npimage(self._make_material().convert('RGBA'))
  File "/usr/local/lib/python3.5/dist-packages/replayenhancer/DefaultCards.py", line 478, in _make_material
    self._name_lookup[entry.driver_name])
KeyError: 'Archie619no'

Chancing manual the name later on in the configuration file to Archie619no resolves the error.

Trying to use the custom window for a precision color in the class listing causes the dialog to immediately close and commit a wrong color.

Add a parameter for the Champion Screen Logo Size. It's currently hardcoded at 300.

See SenorPez/project-cars-replay-enhancer#115 for backend work.

The Configuration Editor currently writes blank objects and null fields into the configuration. This just clutters the configuration.

For example:
"car_classes" : { },
"series_logo" : null,

However, one thing that should be retained is the writing of empty string values for fields. For example:
"subheading_text" : "",

The reason for this is that the end-user has no distinction between "blank" and "null."

Just wanted this to be dummy proof ;-)

• If you create a new configuration and save it, you can push the video creation buttons. It will give you an error.
• If you create a new configuration and select a source video and save it, you can push the video creation buttons. It will give you an error.
• etc.

Maybe its better to disable the video creation buttons until all requirements are filled in?

From #12:

Add option to cancel driver detection.

Add a parameter for the Champion Screen Logo Size. It's currently hardcoded to white.

See SenorPez/project-cars-replay-enhancer#116 for backend work.