selfthinker / dokuwiki_template_starter Goto Github PK

The DokuWiki website states that the starter template is compatible with the "Angua" release of DokuWiki. This seems to be incorrect: I get "Call to undefined function page_findnearest()" errors when trying to use it.

I had to check the 2012-09-09 tagged version out to make it work.

When $conf['sidebar'] is not set, the sidebar should be disabled.

The current template on the dokuwiki site hasn't been updated since 2015. Is this theme still being maintained?

Formatting a monospaced text doesn't work because there's a style that resets all other styles.

try this:

  **__//''combine''//__**

and you'll see that there's no bold, italic or underline.

The template should make use of the new menu system as described at https://www.dokuwiki.org/devel:menus

I was recently building my own template based on the starter template and noticed a problem with the functions _tpl_discussion() and _tpl_userpage().
E.g. for the user tools there is the following code (main.php starting at line 76):

<?php _tpl_toolsevent('usertools', array(
  'admin' => tpl_action('admin', 1, 'li', 1),
  'userpage' => _tpl_action('userpage', 1, 'li', 1),
  'profile' => tpl_action('profile', 1, 'li', 1),
  'register' => tpl_action('register', 1, 'li', 1),
  'login' => tpl_action('login', 1, 'li', 1),
)); ?>

Now (if userpage is enabled in the config) this will display the link for the user page first and afterwards the ones for the admin, profile page and so on. However if you look at the code above one would expect the link for the admin page to be displayed first.

The reason is, that the functions _tpl_discussion() and _tpl_userpage() echo their output while the core function tpl_action() returns it.

I think that the code should be changed so that _tpl_discussion() and _tpl_userpage() (and subsequently _tpl_action()) also return instead of echo.

There are three !importants in css/_search.css which should be resolved through other means.

The only two remaining functions in tpl_functions.php which the starter template "needs" and which is not provided by the core by now are _tpl_discussion() and _tpl_userpage().

Those should be moved into a plugin instead so that the starter template can stay relatively lean.