seiei-n / isucon13 Goto Github PK

View Code? Open in Web Editor NEW

0.0 1.0 0.0 615 KB

Dockerfile 1.16% Makefile 2.03% Go 93.94% Shell 2.88%

isucon13's People

Contributors

Watchers

isucon13's Issues

[Todo]PowerDNS周りの最適化

とりあえず、dbを分割する

[Todo] : moderateHandler 謎に全部取ってきてる問題

isucon13/go/livecomment_handler.go

Lines 390 to 395 in 54ba742

 for _, ngword := range ngwords { 

 // ライブコメント一覧取得 

 var livecomments []*LivecommentModel 

 if err := tx.SelectContext(ctx, &livecomments, "SELECT * FROM livecomments"); err != nil { 

 return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livecomments: "+err.Error()) 

 }

[Todo]icon静的配信

[Todo] : rank 算出 N+1

毎回全員分確認してるのは馬鹿な気がする。

isucon13/go/stats_handler.go

Lines 90 to 93 in 4ba6060

 var users []*UserModel 

 if err := tx.SelectContext(ctx, &users, "SELECT * FROM users"); err != nil { 

 return echo.NewHTTPError(http.StatusInternalServerError, "failed to get users: "+err.Error()) 

 }

[Todo]DNSサーバー分割

[Todo] : livestream ranking も毎回全部取ってきてる ( stats )

cache して新しい livestream を ranking に追加していけば良さそう。
ただ、livestream の削除がある場合はだるいのでやらなくてよさそう。

isucon13/go/stats_handler.go

Lines 230 to 233 in 4ba6060

 var livestreams []*LivestreamModel 

 if err := tx.SelectContext(ctx, &livestreams, "SELECT * FROM livestreams"); err != nil && !errors.Is(err, sql.ErrNoRows) { 

 return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livestreams: "+err.Error()) 

 }

[Todo] : livecomment N+1 ( stats ) ( 簡単に直せそう )

かなり簡単に直せそうな N+1。求めたいものがしょぼいからすぐ行けそう。

isucon13/go/stats_handler.go

Lines 153 to 157 in 4ba6060

 for _, livestream := range livestreams { 

 var livecomments []*LivecommentModel 

 if err := tx.SelectContext(ctx, &livecomments, "SELECT * FROM livecomments WHERE livestream_id = ?", livestream.ID); err != nil && !errors.Is(err, sql.ErrNoRows) { 

 return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livecomments: "+err.Error()) 

 }

[Todo] : 画像 hash column 追加

[Todo] : searchLivstreams が N+1 2つあり

N+1 が 2つくらいあるかも。alp の上から3番目 ( /api/livestream/search ) なので重要度高目。

isucon13/go/livestream_handler.go

Lines 202 to 209 in 444036d

 for _, keyTaggedLivestream := range keyTaggedLivestreams { 

 ls := LivestreamModel{} 

 if err := tx.GetContext(ctx, &ls, "SELECT * FROM livestreams WHERE id = ?", keyTaggedLivestream.LivestreamID); err != nil { 

 return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livestreams: "+err.Error()) 

 } 

 livestreamModels = append(livestreamModels, &ls) 

 }

isucon13/go/livestream_handler.go

Lines 226 to 233 in 444036d

 livestreams := make([]Livestream, len(livestreamModels)) 

 for i := range livestreamModels { 

 livestream, err := fillLivestreamResponse(ctx, tx, *livestreamModels[i]) 

 if err != nil { 

 return echo.NewHTTPError(http.StatusInternalServerError, "failed to fill livestream: "+err.Error()) 

 } 

 livestreams[i] = livestream 

 }

※ 2つ目は fillLivestreamsResponce に Select がある為 N+1

seiei-n / isucon13 Goto Github PK

isucon13's People

Contributors

Watchers

isucon13's Issues

[Todo]PowerDNS周りの最適化

[Todo] : moderateHandler 謎に全部取ってきてる問題

[Todo]icon静的配信

[Todo] : rank 算出 N+1

[Todo]DNSサーバー分割

[Todo] : livestream ranking も毎回全部取ってきてる ( stats )

[Todo] : livecomment N+1 ( stats ) ( 簡単に直せそう )

[Todo] : 画像 hash column 追加

[Todo] : searchLivstreams が N+1 2つあり

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	for _, ngword := range ngwords {
	// ライブコメント一覧取得
	var livecomments []*LivecommentModel
	if err := tx.SelectContext(ctx, &livecomments, "SELECT * FROM livecomments"); err != nil {
	return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livecomments: "+err.Error())
	}

	var users []*UserModel
	if err := tx.SelectContext(ctx, &users, "SELECT * FROM users"); err != nil {
	return echo.NewHTTPError(http.StatusInternalServerError, "failed to get users: "+err.Error())
	}

	var livestreams []*LivestreamModel
	if err := tx.SelectContext(ctx, &livestreams, "SELECT * FROM livestreams"); err != nil && !errors.Is(err, sql.ErrNoRows) {
	return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livestreams: "+err.Error())
	}

	for _, livestream := range livestreams {
	var livecomments []*LivecommentModel
	if err := tx.SelectContext(ctx, &livecomments, "SELECT * FROM livecomments WHERE livestream_id = ?", livestream.ID); err != nil && !errors.Is(err, sql.ErrNoRows) {
	return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livecomments: "+err.Error())
	}

	for _, keyTaggedLivestream := range keyTaggedLivestreams {
	ls := LivestreamModel{}
	if err := tx.GetContext(ctx, &ls, "SELECT * FROM livestreams WHERE id = ?", keyTaggedLivestream.LivestreamID); err != nil {
	return echo.NewHTTPError(http.StatusInternalServerError, "failed to get livestreams: "+err.Error())
	}

	livestreamModels = append(livestreamModels, &ls)
	}

	livestreams := make([]Livestream, len(livestreamModels))
	for i := range livestreamModels {
	livestream, err := fillLivestreamResponse(ctx, tx, *livestreamModels[i])
	if err != nil {
	return echo.NewHTTPError(http.StatusInternalServerError, "failed to fill livestream: "+err.Error())
	}
	livestreams[i] = livestream
	}