segment-integrations / analytics.js-integration-amplitude Goto Github PK

The options declared here - https://github.com/segment-integrations/analytics.js-integration-amplitude/blob/master/lib/index.js#L35-L37 are never actually set on the Amplitude library.

We should set them when we initialize the library here https://github.com/segment-integrations/analytics.js-integration-amplitude/blob/master/lib/index.js#L54-L57.

If I enable trackAllPages and then fire .page with a named page it ends up sending two events to amplitude. This is because the page event does not return after firing the first. Is this behavior expected?

For example:

If my configuration has:

        "Amplitude": {
          apiKey: "[blah]",
          trackAllPages: true,
          saveEvents: true,
          includeUtm: true,
          includeReferrer: true,
          includeGclid: true,
          saveParamsReferrerOncePerSession: false,
          domain: "." + document.location.host
        },

And I call analytics.page('test')

The code first hits https://github.com/segment-integrations/analytics.js-integration-amplitude/blame/master/lib/index.js#L125

  // all pages
  if (opts.trackAllPages) {
    this.track(page.track());
  }

This sends an event to amplitude with event_type: "Loaded a Page" (per what's in analytics.js)

and then gets to https://github.com/segment-integrations/analytics.js-integration-amplitude/blob/master/lib/index.js#L134

  // named pages
  if (name && opts.trackNamedPages) {
    this.track(page.track(name));
  }

Which then sends another event to amplitude with the event_type: "Viewed test Page"

Would it make more sense to have the trackAllPages add the name or category if present and return? e.g.

  // all pages
  if (opts.trackAllPages) {
    if(category){
      return this.track(page.track(category));
    }
    if(name){
      return this.track(page.track(name));
    }
    return this.track(page.track());
  }

Kind of gross, I know.

Currently at 2.1.0, a PR came in to bump it to 2.2.0, but needs to not pull in a gzipped version and testing needs to be done to ensure it'll work.

More details here: 5f420f7