security-dockerfiles / beef Goto Github PK

Hi ! I used the latest built image from dockerhub that works very well 👍however it seems it cannot be built anymore, some ruby dependency crashing. Sorry I cant help any further I'm no ruby expert :/

How to reproduce

Try to build the image, see logs

the example start script tries to set the username to login, but this does not work - the username to use still is "beef".

docker run -itd \
           --name=beef \
           -p 3000:3000 \
           -p 6789:6789 \
           -p 61985:61985 \
           -p 61986:61986 \
           -e BEEF_USER=customuser \   <=== this has no effect
           -e BEEF_PASSWORD=custompassphrase \
           ilyaglow/beef

Not a big think - just wanted to let you know.

Thanks for the working dockerfile!

It seems that the therubyracer issue with libv8 gem became irrelevant, so I can migrate to alpine-based ruby.

The current base image candidate is ruby:2.3-alpine.

Thanks for this nice image :)

The random password generation feature is a nice addition!
But I just noticed that a new password is generated every time the container is re-started (docker restart beef) and displayed in the console. However it is not changed in the config file because the default "beef" value is not present anymore:

Two options:

1. do not re-generate password if already changed
2. properly reset in the config file

Having a new, new password is annoying (since the previous one was already strong and random) so I'll suggest soon a PR for 1.