sebgroup / seb-pictograms Goto Github PK

Hello,
SEB Baltic Web team started to work on new content management system Drupal 8, where all the pictograms can be placed just by using their names from provided list in https://designlibrary.sebank.se/resources/pictograms/
So for example if I need pictogram called „cargo-cart“, I would like to be able to copy it‘s name directly from the list by marking the name "cargo-cart" with my mouse and Ctrl+C, without pressing on it (when it opens details and code part, which should be used and it could be copied only from there). And if you want to copy the name of icon which is on the very bottom of the list (for example triangle-small), then you press on it, you also need to scroll up to see this information and be able to copy it.
Is it possible to make these texts near pictograms in the list copyable? 😊

Hi, I noticed that you got an error when you tried to publish to npm using semantic release.

You have to add the following to your package.json in order to publish to an organization:

"publishConfig": {
    "registry": "https://registry.npmjs.org/",
    "access": "public"
  },

See complete example:
https://github.com/sebgroup/fonts/blob/master/package.json

The registry part isn't really necessary but it's useful if you've configured another default registry locally.

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Missing package.json file.

A package.json file at the root of your project is required to release on npm.

Please follow the npm guideline to create a valid package.json file.

Good luck with your project ✨

Your semantic-release bot 📦🚀

Svg file sizes could be reduced by optimizing them with something like: https://jakearchibald.github.io/svgomg/

Might even be some command line tool for it:)

Description

Please use SVG names instead of arbitrary names with incremental identifiers. It is much easier for users to use, see the examples below:
This is how it can be imported at the moment:

const chatMan: string = require("@sebgroup/seb-pictograms/svg/regular/91-Picto-Regular_black.svg");

This is how I expect it to be imported:

const chatMan: string = require("@sebgroup/seb-pictograms/svg/regular/chat-man.svg");

Rationale

The reason to why I don't use the pictograms as a font is because:

• I don't want to load all svgs just to use one of them. Importing everything as font will cost 27.94 KB while importing the SVG directly cost 901 B.
• Some mobile browsers are design to not load custom fonts when the connection is slow, it will default back to something like Arial which doesn't have the character code provided and it will display an empty box 🔲 instead.

In order to get a nice change log which is updated automatically I'd suggest using commitizen together with commitlint and husky, it's really easy to setup and only takes a few minutes:)

The steps and a brief explanation about the setup can be found here. It will make it easier for others to contribute:D

I had problem with importing in my angular application.
I tried with this:
@import "@sebgroup/seb-pictograms/pictograms.scss" in my style.scss.

This was the error:
"CssSyntaxError: C:\Repos\ApplicationName\node_modules@sebgroup\seb-pictograms\pictograms.scss:7:9: Can't resolve 'fonts/seb-pictograms.svg' in 'C:\Repos\ApplicationName\src'".

Hi just out of curiosity, what's the goal and purpose of this library? Is it for the pictograms?

Since we'll be publishing using CI directly from master it should be protected and we should only allow members to merge to master from develop branch after pull request has been reviewed.

As long as this repository is private it's no real issue but we should make it public and nevertheless it's good practice to use some sort of branching strategy. I can recommend this article which a lot of teams are using: https://nvie.com/posts/a-successful-git-branching-model/