Comments (3)
yousifalraheem
commented on September 25, 2024
We do formatting before committing but we are using VSCode formatter not prettier, that's why when you run prettier you find a lot of changes appearing. However, I think we should set up prettier how we want it to look like and configure precommit to run prettier and add the changes so that the process is automatic. I'll tag this issue as an enhancement.
from react-components.
EldRoos
commented on September 25, 2024
You are doing manual formatting? Or some automatic one? If it is automatic I don't think it is that good as for example sometimes use "..." and sometimes '...'.
What parts of formatting in https://github.com/sebgroup/react-components/pull/109/files did you not like? And think through if it is only your subjective view or if most think so.
For example I never start a line with +, I end them with it. Even when I didn't use a beautifier.
from react-components.
sebopensource
commented on September 25, 2024
🎉 This issue has been resolved in version 3.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from react-components.
Related Issues (20)
- Datepicker fires onChange on render HOT 2
- Tooltip content blocking other components when it's not active HOT 1
- Modal keyup listener has undefined reference HOT 2
- Datepicker maxDate validation bug? HOT 1
- Dropdown select all checked by default if it's set to multiple HOT 2
- `AccordionItem.onToggle` not trigger when clicked HOT 1
- Bullet point (update)
- Update bootstrap HOT 1
- Update button colours
- Update error colour
- New feature for the date picker: range selector
- Update design for Pagination HOT 1
- Fails to bundle react-component with react-scripts v5 HOT 1
- Module federation
- New component: Toolbar
- New component: Tab navigation HOT 1
- Change "Dark Green 2" to #308800
- Textbox component 'reference' not passing down to input props. HOT 2
- Multiple Dropdown not working in docs
- Unable to input datepicker via keyboard when min date is configured
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-components.