Comment parsing of config_initialize.txt does not allow #-preceding whitespace. about buildscripts HOT 4 OPEN

Yup. If there's a comment line starting with whitespace in config_initialize.txt, then initialize.py will behave badly (e.g. git clone ... # etc etc), resulting in Git error messages.

from buildscripts.

We indeed designed the scripts to only take full-line comments, and the comment line must start with the hash sign. Part of the rationale is that branch names etc. might include hash signs, e.g. fix-argparse-#170, and we didn't want to consider and write tests for potentially dozens of edge cases.

However, 👍 for actually trying it out.

from buildscripts.

Such things would be unaffected. It's only preceding whitespace that would be stripped - any line that does not have # as its first non-whitespace character would be treated as a non-comment.

from buildscripts.

Right. My point is that this bug report concerns a subset of features we chose not to implement. While #9 implements that sub-feature en passant, I would not necessarily advertise this as a new feature for its own sake.

from buildscripts.