seanpdoyle / ember-cli-rails-assets Goto Github PK

Include EmberCLI-generated JavaScript and CSS stylesheet tags in your Rails layouts

License: MIT License

Ruby 76.68% Shell 3.52% HTML 19.80%

ember-cli-rails-assets's Issues

PR #15 breaks on stylesheets not in the local filesystem

The change from #15 breaks when a stylesheet or javascript file is pointing to a non-local location:

I imagine I could probably put a testcase together to detect this bug, I don't think it is present on 0.6.2 for anyone else who might be running into it after upgrading ember-cli-rails-assets.

media option no longer works for include_ember_stylesheet_tags helper

In order to support certain print stylesheets, we previously added media: all to the helper call, namely "<%= include_ember_stylesheet_tags :client, media: 'all' %>". This no longer works in the >= 0.6.x releases, and fails with:

ActionView::Template::Error:
wrong number of arguments (2 for 1)

If I understand the problem, we need to be able to specify a media option similar to the prepend option that was added, so that print stylesheets continue to function.

Requiring <base> tag affects whole page

Adding a <base href="/"> tag to <head> affects relative URLs for the whole page. This includes breaking SVG <defs> fill URLs and <a href="#top"> style page anchors as well. This seems like an unacceptable side effect when the goal is only to have an absolute URL for the Ember asset paths.

Would it be possible to just add a secondary argument to include_ember_script_tags() to pass in the base path?

Unable to use CSS files that are more than one level deep in the assets folder

We have a CSS file in the public directory at the following path:

assets/font-awesome/css/font-awesome.css

In the index file it's referenced as:

<link rel="stylesheet" href="assets/font-awesome/css/font-awesome.min.css" />

This was failing because of the new code here that eagerly grabs all the CSS files:

ember-cli-rails-assets/lib/ember_cli/assets/asset_map.rb

Lines 25 to 28 in 8c42df5

 Nokogiri::HTML(index_html.read).css('link[rel="stylesheet"]').map {|s| 

 filename = File.basename(s['href']) 

 asset_matching(/#{Regexp.escape(filename)}\z/) 

 }

However, when it gets here, it fails, because the file isn't in the asset map. The DirectoryAssetMap right now only looks at children and not the full tree.

https://github.com/seanpdoyle/ember-cli-rails-assets/blob/master/lib/ember_cli/assets/asset_map.rb#L36

I submitted a PR here: #23

Please release a new version

Any released versions of ember-cli-rails-assets don't work with Rails 7.
To work with Rails7, #14 is required.

@seanpdoyle
Could you release a new version?
If you add me to GitHub / RubyGems collaborator, I'll do it.

seanpdoyle / ember-cli-rails-assets Goto Github PK

ember-cli-rails-assets's Issues

PR #15 breaks on stylesheets not in the local filesystem

media option no longer works for include_ember_stylesheet_tags helper

Requiring <base> tag affects whole page

Unable to use CSS files that are more than one level deep in the assets folder

Please release a new version

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	Nokogiri::HTML(index_html.read).css('link[rel="stylesheet"]').map {\|s\|
	filename = File.basename(s['href'])
	asset_matching(/#{Regexp.escape(filename)}\z/)
	}