se3000 / better_receive Goto Github PK

View Code? Open in Web Editor NEW

17.0 17.0 1.0 249 KB

A more assertive mock.

License: MIT License

Ruby 100.00%

better_receive's People

Contributors

Stargazers

Watchers

Forkers

joemoore

better_receive's Issues

better_receive is recognizing the "delay" method added by DelayedJobs gem

Test

    it "should upload a project to s3" do
      project = Project.new(title: "foo")
      project.better_receive("delay").with("upload_to_s3")
      project.save
    end

Implementation:

    after_save :queue_upload_to_s3

    private
    def queue_upload_to_s3
      self.delay.upload_to_s3
    end

Gemfile:

gem 'delayed_job_active_record', '4.0.0.beta2'

Error Message

    1) Project after_save should upload a project to s3
    Failure/Error: project.save
    NoMethodError:
       undefined method `delay' for #<Project:0x007f87ec634ea0>

undefined method `__mock_proxy' with Rspec 2.14.x

When running specs with BetterReceive and Rspec 2.14+, I get the following error:

NoMethodError:
       undefined method `__mock_proxy' for Object

Upon investigation, it appears that with v2.14 of Rspec Mocks, the entire mocking API has been rewritten, and the __mock_proxy method, is indeed missing. In fact, there doesn't appear to be a suitable alternative at all (though my understanding of the mocks code is limited).

Are there plans to upgrade BetterReceive to be compatible with RSpec 2.14?

Wrong number of arguments using better_stub with any_instance in RSpec 2.14.6

After upgrading from RSpec 2.14.5 to 2.14.6, a spec that used better_stub with any_instance started failing with an argument error: "wrong number of arguments (1 for 2..3)".

This could be an issue with RSpec, but changing to a standard stub worked just fine, so I'm wondering if they changed an internal interface that BetterReceive was depending on.

Here's the full backtrace from the spec failure:

 Failure/Error: described_class.project_all_goals!('foo')
 ArgumentError:
   wrong number of arguments (1 for 2..3)
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/proxy.rb:97:in `add_stub'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/stub_chain.rb:17:in `create_message_expectation_on'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/chain.rb:47:in `playback!'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/message_chains.rb:46:in `block in playback!'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/message_chains.rb:46:in `each'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/message_chains.rb:46:in `playback!'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/recorder.rb:114:in `playback!'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-mocks-2.14.4/lib/rspec/mocks/any_instance/recorder.rb:191:in `available'
 # ./lib/guide_me/goal_projector.rb:22:in `block in project_all_goals!'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/activerecord-3.2.15/lib/active_record/relation/delegation.rb:6:in `each'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/activerecord-3.2.15/lib/active_record/relation/delegation.rb:6:in `each'
 # ./lib/guide_me/goal_projector.rb:21:in `project_all_goals!'
 # ./spec/lib/guide_me/goal_projector_spec.rb:18:in `block (3 levels) in <top (required)>'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example.rb:237:in `instance_eval'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example.rb:237:in `instance_eval'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/hooks.rb:21:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/hooks.rb:85:in `block in run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/hooks.rb:85:in `each'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/hooks.rb:85:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/hooks.rb:446:in `run_hook'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:345:in `run_before_each_hooks'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example.rb:294:in `run_before_each'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example.rb:113:in `block in run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example.rb:254:in `with_around_each_hooks'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example.rb:111:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:390:in `block in run_examples'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:386:in `map'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:386:in `run_examples'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:371:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:372:in `block in run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:372:in `map'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/example_group.rb:372:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/command_line.rb:28:in `block (2 levels) in run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/command_line.rb:28:in `map'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/command_line.rb:28:in `block in run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/reporter.rb:58:in `report'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/command_line.rb:25:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/runner.rb:80:in `run'
 # /Users/adam/.rvm/gems/ruby-2.0.0-p247@abacus/gems/rspec-core-2.14.6/lib/rspec/core/runner.rb:17:in `block in autorun'

Let me know if you need anything else.

Rspec 3.1 compatibility

Rspec 2 uses APIs that are deprecated in Rails 4.2. This is fixed in Rspec 3.1 but better_receive is tied to 2.1

Cannot use better stub on a private method

I have a case where stub works with a private method, but better_stub does not.

In my specs

subject.respond_to?(:private_method) => false

but

subject.private_methods.grep /private_method/ => true

and

subject.respond_to?(:private_method, true) => true

License missing from gemspec

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.