scylladb / dpdk Goto Github PK

/*

• Sort the hugepg_tbl by physical address (lower addresses first on x86,
  • higher address first on powerpc). We use a slow algorithm, but we won't
  • have millions of pages, and this is only done at init time.
    */
    But we can be better by other sort function.

when running the pdump getting the following error
my system config
hardware= dell poweredge r730
CPU= dual socket (xeon e5 2697a)
OS=CentOS 7
dpdk version=16.11.1
interface getting traffic=port0
NIC=intel x710 DA/SFP+
hugepage size=1G
number of hugepage=16
error copy

[root@localhost pdump]# ./dpdk-pdump -- --pdump 'port=0,queue=*,rx-dev=test.pcap'
EAL: Detected 64 lcore(s)
EAL: Probing VFIO support...
EAL: cannot connect to primary process!
EAL: VFIO support could not be initialized
EAL: WARNING: Address Space Layout Randomization (ASLR) is enabled in the kernel.
EAL: This may cause issues with mapping memory into secondary processes
EAL: PCI device 0000:83:00.0 on NUMA socket 1
EAL: probe driver: 8086:1572 net_i40e
EAL: PCI device 0000:83:00.1 on NUMA socket 1
EAL: probe driver: 8086:1572 net_i40e
EAL: no driver found for net_pcap_rx_0
EAL: Driver cannot attach the device (net_pcap_rx_0)
EAL: Error - exiting with code: 1
Cause: vdev creation failed:create_mp_ring_vdev:736

Getting the below compilation issue.

[root@vm7 dpdk-master]# make config T=x86_64-native-linuxapp-gcc && make
make[3]: Nothing to be done for `depdirs'.
Configuration done
== Build lib
== Build lib/librte_compat
== Build lib/librte_eal
== Build lib/librte_eal/common
== Build lib/librte_eal/linuxapp
== Build lib/librte_eal/linuxapp/igb_uio
CC [M] /home/pradeep/code/dpdk-master/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.o
In file included from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/kernel.h:11,
from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/cache.h:4,
from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/time.h:4,
from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/stat.h:18,
from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/sysfs.h:20,
from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/kobject.h:21,
from /usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/device.h:17,
from /home/pradeep/code/dpdk-master/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:27:
/usr/src/kernels/3.10.0-693.17.1.el7.x86_64/include/linux/log2.h:22:1: error: ignoring attribute ‘noreturn’ because it conflicts with attribute ‘const’ [-Werror=attributes]
int ____ilog2_NaN(void);
^~~
cc1: all warnings being treated as errors
make[8]: *** [/home/pradeep/code/dpdk-master/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.o] Error 1
make[7]: *** [module/home/pradeep/code/dpdk-master/build/build/lib/librte_eal/linuxapp/igb_uio] Error 2
make[6]: *** [sub-make] Error 2
make[5]: *** [igb_uio.ko] Error 2
make[4]: *** [igb_uio] Error 2
make[3]: *** [linuxapp] Error 2
make[2]: *** [librte_eal] Error 2
make[1]: *** [lib] Error 2
make: *** [all] Error 2

Users trying to compile scylladb with dpdk enabled will fail if their version of glibc is >=2.25 with the following error:

dpdk/lib/librte_eal/linuxapp/eal/eal_pci_uio.c:134:8: error: implicit declaration of function ‘makedev’ [-Werror=implicit-function-declaration]
  dev = makedev(major, minor);
        ^
dpdk/lib/librte_eal/linuxapp/eal/eal_pci_uio.c:134:2: error: nested extern declaration of ‘makedev’ [-Werror=nested-externs]
  dev = makedev(major, minor);
  ^
cc1: all warnings being treated as errors

This is due to the following change in glibc:

* The inclusion of <sys/sysmacros.h> by <sys/types.h> is deprecated.  This
  means that in a future release, the macros “major”, “minor”, and “makedev”
  will only be available from <sys/sysmacros.h>.

The fix is to #include <sys/sysmacros.h> in the dpdk/lib/librte_eal/linuxapp/eal/eal_pci_uio.c file :)

I'm not submitting a PR because I've seen that you plan on upgrading your copy of dpdk wrt gcc-6 support, but if you want one just ask ;)

Meanwhile I will maintain a patch on Gentoo packaging for this until this issue is closed.