scripting / concord Goto Github PK

Not much to add really! A lot of users (sadly) will simply not know that other browsers exist.

I really wish the arrow key interaction with the outliner structure mirrored the Windows Explorer folder interaction.

• On a parent outline - right arrow opens the children
• On a parent outline - left arrow closes the children (if they're open)
• If a parent is open - down arrow goes to first child not to the next parent
• On a child - left arrow goes to the parent
• On the first child - up arrow goes to the parent

This form of interaction means you can do all moving around and collapsing / uncollapsing of the tree with only the arrows. It means you don't have to learn any Ctrl + combos. Its making use of one of the fundamental features of the windows so will be familiar to most people already.

Currently in edit mode, pressing up when on a child goes to the parent, but if you're in outline mode then pressing up when you're on the first child doesn't do anything. You have to press left.

This is more of a request ...

I would also be open to trying to implement it myself but would appreciate some pointers.

If you have the following HTML in a Concord Example 1 app v0.5.3 headline:
I love Daytona ability to <a href="http://daytona.scripting.com/?q=drummer&collection=drummeruser">search all my drummeruser</a> files. Currently it finds 173 docs.

When you put your cursor at start of "Currently" and use ctrl-return to split the headline, it will break it at the wrong place 4 characters away at end of "Curr".

Further notes

1. If you put your cursor at start of "Daytona" that ctrl-return breaks it at the right place. That "Daytona" word is before the html code.
2. Merging the split two headlines with ctrl-backspace works in both cases.
3. I originally found this bug while editing in drummer v2.0.14.

If you have the following HTML in a Concord Example 1 v0.5.3 headline:
<img src="img_girl.jpg" width="500"><img src="img_girl2.jpg" width="500">

When you go into Concord render mode the second IMG tag will have all attributes deleted.
<img src="img_girl.jpg" width="500" &gt;&lt;img="">

Further notes

1. I previously reported this in DrummerSupport repo as "Show or Hide HTML code in text" deletes attributes in second IMG tag.
2. I confirmed this bug in Concord's Example 1 app given in the README.md.
3. Unfortunately Example 1's Outliner > Toggle Render Mode menu command doesn't work. Console log shows error message toggleRenderMode is not defined. Keyboard command Ctrl-` also didn't work. However, reloading Example 1 webpage, does reload its outline in render mode. Inspecting DOM elements shows the current transfomed content of that headline (with all attributes deleted for the second IMG tag).
4. It appears this bug is related to the bug reported by AndrewSchell concord.escape function img regex shouldn't be greedy.
5. Andrew suggested a change to Line 996 of concord.js that includes new RegExp("<"+tag+"((?!>).+)(/)?>","gi"). It appears that is now at Line 1016 of concord.js.
6. Caveat: I'm more of a poet than a plumber, nowadays.

If you place the bar cursor on a node and press either the page up or page down key, the text of the node is deleted.

Dave, you should probably add a CLA (Contributor License Agreement) to the project if you're considering re-licensing the code in your repository under different terms to different parties. If you haven't gotten your contributors to sign a CLA first then you should get their approval every time you re-license, which may not be possible.

There's another GitHub project that may make it easier to add CLA signatures to the project. I'm haven't tried it out yet, but thought I should pass it along:
http://jayunit.net/2013/01/09/clahub-easy-contributor-agreements-on-github/

Readium has a similar open source strategy, where the repositories are distributed under an open license but proprietary re-licensing is considered on a case-by-case basis. You can read their CLA here:
http://readium.org/licenses/icla

What I did: Copied a link node and pasted it back into another section of an outline. I then changed the "url" attribute of the pasted link node using concordUtils:opSetOneAtt().

What happened: The url of both the pasted node and the original copied node both changed.

What I expected to happen: I expected all attributes of the original copied node to be unaffected by changes to the new pasted node.

Confirmed on: Fargo.io and open source Concord

I've been trying to fit a more powerful keystroke capturer under Concord's keyboard handling code, but I'm ready to debug the resulting code. The problem is that none of the JavaScript key handlers will decode an existing event, they have to actually capture the event and call back to the app. Maybe there's an exception, if such a toolkit exists, that would make the systematization of Concord's keystroke handling simple enough to attempt.

Two examples I've considered -- keypress and hotkeys.

To be clear, what I need is this.

$(document).on ("keydown", function (event) {
   var cmdString = keyboardManager.process (event);
   switch (cmdString) {
     case "uparrow":
        moveCursorUp ();
        break;
     //more cases follow
      })

I get that this is hard to do given the browsers ridiculous model for keystroke handling. This kind of stuff should be baked into the browser. The event should have a string that virtualizes the keyboard. Only a videogame or serious graphics app needs the kind of power in the interface for the keyboard, but we all have to handle all the keys as separate events.

This is a pretty bizzare feature for a component like this to have and I don't see why it should be enabled by default.

What I did:

I have an outline with html tags after an img tag. Ex: <img src="#" /><figcaption>Caption</figcaption>

What I expect to happen:

The < and > signs around figcaption should remain intact. Only the tags for img should be modified.

<img src="#" />&lt;figcaption&gt;Caption&lt;/figcaption&gt;

What happens:

The final > sign around /figcaption is converted to > while the end > of img remains intact.

<img src="#" /&gt;&lt;figcaption&gt;Caption&lt;/figcaption/>

The fix:

The regex on line 996 of concord.js
https://github.com/scripting/concord/blob/master/concord.js#L996

Should change from:
new RegExp("<"+tag+"((?!>).+)(/)?>","gi")

to:

new RegExp("<"+tag+"((?!>).+?)(/)?>","gi")

(see the ? after .+)