Git Product home page Git Product logo

browser's People

Contributors

ali-demirtas avatar bnyro avatar bubu avatar darkherman avatar daywalk3r666 avatar dyras avatar element54 avatar enricomonese avatar futrdevelopment avatar harryheights avatar hellohat avatar islam2hamy avatar jumpingyang001 avatar lakjdf avatar lishoujun avatar m3hdirostami avatar maratbn avatar mutazawadorg avatar olehkopeykin avatar pbui avatar poussinou avatar scoute-dich avatar secangkir-kopi avatar smallg0at avatar smarquespt avatar splinet avatar sykursen avatar t8rin avatar vistaus avatar woheller69 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

browser's Issues

Crash

Hello,
This Browser Is Crash in Bookmark Section When Tap on Toolbar.
And Can You Add Night mode In Browser.
and A user can save bookmark On browsers homescreen.
and remove github page and Use a static home page like other browser
or add Inbuilt Download manager
Thanks

[feature request] Dynamic bookmark

Is it possible to implement dynamic bookmark like url for the bookmark should update to last link visited on that particular website?

Tab questions

Is there a way to close a tab? I usually like to close/clear the tab when I'm done browsing the page.

Also, is it possible to set a blank/empty page instead of one of the bookmarks when you open a new tab?

Backup/Restore Fails

GENERAL INFO
————————————————————————————
Galaxy Note 4 SM-N910A Android 6.0.1 API 23
Browser v3.8.1 DL'ed @ XDA, README (master)
————————————————————————————
TROUBLESHOOTING/EXTRA INFO
————————————————————————————
Storage & Location permissions both ALLOWED
App is not password protected
Cache preserved on exit, offline pages enabled
ReadList has items
Bookmarks List has items
No home screen shortcuts
No PassStorage items, but option enabled
————————————————————————————
Hi,

Love this app, but I had an issue backing up my lists. I get an error after clicking that says "Backup failed" or "Restore failed". I'm not sure if this is a new bug introduced with v3.8.x, as it worked fine in earlier versions. Let me know if you need any other info, or want help in testing. I'm happy to assist you in any way I can. Us FOSS Devs have to stick together, right? :-)

P.S. I have verified that the bug is not related to the information I'm about to share, but I have "Disabled" the "Android System Webview" app on my OS. The app still seems to work fine though. Can you comment on how this is possible? And if this might affect the app's performance or not?

Thanks again for being awesome!

  • Tom

Opening Links in Browser from Other Apps

Currently in v3.8.1, clicking a link in another app creates a notification to open list, add to read later, or open in browser (via clicking notification).

Could you change the default behaviour or add an option in settings to let us open the link without going through the notification? Not sure if this is a limitation in WebView or something, but sometimes I click a link 3-4 times because I don't realize the notification appeared. I always expect my default browser to open when clicking a link.

If you don't want to do this, that's cool. It won't keep me from using Browser as my default :)

Feature Request: Intro/Tutorial Screens

It would be helpful to add a slide during the tutorial that showed or told the user how to add sites to the JavaScript Whitelist. Currently the user must have the JavaScript setting turned off, stumble upon the X icon, click it, then notice the changes on the site. It is somewhat ambiguous to less savvy users.

Variety of things that would make this the perfect browser

Just wanted to start off by saying that this is probably the smoothest mobile browser I've ever used. I'd love to use this as my main browser, but there's a couple issues I have that is preventing me from doing so.

Issue 1: Lack of search suggestions when typing in URL's. Most browsers I've used have Google search suggestions enabled which makes it a lot easier to navigate to the websites you want. Also, most browsers learn the websites you go on most and display a few right before you start typing, which is extremely convenient.

Issue 2: The search box is weirdly laid out. For example, I've been constantly hitting the URL at the bottom of the browser thinking it's the URL search, when it's actually the tabs manager. I find it really weird to have to press the small magnified glass in order to search. In my opinion, the search bar should be where the URL is and the tabs manager should be where the magnified glass is.

Issue 3: The cookies setting should be more clear. There are 4 options for cookies, but it doesn't make any sense. The first option is accept cookies, when it should say accept first-party cookies only. There should only be three options here; accept cookies, accept cookies except 3rd party, and block cookies. I mean, why would someone want to accept third party cookies only? Makes no sense.

Issue 4: The notification shade when browsing stays green, when it should be black. It's not a big issue, but it would look nicer if it was consistent with the norm.

Issue 5: I noticed the browser keeps reloading and going back to the homepage (which is this Github). Even when I'm on a website (Reddit, for example) then go into the browser settings and go back to the browser itself, it reloads back to the homepage. Also, does this browser have history? Because I can't find it anywhere and it just reloads everytime I close the browser.

Again, this is a super smooth browser that I'd LOVE to use provided these things are sorted out. I know it's a relatively new browser, and I'm sure it'll only get better with time. Having said that, I will gladly donate if these issues are sorted out.

Restore the option to show non-mobile version of site

Being able to switch to non-mobile version of a site is the only usable feature of Android stock browser (some mobile sites have limited usability or are just to intuitive to be used by humans). Unfortunately it's latest versions require unacceptable set of permissions, so it is no longer usable as failback and i was glad to find this feature in your browser. Seeing it gone now is great dissapointment. Is it possible restore it? This feature was the reason i installed it.

Restart app to apply changes appears even when nothing changes

In settings,
The pop-slide-up "Restart app to apply changes" occurs on click instead of on setting changed.

For example as soon as you click on Theme option the pop-up appears, before you select anything.
So, even if you click back button, the pop-up is there

Also, another example - if you click a checkbox, i.e. App settings | Swipe, and then click again to uncheck it, pop up appears even though technically it shouldn't because nothing changed.

Tie together passStorage and bookmarks

Suggestions:

  1. When adding a domain to passStorage automatically add a bookmark to that domain at the same time.

  2. When you visit that domain, whether by clicking from the passStorage tab or from the bookmarks tab, open the copy username prompt.

  3. Add a cancel option ( x or 'cancel') to the username prompt to dismiss it if not needed (for example on sites that usually keep you logged in).

  4. Auto-dismiss the prompt if you leave that domain.

Large browser fingerprint

The large fingerprint of Browser (run the test on https://panopticlick.eff.org) does not offer good tracking protection.

It would be nice if there was also the option of choosing a more common user agent (like one can choose between a desktop or mobile user agent now) as well as a possibility to use the same HTTP_accept headers as Tor Browser.

I don't know how easy it is to do anything with the canvas and WebGL fingerprint hashes. Brave's Fingerprinting Protection Mode might be helpful.

Update status bar title when tab is closed

Right now if you hit x to close a tab and the default page is about: blank, the status bar still shows the previous website title. It should update to empty.

Also, is there a way to make the default page when a tab is closed be the bookmarks page?

Crash when set to open bookmark tab on startup

  • Install app
  • Visit one site, save to bookmarks
  • Change settings to show bookmark tab on startup

App will now immediately crash on startup until you clear app data from Android app info menu.

Thanks!

Edit: Version 4.1 installed from F-Droid

Edit 2: same crash occurs when any of the tabs other than the default selected from the on-startup setting.

Background Links Enhancements

Sometimes, when you're in another app and opening multiple links in the background, it's hard to tell if you actually clicked a link (after the first one), since there is only one notification in the status bar. A toast notification would ease my mind in knowing that I clicked the link and Browser registered it.

Also, since Marshmallow combines these notifications into one, if I click the notification when there are multiple background links, Browser will only open the last one. I'm not sure what the best approach here would be. Maybe if you click the notification, Browser can open each link in a different tab? But then you risk the chance of losing a link if you have more than 5. Or maybe remove the 5 tab restriction? Or maybe not group the notifications? I'm not sure, what do you think?

Image format extension ignored & svg-format not downloadable

Hi,

Is there a possibility to preserve the filename extension of images? Saving imagefiles leads to renaming with the following pattern: yyyy-mm-dd_hh-mm-ss.jpg. The suffix jpg is always replacing the original extension.

How to reproduce:
Step 1: Open link: https://upload.wikimedia.org/wikipedia/commons/e/e6/Walking_baby_tux.gif
Step 2: Long press loaded image.
Step 3: Press "Save image" in pop-up menu.
Step 4: Image will be saved with wrong extension.

I see this issue with png-, gif-, bmp- and webp-files.

I also noticed a possible issue with svg-imagefiles. It seems not possible to save those images.

How to reproduce:
Step 1: Open link: https://upload.wikimedia.org/wikipedia/commons/b/b0/NewTux.svg
Step 2. Long press loaded image. No pop-up menu appears with "Save image".

Additional Infos:

  • Device model: GT-I9505
  • Android version: 7.1.1
  • Browser version: 3.5

Best regards.

Crashing - Android 5.x.x

On Android 5.x.x app crashes after inro.
java.lang.NullPointerException: Attempt to invoke virtual method 'int android.graphics.Paint.getAlpha()' on a null object reference
at android.graphics.drawable.NinePatchDrawable.draw(NinePatchDrawable.java:250)
at android.graphics.drawable.LayerDrawable.draw(LayerDrawable.java:517)
at android.widget.ProgressBar.drawTrack(ProgressBar.java:1669)
at android.widget.ProgressBar.onDraw(ProgressBar.java:1636)
at android.view.View.draw(View.java:15247)
at android.view.View.updateDisplayListIfDirty(View.java:14183)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.updateDisplayListIfDirty(View.java:14178)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.updateDisplayListIfDirty(View.java:14178)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.updateDisplayListIfDirty(View.java:14178)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.updateDisplayListIfDirty(View.java:14178)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.updateDisplayListIfDirty(View.java:14178)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.updateDisplayListIfDirty(View.java:14178)
at android.view.View.getDisplayList(View.java:14205)
at android.view.View.draw(View.java:14975)
at android.view.ViewGroup.drawChild(ViewGroup.java:3406)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:3199)
at android.view.View.draw(View.java:15250)
at android.widget.FrameLayout.draw(FrameLayout.java:598)
at com.android.internal.policy.impl.PhoneWindow$DecorView.draw(PhoneWindow.java:2906)
at android.view.View.updateDisplayListIfDirty(View.java:14183)
at android.view.View.getDisplayList(View.java:14205)
at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:273)
at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:279)
at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:318)
at android.view.ViewRootImpl.draw(ViewRootImpl.java:2536)
at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:2352)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1982)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1061)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:5891)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:767)
at android.view.Choreographer.doCallbacks(Choreographer.java:580)
at android.view.Choreographer.doFrame(Choreographer.java:550)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5294)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:102)

strange notification behavior

Thanks for your great work on this app! It's pretty hard to find a decent web browser on f-droid but yours is already pretty amazing. It's also nice that you keep maintaining it!
However, I noticed a strange notification behavior when opening a website from another app through your browser: A notification shows up on top of the status bar but there is no text in it and there is no way to tap on it. You have to wait for it to disappear, swipe down the notifications and tap on it after it disappeared. You can see what it looks like for me on the picture attached. I also noticed that the notification draws over the status bar for different amounts of time depending on the device I use.
Do you think there is a way to fix this or at least have some meaningful text in the notification? ;)

img_20170619_110211

Add "Open as URL" to the search engine menu

Having to prepend "http:"/"https:" to each URL that does not start with "www" is extremely annoying. If making the browser recognize valid domain names is problematic please at least add option to force-open urlbar contents as url instead of searching them (btw: not all valid url's are searchable). A possible place for such override can be the search engine selection menu.

Horizontal scrolling interpreted as gestures

Hi,
I prefer to use gestures for navigation but currently sideways scrolling (for pages wider than the screen) is interpreted as back/forward move as soon as I release the finger. This makes the horizontal scrolling unusable on pages with fixed width.

Regards,

rjc

Questions about Browser

Hello,
Thank-you for this open source web browser.
I have two questions :

  • how return to home page ?
  • if Browser use WebView, the version is different about original web browser (gello). Do you included a WebView gear?
    Thanx for your answers.
    PS : sorry for my english

one tab browser

how to make it to one only one tab?
Mean currently there are five tabs for browsing, but there should be only one tab should be there.
How to restrict other tabs?

[BUG] Pin Protection doesn't protect it at all

Hello!
I've just installed this browser. My purpose was to try it, but then I've seen that it doesn't have tabs xD
Anyway, you've done a great job.

I don't know if it's a known issue, but I thought I should tell you.
So, let's say that I enable PIN Protection.
Next time I open the browser, it'll ask for PIN, but if I press back button or press home button (when it asks for PIN) and then I open the browser, it will not ask for PIN.

Good luck with your project!

Refreshing Page after Removal of Pull-to-Refresh

This is not app-breaking, just a rough edge.

In v3.8.1 you removed the pull-down-to-reload gesture in order to fix a bug that resulted in the inability to scroll back up.

I fully support that fix and believe it should never be re-implemented. However, since the removal of that, there is no browser function to reload a page except for

  1. Changing session settings
  2. Clicking the URL bar and then hitting enter/go (basically re-navigating to the same URL)
  3. Using the history list

Is it possible to do one of the following to restore the refresh/reload functionality?

  • Move the history button to the "Open" menu and place the reload button where it is currently
  • Add a button or icon to the action menu
  • Add a refresh action that becomes visible when the omnibar is in text entry mode (perhaps to the left of the text input field)

If the third option is preferred, perhaps you could have the reload button always be visible on the left of the omnibar. Just a thought.

[Feature Request] Toolbar URL

This is a great browser, I love that you only have the necessary features. There are a few things I would suggest, however.

Currently, the toolbar shows the page title, but it would be nice to have the option of showing the full url. And when clicking the toolbar, it would be nice if it went into edit mode for the url so that you can manipulate/copy the current url. If the full url was highlighted as soon as you click, you could just start typing and therefore keep the current search functionality (think omnibar).

Also, a verification icon or lock icon for https sites would be a nice bonus.

Exiting bug and behavior

Pushing the phone back button several times in a row when trying to exit breaks the 'ok' prompt to exit.

Another issue is that there's no way to force an exit without either switching tabs or going back to the beginning of your history in the current tab.

Perhaps an alternate means to force an exit is to allow long press on the back button to pop up a menu of the current tab history that also includes an exit now button. Similar to how Firefox handles long press of the back button, but including the exit option (no further prompts if that option is chosen).

Hopefully that makes sense!

[Feature Request] Default Search Engine | Google

Hello again!

Been trying to reach you via XMPP, just FYI :)

When searching from the omnibar, if the following are true:

  1. Has Google set as default search engine.
    -or-
  2. Using "quick search" with the Google flag (.G)

The search results page will display/list Google AMP links. I know this is nitpicky, but I'm almost certain everyone hates AMP links because they alter the page URI, address bar, etc.

For instance, linking to the URL in the omnibar while on an AMP page, the link that is copied from the omnibar will be opened as suspicious activity (Google page says this, not browser or modem).

This can be circumvented by using

https://encrypted.google.com/search?q=%s

As the search engine string instead of the default. The results of the search will not display any AMP links.

I know AMP links are allegedly faster, but this browser is already so fast, that I don't believe it will slow anything down. Plus only a random irregular number of results are AMP anyway.

Let me know your thoughts. Thanks again for this app. You are awesome!

Long press on the bottom bar

I don't really understand why the app closes with a long press on the bottom bar. Why not just by hitting back or home like every other app?

Intuitively, I would expect long pressing to copy the current url to the clipboard or something like that.

Can't scroll up

Wants to refresh instead. Tested on latest available from F-Droid on Android 7.0 (CopperheadOS, Nexus 6P).

Some broken tab behaviors

  1. Open a URL in the first tab. Open another URL in the second tab. Now if you long press the bottom bar to get the tab list and use the red X to close the second tab, it will open the 'browser' page on Github. In my opinion this should default to either a blank page or whatever your startup page selection is (e.g. the 'bookmarks' list).

  2. After opening several tabs, the current tab URL is not always correctly populated when you tap the bottom bar. It again often fills in the 'browser' Github page URL instead.

Tab switching when swipe disabled

There seems to be an issue regarding applying settings.
As if I enable Swipe in settings and click restart to apply, sometimes I need to do it twice for it to work.

Also, when Swipe is disabled the arrows, which I saw previously do not appear:

I believe I saw earlier a left and right arrow, which appeared and all of sudden do not appear anymore.

Temporary hide arrows?

I am currently testing latest release, and I saw them in this release, but now they do not come up.

Also, I do not see anymore the tab switcher at the bottom, is it disabled?

Location prompted when set to allow

I'm not sure if it's a universal issue or just with Google news (news.google.com) but every time I visit the site I'm prompted for location access permission when I have it set in the startup settings to allow.

(Also happens at fredmeyer.com)

Change tot blank page on new tab

At the moment new tab will bring you to the Github page.

It would be easier on possible data charges; for instance.

Please consider changing to a blank page on new tab.

The start tab option only specifies the first tab loaded on application start.

Theme not completely applies

Theming does not really apply at the moment.
I selected dark theme, grey|grey, but still theme is quite white:
Dialogs

Tabs and Menu

Settings pop-up

Settings

Search pop-up

About page

Having theme apply across all areas would be amazing

Omnibar Covers Page: Fullscreen[Hide Nothing]

Version 3.8.1

Steps:

  1. Set option to hide status bar, omnibar, both, or nothing to "Hide nothing"
  2. Navigate to a page with links in the footer or bottom of the page.
  3. Scroll all the way down until stopped

Here's a site you can use: https://www.eff.org/

Notice the "All Updates" button is partially covered.

History does not get cleared on exit

The "clear history on exit" option does not work. In fact, if I reopen the browser after having exited it, the history is still present. I exit the browser by clicking the back button and answering "ok" to the question "Do you want to exit?".

keyboard doesnt show in landscape

I'm new to GitHub so I don't know what the hell I'm doing. but i;ve been playing around with the source code and got the keyboard to show in landscape but it wasn't showing before. also I put adblock and a request desktop that works in and removed a few things too. My question is is that ok? I mean can I continue developing my own version of this or am I supposed to not do that? I just don't want to do the wrong thing.

*not a bug* for our thumbs, a scroll down button would be a great addition

Its up to you if it should be two buttons which are permanent with perhaps a toggle in settings or if the button should only appear when the browser is looking at the top of the page, should you decide to adopt this suggestion. This is my first issue. I hope im posting my suggestion in the right place. great browser imho btw! Thanks. Repetitive motions are taking a toll on my thumb.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.