scottweinstein / gulp-war Goto Github PK

Hey, can you please add me to npm management of this package? I'd like to update it in npm repo as well, but I don't have sufficient permissions. My npm username is: tromax.

You can't get the latest version from npm

If you invoke gulp war to compress target folder to war file existing web.xml file if overriden by new web.xml.

I'm suggesting that in options there should be a option to skip creating web.xml.
Something like
options.skipWebXml which default would be false.

did you maybe already create it ?

Currently the war contains an entry for META-INF but this creates a zero length file when piped to any recent version of gulp-zip. It is created by the line:

this.emit('data', new File({path: 'META-INF/', contents: new Buffer('')}));

gulp-zip currently only creates an empty directory if it is finds a file with null contents and stats.isDirectory() returning truthy. Changing the above line to:

this.emit('data', new File({
            path: './META-INF',
            stat: {
                isDirectory: function () {
                    return true;
                }
            }
        }));

resolves the issue.

N.B. this work with gulp-zip 2.x and 3.x but causes neither a file nor a directory to be created with gulp-zip 1.0.0,