scottlogic / finput Goto Github PK

https://github.com/alisd23/finput/blob/master/src/valueHistory.js#L59

If I select 6,000,000 and hit the letter K, I expect the value to be 1,000 rather than 6,000,000,000.
When you have an entire selection, the native behaviour is to replace that selection with whatever value is entered.

Reproduction Steps:

1. Enter 6m into input
2. select all the text in the input
3. hit the letter 'k'
4. notice that the shortcut adds to the current number.

When I attempt to insert a pound symbol (shift key + number 3) the number 3 is inserted into the input field.

Instead, nothing should be entered into the input field as the £ key is invalid.

This is also the case for other shift-key related special characters

It would be nice to get the E2E tests running on various browsers, using browserstack

Some users do not want the field to select the entire text on focus, provide a configuration option to turn this behaviour off

At the moment we use a combination of grunt and npm scripts. Might be nicer to have a consistent approach so we only need to use one command line tool when developing testing (see running tests).

• Example
• Description
• Quick Start (Usage?)
• Documentation
• Testing (and browser stack logo)

When i focus in on the input field and press f5 my refresh is blocked since preventDefault blocks all keypresses rather than just ones that would affect the field value.

https://github.com/semantic-release/semantic-release

See d3fc for an example

typing at this point should cause the highlighted text to be deleted and replaced by whatever is typed

E.g. currently missing GitHub details

E.g.
k => 000
m => 000000
b => 000000000

See title...

Would give more appropriate on-screen keyboard, if the component user specified that on the input. Or use the step attribute for the up/down arrow native behaviour.

However, that type doesn't support selections so at the moment it gives an error.

When entering digits into particular numbers, the caret position is shifted to an incorrect location.

Example

1. Enter 123456 into input
2. move caret to 123|,456
3. Enter number
4. Notice that the caret is now behind that number

Note: | symbolises caret position

Just a simple getting started and the API from #21.

Rather than callbacks

Can we get a new build including #35 released to npm plz?

I think this is because we manually check to see if ctrl key is pressed before preventing defaults.

When fixing this we should look at the 10 tests that fail on macOS. They all specify the use of the ctrl key. I guess we either need to select modifier key based on the OS or come up with a more generic way to do this (use right click menu?).

Specifically Android 7.1.1

Steps to reproduce:

1. Go to here
2. type in lots of numbers (more than can fit in the input box)
   When typing lots of numbers the caret goes out of the users view

The amount control should support cut/copy/paste actions by the user.

Requirements:

• Pasting invalid input into the control should not be allowed (e.g. sdfsfa)
• Pasting valid input into the control should reformat the number
• Pasting shortcuts into the control should be supported (e.g. 1m, 1k)
• Cutting from the amount control should reformat the number

Some feedback needs to be given when the user is blocked from adding invalid input.

Possibly a very small vertical/horizontal shake? Some investigation will be needed to see what other things out there do!

It would be nice if there was a manual function call to allow for setting of options at a later date, without having to tear down and recreating a finput. This would be useful if, for example, you are displaying an amount in relation to a currency pair (so the number of decimals is pertinent). If the user then changes a currency pair, this could result in the number of decimals needing to be changed.

A simple setOptions would suffice :)

I want to enter 12
I press 1
The input formats immediately, resulting in "1.00" with the cursor at the end

In Chrome/FF, formatting only happens when I leave the field.

Steps to reproduce:

1. Enter 1.1m
2. Blur from the field to allow it to format
3. Select the second 1 digit
4. Drag it to the end of the input
5. Notice that the input now shows 100,000.00, i'd expect 1,000,000.01

Some clients wish to observe when the user attempts to add an invalid character into finput.
An API endpoint should be exposed to allow clients to easily listen in on when such an event occurs.
They should have the flexibility to handle this event however they wish (e.g. shake animation).

Using chrome 47.0.2526.80 and e.key is not defined.

i want to be able to do nothing on focus or pass in a function to do whatever i want
e.g. selecting just the first digit

Just follow the formatting conventions defined by the API.

Sign up for an opensource account and add the normal folk to the account

The amount control should allow the user to drag and drop values into/out of the input field.

Requirements

• Any invalid input dragged into the input field should be ignored
• Dragging a selection out of the input field should reformat the number (This is automatically done on 'focus out')
• Selecting a selection, and dragging it around inside the input field should reformat the number
• Handle dragging in shortcuts - expand [k, m, b] to [1000, etc...]

Leave this up to users.

Restrictions

• scale attempts to modify value to have more decimals digits than this are ignored default 2
• range -
  • all no restriction default
  • positive attempts to enter a negative value are ignored

Formatting

• fixed after focus is lost -
  • true value is formatted to scale number of decimals default
  • false to leave as entered
• decimal the character used for the decimal point default .
• thousands the separator used for thousands default ,

Other

• shortcuts object of character to multiplier default { k: 1000, m: 1000000, b: 1000000000 }

The amount control should support the usage of the following deletion methods:

Pressing the backspace key should remove the previous digit or skip over the previous delimiter

• Skip over
• Remove previous

Pressing the delete key should remove the digit ahead of it, or skip over the delimiter ahead

• Skip over
• Remove next

• Ctrl+backspace/delete should behave the same as backspace/delete
• Selecting various digits and pressing backspace/delete should only delete the selection

Release process is currently outdated and opaque

Just to run the build

Pressing the up/down arrow on the keyboard should increment/decrement the amount in the field by one

The finput github page (http://scottlogic.github.io/finput/) is looking rather basic and still states it is maintained by Ali at the bottom.

Give this page a new lick of paint and update any relevant outdated areas

Cleanup obsolete code

Different countries use different thousands and decimal delimiters.

Requirements

• Allow a country to be passed in as a config option which as preset values (e.g. uk = comma and decimal, dk = decimal and comma)
• Allow the thousands / decimal delimiters to be manually overidden via config options

Steps to reproduce:

1. Enter 1m into input field
2. Drag the 'finput' text into the field
3. The number is now 0
4. When I drag in a single character, the input would be ignored. However, with multiple characters the number is wiped

Just a nice consistent way of adding documentation.

The amount control should support a user performing the undo/redo action

Requirements

• Undo should restore the input fields value to its previous state (ctrl-z)
• Redo should restore an undo (ctrl-y)

We should look at investigating updating our development dependencies to see what benefits it would provide