scottbedard / oc-shop-plugin Goto Github PK

API endpoints need to be created for SPA themes

Blocks #47

Steps to reproduce

1. Enable CSRF protection
2. Create a category with a filter

Expected result
The category and filter should be created

Actual result
An error of Invalid security token.

Steps to reproduce

• Create an option with a deleted value
• Click save

Expected result
A validation error should be thrown

Actual result
The option is created with no values

Blocks #42

Options and inventories are being duplicated after saving the product page

This might be an abuse of GitHub images, but worse things have happened.

Components need to be made for traditional October themes

Blocks #46

This bug is caused by the option component not being aware of the IDs of newly created options. The easiest solution should be to reload the form whenever save is clicked, but a better solution would be to just reload the formwidget.

Steps to reproduce

1. Create a product with a new option
2. Save the product
3. Click save again

Expected result
The product should be saved with one option.

Actual result
The product is saved with duplicate options.

Continuous integration needs to also be set up for https://bedard.shop

When logging into the backend for the demo site, the following error message is flashed:

Unexpected type of array, should attribute "value_data" be jsonable?

Leaving this here as a note to self. Before rolling this plugin out to the marketplace, make sure we are not creating a situation where the backend can be inaccessible.

See octobercms/october#1180 for more info.

The UI comonents are feeling quite good to use now, and should be extracted to a dedicated repository so they can be re-used across different plugins.

Reproduction example 1

1. Open the options popup
2. Press tab down to the values field
3. Press shift + tab

Expected result
The focus should return to the placeholder

Actual result
Nothing happens

Reproduction example 2

1. Enter a couple of values
2. Focus a value and press tab / shift+tab

Expected result
The focus should move to next / previous input

Actual result
Focus jumps to the surrounding anchor tags

Situations in which prices need to be calculated

• Categories are reordered in bulk
• Categories are reordered individually
• Categories are deleted in bulk
• Category is deleted
• Discount is created
• Discount is saved
• Discount is deleted
• Product is created
• Product is saved
• Product is moved into a discounted category
• Product is moved out of a discounted category

There is a bunch of lingering code from the original reordering library. Go back in and clean up any events that don't need to be emitted, and remove the extra dependency.

Continuous integration also needs to be setup for https://bedard.shop

Steps to reproduce

• Create an option with some values
• Open the option and delete a value
• Save the product

Expected result
The value should be deleted

Actual result
The value persists

The plan is to create the absolute bare minimum of necessary features, get it to the marketplace, and then improve it from there. The following is a list of features expected to be in the first release (0.1).

• Products that can belong to categories
• Options / inventory management for products
• Interchangeable payment and shipping drivers

Situation in which categories need to be synchronized with their inherited products

• Categories are reordered in bulk
• A category's parent_id is changed from category form
• Product category relationship is synced

Steps to reproduce

1. Create an option with two values
2. Delete one of the values
3. Save the form

Expected result
Upon opening the option form again, the deleted value should be removed

Actual result
The deleted value persists

Blocks #42

API endpoints needed

• Categories (read)
• Category (read)
• Cart (create, read, update)
• Order (create, read)
• Product (read)

Just a small readability improvement, leaving this here as a note to self more than anything...

// current api
trans('bedard.shop.foo.bar.baz', lang);

// future api
trans('bedard.shop::foo.bar.baz');

When a product is inherited into a category it is already in, it causes a key collision.

Steps to reproduce

1. Create a category structure Parent > Child
2. Create a product in both Parent and Child

Expected result
The product should be created and exist in both categories

Actual result
The create fails because the parent/child ids must be unique.

Proposed solution
Include the is_inherited column in the unique key.