scopelift / zeneth Goto Github PK

Technical

• Option 1: Look into websockets from server --> Flashbots and server --> frontend
• Option 2: Submit one block at a time through relayer so it is unlikely to timeout

Also: ask Flashbots team about enabling CORS or whitelisting Zeneth

UX / Frontend

• Show pending bundle indicator
• Counter for the valid blocks remaining
• What to show if it fails? --> Simple error message. Content? --> "Your transactions was not included by miners. Please try again."

• Set up netlify with manual deploys
• Configure DNS & SSL for zeneth.app
• Get automated deploys working

On the transfer form, round the numbers here to two decimals:

Max gas costs for:

• Approves
• Transfer
• Swap

Add to cacher

Create a token list for initial launch tokens that includes fields for gas estimation for each of these actions.

The SwapBriber accrues ETH profits via trades. A privileged account needs the ability to withdraw these.

After completion of #29 and #28, update to include in frontend. Ideally display some kind of status to the user:

• Pending
• Successful
• Not included by miners
• Error
• ??

• Small UX improvements
• Devops Improvements (get auto deploys working)
• Adding more tokens to list that can be transferred
• Debugging the MetaMask-doesn't-pop-up issue
• Getting L2 Entry working + adding L2s
• Moving some functionality to the backend
  • Bundle signing
  • Managing token list
  • Bundle submission
• Custom RPC Backend Approach
• Getting other DeFi functions working
  • DEX Swaps
  • Deposit/withdrawal to yield protocols (Compound, AAVE, Yearn, etc..)
  • Other? (What DeFi actions are especially subject to front running / sandwich attacks?)
• Preparing for EIP-1559
• RPC + Browser extension approach

• Add Logo and header
• Add cleaner colors/branding/styles
• Add homescreen with options/buttons and separate form screens for:
  • Gasless L2 Entry
  • Gassless token transfer
• Cleanup entry forms; use regular numbers instead of raw decimals
• Show various L2's in drop down selection for gasless L2 Entry, bonus: show logos
• ...?

In the header status widget, rather than showing the full connected address, show first four, "...", and last four. For example:

0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045 would appear as 0xd8d...6045

Hovering over the truncated address should show a tooltip with the full address text.

• The JS Library
• Pull into zeneth-api

Note: Needs to be pinned to minor versions

Hard requirements for the absolute MVP to get to mainnet:

• Top Line Features:
  • Gasless token transfer
    • High liquidity / quality token list (Uniswap default token list?)
    • Arbitrary tokens ✂️
  • Gasless L2 Entry ✂️
    • zkSync
    • Any other L2 ✂️
• Usability features
  • Proper fee estimation - This requires figuring out how much gas the user action will take, adding some padding for profit, then using this to inform the swap params in the final bundle tx
  • Show the user the status of the transaction bundle after submission - Rather than using the promises from the flashbots SDK, figure out what the SDK is doing under the hood, and mimic that in an endpoint in our backend, then poll that endpoint
  • Switch to Uniswap v3?
• UI Polish
  • Background colors
  • Cleanup wallet section of header
  • Cleanup project name/logo section of header
• Dev considerations
  • Upgrade to the latest Flashbots version
  • Frontend deployment
  • DNS configuration
• Legal/administrative considerations
  • Add Privacy policy & terms of service
  • Beta warning

Want to add:

• USDC
• USDT
• BUSD

For each token, need to:

• Use Dune to estimate approve
• Use Dune to estimate transfer
• Find a way to estimate swapAndBribe

Attempts to import contract artifacts using...

import * as UniswapV2FactoryArtifact from '@uniswap/v2-core/build/UniswapV2Factory.json';
import * as UniswapV2Router02Artifact from '@uniswap/v2-periphery/build/UniswapV2Router02.json';

...fails with the following error...

Cannot find module '@uniswap/v2-core/build/UniswapV2Factory.json'. Consider using '--resolveJsonModule' to import module with '.json' extension.ts(2732)

Using a contract will allow us to make the tx atomic, which should provide a bit of protection from uncle leak attacks of any kind.

Possible function signature:

function transferAndBribe(address _token, uint256 _tokenAmount, address _receiver, uint256 _ethBribe);

Possible function state vars:

• uint256 fee
• address owner

Function logic:

• Perform transferFrom of _tokenAmount of _token (implies pre-approval)
• Swap tokens for exact eth amount _ethBribe + fee (via uniswap v2 router)
• transfer amount of fee to owner
• transfer amount of _ethBribe to coinbase
• ERC20 transfer remaining tokens to _receiver

Overall this would only need 2 txs, right?

1. Approval
2. transferAndBribe function call

Other thoughts/questions

• Presumably owner should be able to update fee
• OR should fee somehow be dynamic, calculated as percentage of send, etc...?
• Can the function find the uniswap path internally, or assume/calculate a token/ETH pair, or does the path for the swap also need to be part of the function signature?
• Any other approaches that might be more gas efficient?
• Any security concerns, loss of fund risks? Rebasing tokens? Etcc..?

Currently bumps directly into the right edge of the browser window:

• Use hardcoded token list provided from #21
• Show images
• Make it searchable

Im trying to run the relayer.test.ts file but im getting error 0 gas price txs no longer accepted after eip-1559

  const tx1 = {
            chainId,
            data: transferData,
            from: user.address,
            gasLimit: BigNumber.from('250000'),
            gasPrice: Zero,
            nonce,
            to: dai.address,
            value: Zero,
   };

Next to "Miner Incentive Multiplier" add a little "Info Icon" (example here. When the user hovers over the (i), show a tooltip message that says: "The amount we'll multiply the prevailing market gas rate by when bribing the miner to incentivize them to include your transactions directly in the block."

getting this error:

message: "err: max fee per gas less than block base fee: address, maxFeePerGas: 0 baseFee: 8; txhash 0x5ca323712793b97c1319fed36cc5229dbc4b5fb33b270a0f985c2c8de9d96c2f"

I am just playing around this project, further gas optimizations and flashbots. I am new with ethers-hardhat-typechain stack
While running npm build I am running into below type errors. Can you please suggest how to solve these issues

volta is installed

before building

volta pin [email protected]
node -v v14.16.1

tsc -v

Volta error: Could not locate executable tsc in your project.

Please ensure that all project dependencies are installed with npm install or yarn install

volta pin yarn

Build

yarn

yarn install v1.22.10 warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json. [1/4] Resolving packages... [2/4] Fetching packages... info [email protected]: The platform "linux" is incompatible with this module. info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation. info [email protected]: The platform "linux" is incompatible with this module. info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation. [3/4] Linking dependencies... warning "workspace-aggregator-ab8edd8e-278f-40ee-9168-559e4c7ad63d > @scopelift/zeneth-js > @flashbots/[email protected]" has incorrect peer dependency "ethers@^5.1.4". warning "workspace-aggregator-ab8edd8e-278f-40ee-9168-559e4c7ad63d > @scopelift/zeneth-frontend > [email protected]" has incorrect peer dependency "ethers@^4". warning "workspace-aggregator-ab8edd8e-278f-40ee-9168-559e4c7ad63d > @scopelift/zeneth-frontend > [email protected]" has incorrect peer dependency "react@^16.8". warning "workspace-aggregator-ab8edd8e-278f-40ee-9168-559e4c7ad63d > @scopelift/zeneth-frontend > [email protected]" has incorrect peer dependency "react-dom@^16.8". warning "workspace-aggregator-ab8edd8e-278f-40ee-9168-559e4c7ad63d > @scopelift/zeneth-contracts > hardhat-gas-reporter > [email protected]" has unmet peer dependency "@codechecks/client@^0.1.0". warning "workspace-aggregator-ab8edd8e-278f-40ee-9168-559e4c7ad63d > @scopelift/zeneth-frontend > web3-react > @0x/subproviders > eth-lightwallet > [email protected]" has incorrect peer dependency "bitcore-lib@^0.16.0". [############################################################################################################################################################---------------------------------] 53463/64956^[4/4] Building fresh packages... [8/16] ⠈ keccak [-/16] ⠈ waiting... [-/16] ⠈ waiting... [15/16] ⠈ node-hid

$ husky install && lerna run prepare husky - Git hooks installed lerna notice cli v4.0.0 lerna info versioning independent lerna info Executing command in 1 package: "yarn run prepare" @scopelift/zeneth-js: yarn run v1.22.10 @scopelift/zeneth-js: $ yarn build @scopelift/zeneth-js: $ tsc --build @scopelift/zeneth-js: Done in 0.70s. lerna success run Ran npm script 'prepare' in 1 package in 1.1s: lerna success - @scopelift/zeneth-js Done in 226.56s.

tsc -v
Version 4.2.4

yarn build

yarn run v1.22.10 $ lerna run build lerna notice cli v4.0.0 lerna info versioning independent lerna info Executing command in 3 packages: "yarn run build" @scopelift/zeneth-contracts: $ hardhat compile @scopelift/zeneth-js: $ tsc --build @scopelift/zeneth-frontend: $ next build @scopelift/zeneth-frontend: info - Using webpack 5. Reason: future.webpack5 option enabled https://nextjs.org/docs/messages/webpack5 @scopelift/zeneth-frontend: info - Checking validity of types... @scopelift/zeneth-contracts: Solidity 0.8.4 is not fully supported yet. You can still use Hardhat, but some features, like stack traces, might not work correctly. @scopelift/zeneth-contracts: Learn more at https://hardhat.org/reference/solidity-support" @scopelift/zeneth-contracts: Nothing to compile @scopelift/zeneth-frontend: Failed to compile. @scopelift/zeneth-frontend: ./src/components/Connection.tsx:37:28 @scopelift/zeneth-frontend: Type error: Binding element 'props' implicitly has an 'any' type. @scopelift/zeneth-frontend: 35 | } @scopelift/zeneth-frontend: 36 | @scopelift/zeneth-frontend: > 37 | const ConnectionModal = ({ props }) => { @scopelift/zeneth-frontend: | ^ @scopelift/zeneth-frontend: 38 | const { clearModal } = useContext(ModalContext); @scopelift/zeneth-frontend: 39 | const { connector, chainId, activate, deactivate, error } = useWeb3React<Web3Provider>(); @scopelift/zeneth-frontend: 40 | const { activatingConnector, setActivatingConnector, triedEager } = props; @scopelift/zeneth-contracts: Creating Typechain artifacts in directory typechain for target ethers-v5 @scopelift/zeneth-frontend: error Command failed with exit code 1. @scopelift/zeneth-frontend: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. lerna ERR! yarn run build exited 1 in '@scopelift/zeneth-frontend' lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

So that we can have a more precise verification of the estimateFee calculation, need stubs/mocks of the "getGasPrice", "getTokenPriceInUsd", and "getEthPriceInUsd" helper methods that return known values.

• Update estimate fee method to return tuple that includes ETH bribe for miner
• Update frontend to include profit-padding on the token fee from the estimate fee method (hardcoded 5% multiplier for now)
• Display the padded token fee to the user in the interface (Cannot be edited)
• Included padded token fee & original ETH bribe estimate as params to swapAndBribe call
• Stretch requirement: let the user choose high/low fee setting, which adjusts the flashbots premium
• Ensure token balance is sufficient after fee is included; show validation error or toast if it's not (example: user has 1000 DAI, tries to send 980, but fee is 40)

• Privacy Policy
• Terms of Service

How to figure out gas that will be used by the transactions

• Using the simulation
  • If the user has ETH, we can have the flashbots simulation tell us
  • If the user doesn't have ETH, the simulation will fail— could MEV geth change this?
  • Does the user have to sign the txs first? This makes for a weird UX, and also a problem in getting the amounts right before having the user sign
  • Also state related issue— what if user doesn't have token balance by final swapAndBribe, etc...
• Estimate and hardcode for token transfers <--- probably MVP approach
  • Populating values for the initital token list
    • Look up a few approves, transfers, and swaps on Etherscan and eyeball it
    • Use Dune analytics query or etherscan API to pull values

Gas usage heuristic— how to figure out the gas price

• Extremely naive option: multiply current gas price by 2 or 3
• Other ideas: historical flashbots txs from API, last block tail gas, etc...
• Ask Flashbots team for recommendations, likely to be impacted by bundle merging

User Experience

• Once we have the gas estimate, show it in the selected token
• Cannot be edited (?) (future— got higher but not lower?)
• What happens if token balance is insufficient after fee is included? -- Toast or Form Validation on amount

Note: look into other solutions

• Background colors
• Cleanup wallet section of header
• Cleanup project name/logo section of header

• In the wallet status widget: attempt ENS reverse resolution using the ethers.js reverse resolution functionality, and show the .eth name if one is returned instead of the full address. Show the address in a tooltip on hover.
• On the transfer form: In the recipient field, allow the user to type an ENS name. When they exit the field, resolve the address and update the form to show it. If resolution fails, show an in line error

Getting the following simulation failure on main when running yarn test in zeneth-js: