Comments (4)
Additional info:
It looks like GoldenSample is generating a different set of points with version 0.2.19.
[email protected] includes the lower bound as the first sample when we use GoldenSample(). This was not the case with [email protected] which maintained an offset. For example, if we do:
using QuasiMonteCarlo
lb = [0.125, 5.0, 5.0]
ub = [1.0, 10.0, 10.0]
n_test = 5
transpose(QuasiMonteCarlo.sample(n_test, lb, ub, GoldenSample()))
We get the following results:
With [email protected]:
0.192681 5.96681 6.29918
0.697863 9.43361 5.09836
0.328044 7.90042 8.89754
0.833226 6.36723 7.69671
0.463407 9.83403 6.49589
With [email protected] (note that the first record is the same as the lower bound):
0.125 5.0 5.0
0.841776 8.35522 7.7485
0.683552 6.71044 5.497
0.525328 5.06565 8.24551
0.367104 8.42087 5.99401
from quasimontecarlo.jl.
This issue may partly be caused by what appears to be a minor indexing issue in Kronecker.jl:
return @. mod(generator * (0:(n - 1))' + g.origin, 1)
should be
return @. mod(generator * (1:(n))' + g.origin, 1)
Also, the source article suggests that a seed of 0.5 works better. This suggestion had been implemented in prior versions but seems to have been removed in 0.2.19?
from quasimontecarlo.jl.
@ParadaCarleton can you take a look at this?
from quasimontecarlo.jl.
@ParadaCarleton can you take a look at this?
Will make a PR today correcting these issues as part of a general refactor (breaking everything into files, fixing names, and some other stuff).
from quasimontecarlo.jl.
Related Issues (20)
- use SafeTestsets HOT 1
- ERROR: UndefVarError: `UniformSample` not defined
- Caching in sampling to have `sample!`
- https://github.com/SciML/QuasiMonteCarlo.jl/pull/50 breaks downstream HOT 2
- Remove `Distributions` from dependencies HOT 7
- Base `b` Gray code
- Lazy iteration over points HOT 3
- Evenly distributed samples? HOT 6
- skip=n argument for parallelization? HOT 3
- Halton Sample not defined HOT 4
- Sobol' Sequence Missing First 4 Points HOT 2
- Error in sample() usage HOT 3
- Incorrect Halton Sequence HOT 5
- Integrate QMCGenerators.jl Features
- Estimators and Statistics for RQMC Integraiton HOT 4
- Citation HOT 1
- Improve docstrings
- GridSample appears to sample on a line HOT 1
- Randomized Halton sequence? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quasimontecarlo.jl.