Some zooming issues still persist with zooming in the ImageDisplay widget.

Hi,

In the interests of cross lab collaborations (and the fact @yxqd and @JeanBilheux were partly responsible for it). Would you consider moving this repo into the https://github.com/scikit-beam organisation ? I think that it would be a good place to collect custom widgets from other places.

Thoughts ?

Cheers
Stu

some dependencies are missing. need to update environment.yaml

Using fileselector.FileSelectorPanel on analysis computer (cg1d-analysis2...), tool crash when reaching home folder. Error message is

FileNotFoundError: [Errno 2] No such file or directory: '/SNS/users/j35/thindrives'

would it be possible to double click a folder to enter this one, instead of clicking at the bottom of the panel the "Enter Folder". I noticed a few users who all add the same reflex of double clicking to try to enter the folder.

See conda-forge/staged-recipes#5319. Trying to get conda recipe accepted into conda-forge

Changes from 0.1.2a1:

• Added LICENSE

Things to do

• Update version numbers in _version.py/meta.yaml/package.json
• git add and git commit
• tag: git tag -a X.X.X -m 'comment'
• push: git push ; git push --tags
• build and upload

  conda build conda-recipes
  anaconda login
  anaconda upload /path/to/ipywe-...tar.bz2
  

• Update version numbers (set release version, remove 'dev') in
  • _version.py
  • meta.yaml
  • package.json
• git add and git commit
• tag

git tag -a X.X.X -m 'comment'

• push

git push
git push --tags

• build and upload

conda build conda-recipes
anaconda login
anaconda upload /path/to/ipywe-...tar.bz2

versioning is now scattered. need to be centralized for easier maintenance

The instruction for distributing custom ipython widgets can be found here: http://ipywidgets.readthedocs.io/en/latest/examples/Widget%20Custom.html?highlight=distribution
A template project can be created using cookiecutter for ipywigets: https://github.com/jupyter-widgets/widget-cookiecutter

So here we need to follow the template and refactor the code so that this package can be distributed.

Should we add a requirement.txt file to this project in order to know what are all necessary libraries?

I'm not sure if this is an issue or not, but I'll put it here just in case.

Currently, when you install ipywe through conda, it installs version 0.1.0. However, in the _version.py and package.json files, the version is 0.1.1a1. Also, the current conda installation does not contain several changes made to the ImageSlider and ImageDisplay widgets.

Tickets closed:

• #62

Things to do

• Update version numbers in
  • _version.py
  • meta.yaml
  • package.json
• git add and git commit
• tag

git tag -a X.X.X -m 'comment'

• push

git push
git push --tags

• build and upload

conda build conda-recipes
anaconda login
anaconda upload /path/to/ipywe-...tar.bz2

A widget that allows viewing an image series with cursor coordinates and value outputs and contrast adjustment.

Widgets may have different dependencies. Do we need to add all dependencies to conda meta.yaml and setup.py? Some users of this package may only need one widget that has minimal dependencies, while some users may need widgets that requires installation of a lot of dependencies. Should we delegate to each widget to declare its dependency. Is the "extras_require" for setup.py good for this?

• ROI: left=?, right=?, ...
• Z range: also show the current z-range set by the contrast control

1. Need to compare the current algorithm for the diagonal calculation with the vector-based algorithm.
2. Look into the matplotlib.pyplot.hist() and numpy.histogram() functions.

Current bugs and features to add:

1. Make zooming apply to all images at the same time
2. Fix bug where zooming on an image breaks after changing images
3. Fix bug where coordinate and value display breaks after first zoom
4. Maybe add an individual button for zooming on all images

PR:

• #68

Things to do

• Update version numbers in
  • _version.py
  • meta.yaml
  • package.json
• git add and git commit
• tag
  git tag -a X.X.X -m 'comment'
• push

  git push
  git push --tags
  

• build and upload

  conda build conda-recipes
  anaconda login
  anaconda upload /path/to/ipywe-...tar.bz2
  

see the original file and its history

After performing the development installation, I've been trying to make some small formatting changes in the ImageSlider and ImageDisplay widgets by changing the JavaScript code (changes in the tomorecon-prep branch). However, no matter what I try, I cannot get any of these changes to appear when testing them. I suspect this is a bug with the distribution process (either our implementation or the cookiecutter's implementation), but I'm not sure.

When I try to run the ImageSlider widget on Python 3 (3.6) I get the following series of errors in the web console:

> Wrong widget protocol version: received protocol version '', but was expecting major version '2'
> Couldn't process kernel message Wrong widget protocol version: received protocol version '', but was expecting major version '2'

Also, beneath the code cell (where the widget would normally appear, I got the following:

Widget Javascript not detected. It may not be installed or enabled properly.
Error rendering Jupyter widget. Widget not found:
{"model_id":"b030ed1215ff467dbba5de6cb5b299f"}

Tickets closed: https://github.com/scikit-beam/ipywe/milestone/2?closed=1

• Update version numbers in
  • _version.py
  • meta.yaml
  • package.json
• git add and git commit
• tag

git tag -a X.X.X -m 'comment'

• push

git push
git push --tags

• build and upload

conda build conda-recipes
anaconda login
anaconda upload /path/to/ipywe-...tar.bz2

@yxqd
I just tried to see if the conda install ipywe command would work on my computer, and conda did not find it. Instead it raised the following error:

PackageNotFoundError: Package missing in current linux-64 channels: 
  - ipywe

Close matches found; did you mean one of these?

    ipywe: pywget

In my local version of fileselector, I added a couple of method that allow to quickly retrieve the path selected

input_folder_ui = fileselector.FileSelectorPanel(instruction='Select Image Folder', type='directory', 
                                                start_dir=working_dir, multiple=False)
input_folder_ui.show()

to retrieve the selection

> full_path_selection = input_folder_ui.result_full_path()
>basename_path_selection = input_folder_ui.result()

Here are the 2 methods in case you are interested

def result(self):
        _result = self.widgets[1].value
        if self.multiple:
            _selection = [_folder.split('|')[0].strip() for _folder in _result]
            return _selection
        else:
            return _result.split('|')[0].strip()
    
def result_full_path(self):
       _result = self.widgets[1].value
       if self.multiple:
            _selection = [_folder.split('|')[0].strip() for _folder in _result]
            full_path = [os.path.join(self.curdir, _file) for _file in _selection]
       else:
            _result = _result.split('|')[0].strip()
            full_path = os.path.join(self.curdir, _result)
       return full_path    

The fileselector within the notebook is a awesome feature but sometimes we have to go through a lot of folders before reaching our final folder, it would be nice if there was on top of the widgets, a text box that allow us to enter the path manually.

When the widget is used to just select a file or a directory, the "new dir" button is not useful. Let us make this feature optional.

In the FileSelectorPanel, users can select folders or files once they click SELECT. But sometimes they get confused about which cell to run next as the same cell is still validated. It would be a very nice feature if the next cell could be enabled as it will avoid confusion and speed up the execution process of the notebook.

The zooming of the image display works well. The widget can be more useful with the following functionalities:

• show x y coordinates and value
• add contrast selector

Example code to build a wizard

Changes from 0.1.1a9 (#71):

• #72: fileselector: added search box

Things to do

• Update version numbers in _version.py/meta.yaml/package.json
• git add and git commit
• tag: git tag -a X.X.X -m 'comment'
• push: git push ; git push --tags
• build and upload

  conda build conda-recipes
  anaconda login
  anaconda upload /path/to/ipywe-...tar.bz2
  

When the z-range (contrast control) is adjusted, the z-value display does not give the correct value. It should show the pixel value in the original image, not the value in the range limited by the z-range control.

fileselector is mostly working. Here are a few improvements that I would like to work on

• Documenting the constructor
• The css. Be sure that we are setting css for just this widget.
• Signature of the callback function. It should probably take the selection as the input.

Changes in 0.1.3a1:

• #88: replace scipy resize with PIL resize
• There are more

Things to do

• Update version numbers in _version.py/meta.yaml/package.json
• git add and git commit
• tag: git tag -a X.X.X -m 'comment'
• push: git push ; git push --tags
• update recipe at https://github.com/conda-forge/ipywe-feedstock/tree/master/recipe.
  • cmd to get sha256: openssl sha256 /path/to/...tar.gz

Clean up the implementation a bit

@JeanBilheux asked for the capability to create new subdir.

Make a "stable" release.

Changes from 0.1.2a2:

• None

Things to do

• Update version numbers in _version.py/meta.yaml/package.json
• tag and push:
  git tag -a X.X.X -m 'comment'
git push --tags

When user enter a search string and hit enter, the search works but the search string is still there. Any other folder selection will keep the search criteria...even if it looks like the string has been cleaned up.

Using python 3.5, I get the following error when trying to import imageslider

>>> import ipywe.imageslider
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-9-0da379c41c9d> in <module>()
      1 import NeuNorm
----> 2 import ipywe.imageslider
      3 from __code.normalization import utilities, gui_widgets
      4 
      5 ipts = utilities.get_ipts()

/Users/j35/anaconda/envs/py35/lib/python3.5/site-packages/ipywe/imageslider.py in <module>()
      2 from . import base
      3 from IPython.display import display, HTML, clear_output
----> 4 from cStringIO import StringIO
      5 from traitlets import Unicode, Integer, Float, HasTraits, observe
      6 import sys, os

ImportError: No module named 'cStringIO'

A new blank line gets inserted at the top of the panel every time a folder is entered. After entering a few folder, user always needs to scroll down to see the entire panel.

Refs #19

Right now ipywe is hosted at "neutrons" anaconda channel. Should move recipe to https://github.com/scikit-beam/skbeam-recipes/tree/master/recipes. @stuartcampbell: are recipes there automatically built and uploaded?

Changes:

• #70: fileselector: added options for filter and "stay-alive"
• acb365e: wizard: "previous" and "next" buttons

Things to do

• Update version numbers in
  • _version.py
  • meta.yaml
  • package.json
• git add and git commit
• tag
  git tag -a X.X.X -m 'comment'
• push

  git push
  git push --tags
  

• build and upload

  conda build conda-recipes
  anaconda login
  anaconda upload /path/to/ipywe-...tar.bz2
  

Jiao,
Can you look over the setup.py file and confirm that it contains all the info that we need. It's in the ian-source branch.

Tickets closed: https://github.com/scikit-beam/ipywe/milestone/1?closed=1

• Update version numbers in
  • _version.py
  • meta.yaml
  • package.json
• git add and git commit
• tag

git tag -a X.X.X -m 'comment'

• push

git push
git push --tags

• build and upload

conda build conda-recipes
anaconda login
anaconda upload /path/to/ipywe-...tar.bz2

https://github.com/neutrons/ipywe/blob/766ba31f7dbe28a8148c18ad2ff8de5361161c25/docs/custom_widget_doc_pp.pptx

Maybe to a .md file.

Changes from 0.1.1:

• 1a83ca0

Things to do

• Update version numbers in _version.py/meta.yaml/package.json
• git add and git commit
• tag: git tag -a X.X.X -m 'comment'
• push: git push ; git push --tags
• build and upload

  conda build conda-recipes
  anaconda login
  anaconda upload /path/to/ipywe-...tar.bz2
  

Changes in 0.1.3a1:

• #78: bug fix in fileselector

Things to do

• Update version numbers in _version.py/meta.yaml/package.json
• git add and git commit
• tag: git tag -a X.X.X -m 'comment'
• push: git push ; git push --tags
• update recipe at https://github.com/conda-forge/ipywe-feedstock/tree/master/recipe.
  • cmd to get sha256: openssl sha256 /path/to/...tar.gz