Git Product home page Git Product logo

passwordstrengthpackage's People

Contributors

bmichotte avatar bobbybouwmann avatar clnt avatar closca avatar dalabad avatar dczajkowski avatar dsbilling avatar f-liva avatar fl0ux avatar jeroendedauw avatar jeroensmit avatar kduma avatar laravel-shift avatar mikkoaf avatar natali9t9 avatar salkhwlani avatar schuppo avatar silvanlaroo avatar snipe avatar soap avatar svenssontobias avatar trideout avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

passwordstrengthpackage's Issues

Rules not recognized in the reset password screen

Hello,
I found that the rules are not recognized in the reset password screen, even though I have added the following in ResetPasswordController.php :

protected function rules()
{
return [
'token' => 'required',
'email' => 'required|email',
'password' => 'required|string|between:9,255|case_diff|numbers|letters|symbols',
];
}

Russian language translation

return [
    'letters'       => 'Поле :attribute должно содержать по меньшей мере одну букву.',
    'case_diff'     => 'Поле :attribute должно содержать буквы разного регистра, например я и Я',
    'numbers'       => 'Поле :attribute должно содержать по меньшей мере одну цифру.',
    'symbols'       => 'Поле :attribute должно содержать по меньшей мере один символ, например @.',
]

Validation rules are displayed one at a time

Hi,

Firstly thanks for this package, it really helped me out.

One quite serious UX issue is that it will show validation errors one at a time. For example:

  • A user enters a password with no caps and gets an error about no caps
  • A user then enters a password with caps and gets an error about no numbers
  • A user then enters a password with caps and numbers and gets an error about no symbols

This is quite frustrating for users, I'm not sure what the solution is (if there is one) but I wanted to flag it up.

Cheers

Tom

Proposal for "fr" language translation

Here is my proposal for a "fr" translation :

return [
"letters" => "Le champ :attribute doit comprendre au moins une lettre.",
"case_diff" => "Le champ :attribute doit comprendre des lettres minuscules et majuscules.",
"numbers" => "Le champ :attribute doit comprendre au moins un nombre.",
"symbols" => "Le champ:attribute doit comprendre au moins un symbole (#,@,$, etc.)."
];

Cyrillic support

Hi!

Please, add "u" modifier to regex in validateCaseDiff for support cyrillic words

Add support for Laravel 9

Is it possible to add support for Laravel 9?

schuppo/password-strength                  v2.4      requires          illuminate/support (^5.1|^6.0|^7.0|^8.0)
schuppo/password-strength                  v2.4      requires          illuminate/translation (^5.1|6.*|7.*|8.*)

Chinese translation

Chinese Simplified (zh-CN)

<?php
return [
    "letters" => ":attribute 必须包含至少一个字母。",
    "case_diff" => ":attribute 必须包含大小写字母。",
    "numbers" => ":attribute 必须包含至少一个数字。",
    "symbols" => ":attribute 必须包含至少一个符号。",
];

Chinese Traditional (zh-TW)

<?php
return [
    "letters" => ":attribute 必須至少包含一個字母。",
    "case_diff" => ":attribute 必須包含大小寫字母。",
    "numbers" => ":attribute 必須至少包含一個數字。",
    "symbols" => ":attribute 必須至少包含一個符號。",
];

Wrong locale loaded for translations

Hi,

I am trying to use your package, but I have issues with translation. Our locale settings looks like this:

'locale' => 'de',
'fallback_locale' => 'en',

In the application the user can select de or en as his language. With de everything is ok. But when the user uses en the translations look like this: The password muss sowohl groß- als auch kleingeschriebene Buchstaben enthalten.

The issue is, that the translations are loaded before the user is even initialized and the package is loading the translations with the default locale.

Did you encounter similar issues?

Thanks.

edit: We are using Laravel 5.5.40 with auto-discovery

Lang update for L5

Can you add the following to the lang file as it isn't found in L5

"caseDiff" => "The :attribute must include both upper and lower case letters.",

Thanks for the great repository

Spanish translation

Sorry I can't make a proper PR just now:

On folder lang\es:

<?php
return [
    "letters" => "El campo :attribute debe incluir al menos una letra.",
    "case_diff" => "El campo :attribute debe incluir letras mayúsculas y minúsculas.",
    "numbers" => "El campo :attribute debe incluir al menos un número.",
    "symbols" => "El campo :attribute debe incluir al menos un símbolo.",
];

'confirmed' not working

Hey guys,
Thanks for the awesome plugin.

However since adding it, the 'confirmed' password validator is no longer working for me on Laravel 5.3

This does not work

    public function register(Request $request)
    {
        $this->validate($request, [
'password' => 'required|confirmed|min:6|case_diff|numbers|letters|symbols

however, this does.

    public function register(Request $request)
    {
        $this->validate($request, [
'password' => 'required|confirmed'

How can I take advantage of your plugin with confirmed?

and yes my div's are named _confirmation

                <!-- PASSWORD -->
                <label for="password">Password</label>
                <div class="input-group">
                    <input id="password" name="password" type="password" class="form-control" placeholder="Create a strong password" aria-describedby="sizing-addon2" />
                </div>

                <!-- CONFIRM PASSWORD -->
                <label for="password_confirmation">Confirm Password</label>
                <div class="input-group">
                    <input name="password_confirmation" type="password" class="form-control" placeholder="Repeat your strong password" aria-describedby="sizing-addon2"  />
                </div>

Hope you can help-
Thanks.

misguiding install instructions

do not suggest to use composer update in the install instructions. the only way to install a package should be composer require

Lumen compatibility

Hi, I'm using lumen 7 and this package is compatible with lumen.

For use, you need to add in app.php (boostrap). The following code:

$app->register(Schuppo\PasswordStrength\PasswordStrengthServiceProvider::class);

$ symbol not seen as special char?

i tried validating a password with the $ symbol in it, along with upper, lower, and numeric chars, but keep getting the message that a symbol must be included

is $ not considered a symbol?

thanks

[edit]
it appears a single $ is accepted but $$ is not and i get the "need a symbol" error message
[/edit]

CLOSED it is a bash thing - sorry

Laravel 7 Support

Hey!

Are there any plans to support Laravel 7? I would be happy to submit a PR if needed.

Setup Packagist Update Hook

I've noticed you've released 0.5.2 but this isn't available on Packagist.

It might be worth setting up a commit hook to update packagist automatically.

Service provider inverted slashes.

Hey man, great work. But I think your service provider have inverted slashes.

it should be 'Schuppo\PasswordStrength\PasswordStrengthServiceProvider', instead of 'Schuppo/PasswordStrength/PasswordStrengthServiceProvider', no?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.