schreiber-und-freunde / porky Goto Github PK

Actually, you use a global settings object, which could be prevented.
Also, all the functions are made public.

You could wrap them in a porky object to keep the namespace clean.
For compatibility reasons you could export the functions to the global namespace.

right now it's hardcoded

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L90

instead of

var colMaxCount = new Array();

do

var colMaxCount =  [];

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L68

don't know if it's available but if it is that line can be rewritten as

JSON.stringify({
    "porky": {
        "dataSourceType": "SQLite",
        "dataSourceServer": "127.0.0.1",
        "dataSourceName": "TestDatabase",
        "dataSourceUsername": "Oliver",
        "dataSourcePassword": "1234",
        "dataSourceQuery": "SELECT * FROM bla"
    }
});

for example

var xmlAttrs = tagObject.parentStory.associatedXMLElement.xmlAttributes;

and then use xmlAttrs in all places where tagObject.parentStory.associatedXMLElement.xmlAttributes was used in the function.

test-excel-database-access.jsx

The documentation link under the project description leads to a 404 page. It appears that you migrated your website content to GitHub but didn't include any documentation. Please add it!

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L87

I've tried your library to improve the speed of importing data using a database source since I was using Excel and it was not fast enough considering that my project has 600+ link imported from the same Excel file. I wrote bits of code just inside a loop to test the speed of your implementation but it's even slower. The question that bothers me: Is it possible to write the code to do multiple queries to the database and to do multiple placements inside the Indesign document at the same time.

all the vars after this one:

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L34

I think it woud be better to have an object called settings, something like:

var settings = {
    dataSourceType: "",
    dataSourceServer: "",
    dataSourceName: "",
    dataSourceUsername: "",
    dataSourcePassword: "",
    syncScriptFolder: "",
    syncIdentifier: ""
};

also maybe some of them can have default values.

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L48

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L100

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L118

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L302

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L320

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L351

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L354

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L359

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L360

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L362

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L371

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L393

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L419

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L505

if it's going to be open source

this if/else https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L200

and this https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L217

look the same, if they are equal move them to a function and use it in both places.

the same for:

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L205

and

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L222
they seem to only differ on the object path, so something like:

function setOrAddAttr(xmlAttrs, value) {
    if (!xmlAttrs.item(key).isValid) {
        xmlAttrs.add(key, value);
    }else{
        xmlAttrs.item(key).value = value;
    }
}

function setOrAddSyncScript(xmlAttrs, syncScript) {
    setOrAddAttr(xmlAttrs, "syncScript", syncScript);
}

function setOrAddSyncIdentifier(xmlAttrs, syncIdentifier) {
    setOrAddAttr(xmlAttrs, "syncIdentifier", syncIdentifier);
}

and call it as

setOrAddSyncScript(tagObject.associatedXMLElement.xmlAttributes, syncScript);
setOrAddSyncScript(tagObject.parentStory.associatedXMLElement.xmlAttributes, syncScript);

and

setOrAddSyncIdentifier(tagObject.associatedXMLElement.xmlAttributes, syncIdentifier);
setOrAddSyncIdentifier(tagObject.parentStory.associatedXMLElement.xmlAttributes, syncIdentifier);

and integrate php cli

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/stop-porky-data-source-access.jsx#L20

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/start-porky-data-source-access.jsx#L23

in some places it's like this

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L172

and some others like this

https://github.com/Schreiber-und-Freunde/porky/blob/master/app/porky/bin/porky.jsx#L172

the preferred way is

for (var i = 0; i < items.length; i += 1) { ... }

or

var item;
for (var i = 0, len = items.length; i < len; i += 1) { 
    item = items[i];
    // do something with them
 }

where items is the array you want to iterate and item is a variable with a name that describe what item is