schm1tz1 / arduino-tsic Goto Github PK

I've noticed that the function getTemperture slows down dramtically if no sensor is connected. I think this is an issue because the timeout in the function readSensor is set too high.

My explanation for the slowing would be the following (please correct me if I'm wrong ;) )
The function reads out the PIN where a TSIC should be to measure the strobe time. Therefore, it waits for the start bit, i.e. until the level goes from HIGH to LOW ("while (TSIC_HIGH)....") and then measures the strobe time as the time when the PIN is in LOW state ("while (TSIC_LOW)..."). If no sensor is connected, the level is (IMO) either LOW or HIGH and does not change its state. Which means that it will run in the timeout either in the first while loop or in the second.

Currently, the timeout is checked with "#define Cancel() if (timeout==0){return 0;}". As timeout is of uint16_t type, it will be 0 again after adding 2^16=65k times 1.

Long story short, a "#define Cancel() if (timeout>10000){return 0;}" made my program faster.

What do you think of this change in the code?

btw: here is also some code for arduino&tsic:
http://www.andeanelectronic.com/?Supporte___Arduino_con_TSic306%2CTSic506_y_TSic716

Please revert readme.md to previous version to avoid confusion.
My readme.md contained already the documentation for my fork.
So my readme.md doesn't fit to your library.
Sorry, was my fault...

PS: I just uploaded my version of the library, if you want to have a look.